From: Joe Lawrence <joe.lawrence@redhat.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org,
Josh Poimboeuf <jpoimboe@kernel.org>,
Miroslav Benes <mbenes@suse.cz>, Petr Mladek <pmladek@suse.com>,
Marcos Paulo de Souza <mpdesouza@suse.com>
Subject: Re: [PATCH v7 00/10] livepatch: klp-convert tool
Date: Fri, 31 Mar 2023 12:03:52 -0400 [thread overview]
Message-ID: <f1351c5f-16aa-8407-753c-90049956123d@redhat.com> (raw)
In-Reply-To: <683593a8-79db-4f3b-bc78-7917284683e4@p183>
On 3/30/23 13:04, Alexey Dobriyan wrote:
> This patchset somehow breaks the build of the simplest livepatch module:
>
> make -f linux/linux-1/scripts/Makefile.modfinal
> make[1]: *** No rule to make target 'linux/module-klp/main.tmp.ko', needed by 'linux/module-klp/main.ko'. Stop.
>
Thanks for testing.
Presumably this is an out-of-tree livepatch module? If so, that is
still on the TODO list. If not, that is weird as the patchset itself
includes updates to samples/ and lib/ livepatches that build and load fine.
--
Joe
> $ cat Kbuild
> obj-m := main.o
>
> $ cat main.c
> #include <linux/module.h>
> #include <linux/kernel.h>
> #include <linux/livepatch.h>
> #include <linux/seq_file.h>
>
> static int livepatch_cmdline_proc_show(struct seq_file *m, void *data)
> {
> seq_puts(m, "REDACTED 001\n");
> return 0;
> }
>
> static struct klp_func funcs[] = {
> {
> .old_name = "cmdline_proc_show",
> .new_func = livepatch_cmdline_proc_show,
> },
> {}
> };
>
> static struct klp_object objs[] = {
> {
> .funcs = funcs,
> },
> {}
> };
>
> static struct klp_patch g_patch = {
> .mod = THIS_MODULE,
> .objs = objs,
> };
>
> static int livepatch_init(void)
> {
> return klp_enable_patch(&g_patch);
> }
>
> static void livepatch_exit(void)
> {
> }
> module_init(livepatch_init);
> module_exit(livepatch_exit);
> MODULE_LICENSE("GPL");
> MODULE_INFO(livepatch, "Y");
>
next prev parent reply other threads:[~2023-03-31 16:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 12:10 [PATCH v7 00/10] livepatch: klp-convert tool Alexey Dobriyan
2023-03-30 17:04 ` Alexey Dobriyan
2023-03-31 16:03 ` Joe Lawrence [this message]
2023-04-01 9:59 ` Alexey Dobriyan
2023-03-31 15:58 ` Joe Lawrence
-- strict thread matches above, loose matches on Subject: below --
2023-03-06 14:08 Joe Lawrence
2023-03-14 20:23 ` Marcos Paulo de Souza
2023-03-17 20:29 ` Joe Lawrence
2023-03-17 23:20 ` Josh Poimboeuf
2023-03-20 19:23 ` Joe Lawrence
2023-04-11 10:06 ` Nicolai Stange
2023-05-02 23:38 ` Marcos Paulo de Souza
2023-05-03 19:54 ` Joe Lawrence
2023-05-09 20:34 ` Marcos Paulo de Souza
2023-03-20 20:15 ` Marcos Paulo de Souza
2023-04-19 20:27 ` Marcos Paulo de Souza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1351c5f-16aa-8407-753c-90049956123d@redhat.com \
--to=joe.lawrence@redhat.com \
--cc=adobriyan@gmail.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mpdesouza@suse.com \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).