linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] video: fsl-diu-fb: Delete an error message for a failed memory allocation in fsl_diu_init()
@ 2017-11-27  9:00 SF Markus Elfring
  2017-11-27 17:31 ` Timur Tabi
  0 siblings, 1 reply; 3+ messages in thread
From: SF Markus Elfring @ 2017-11-27  9:00 UTC (permalink / raw)
  To: linux-fbdev, dri-devel, Bartlomiej Zolnierkiewicz, Timur Tabi
  Cc: LKML, kernel-janitors

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 27 Nov 2017 09:56:09 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/video/fbdev/fsl-diu-fb.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-diu-fb.c
index 25abbcf38913..1bfd13cbd4e3 100644
--- a/drivers/video/fbdev/fsl-diu-fb.c
+++ b/drivers/video/fbdev/fsl-diu-fb.c
@@ -1960,12 +1960,8 @@ static int __init fsl_diu_init(void)
 
 	of_node_put(np);
 	coherence_data = vmalloc(coherence_data_size);
-	if (!coherence_data) {
-		pr_err("fsl-diu-fb: could not allocate coherence data "
-		       "(size=%zu)\n", coherence_data_size);
+	if (!coherence_data)
 		return -ENOMEM;
-	}
-
 #endif
 
 	ret = platform_driver_register(&fsl_diu_driver);
-- 
2.15.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] video: fsl-diu-fb: Delete an error message for a failed memory allocation in fsl_diu_init()
  2017-11-27  9:00 [PATCH] video: fsl-diu-fb: Delete an error message for a failed memory allocation in fsl_diu_init() SF Markus Elfring
@ 2017-11-27 17:31 ` Timur Tabi
  2018-03-28 14:00   ` Bartlomiej Zolnierkiewicz
  0 siblings, 1 reply; 3+ messages in thread
From: Timur Tabi @ 2017-11-27 17:31 UTC (permalink / raw)
  To: SF Markus Elfring, linux-fbdev, dri-devel, Bartlomiej Zolnierkiewicz
  Cc: LKML, kernel-janitors

On 11/27/17 3:00 AM, SF Markus Elfring wrote:
> From: Markus Elfring<elfring@users.sourceforge.net>
> Date: Mon, 27 Nov 2017 09:56:09 +0100
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring<elfring@users.sourceforge.net>

Acked-by: Timur Tabi <timur@tabi.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] video: fsl-diu-fb: Delete an error message for a failed memory allocation in fsl_diu_init()
  2017-11-27 17:31 ` Timur Tabi
@ 2018-03-28 14:00   ` Bartlomiej Zolnierkiewicz
  0 siblings, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-03-28 14:00 UTC (permalink / raw)
  To: Timur Tabi, SF Markus Elfring
  Cc: linux-fbdev, dri-devel, LKML, kernel-janitors

On Monday, November 27, 2017 11:31:10 AM Timur Tabi wrote:
> On 11/27/17 3:00 AM, SF Markus Elfring wrote:
> > From: Markus Elfring<elfring@users.sourceforge.net>
> > Date: Mon, 27 Nov 2017 09:56:09 +0100
> > 
> > Omit an extra message for a memory allocation failure in this function.
> > 
> > This issue was detected by using the Coccinelle software.
> > 
> > Signed-off-by: Markus Elfring<elfring@users.sourceforge.net>
> 
> Acked-by: Timur Tabi <timur@tabi.org>

Patch queued for 4.17, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-03-28 14:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-27  9:00 [PATCH] video: fsl-diu-fb: Delete an error message for a failed memory allocation in fsl_diu_init() SF Markus Elfring
2017-11-27 17:31 ` Timur Tabi
2018-03-28 14:00   ` Bartlomiej Zolnierkiewicz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).