[PATCH] security/keys: Remove inconsistent __user annotation

* [PATCH] security/keys: Remove inconsistent __user annotation
@ 2022-09-07 12:12 Vincenzo Frascino
  2022-09-07 14:05 ` Randy Dunlap
  2022-09-08  5:08 ` Jarkko Sakkinen
  0 siblings, 2 replies; 7+ messages in thread
From: Vincenzo Frascino @ 2022-09-07 12:12 UTC (permalink / raw)
  To: linux-security-module, linux-kernel
  Cc: Vincenzo Frascino, David Howells, Jarkko Sakkinen, Paul Moore,
	James Morris

The declaration of keyring_read does not match the definition
(security/keys/keyring.c). In this case the definition is correct
because it matches what defined in "struct key_type::read"
(linux/key-type.h).

Fix the declaration removing the inconsistent __user annotation.

Cc: David Howells <dhowells@redhat.com>
Cc: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Paul Moore <paul@paul-moore.com>
Cc: James Morris <jmorris@namei.org>
Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
---
Note: This issue was discovered during the porting of the linux kernel
on Morello [1].

[1] https://git.morello-project.org/morello/kernel/linux

 security/keys/keyring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/keys/keyring.c b/security/keys/keyring.c
index 5e6a90760753..4448758f643a 100644
--- a/security/keys/keyring.c
+++ b/security/keys/keyring.c
@@ -79,7 +79,7 @@ static void keyring_revoke(struct key *keyring);
 static void keyring_destroy(struct key *keyring);
 static void keyring_describe(const struct key *keyring, struct seq_file *m);
 static long keyring_read(const struct key *keyring,
-			 char __user *buffer, size_t buflen);
+			 char *buffer, size_t buflen);
 
 struct key_type key_type_keyring = {
 	.name		= "keyring",
-- 
2.37.3


^ permalink raw reply related	[flat|nested] 7+ messages in thread