* [PATCH] fb: adv7393: Use IS_ENABLED() instead of checking for built-in or module
@ 2016-07-11 20:44 Javier Martinez Canillas
2016-08-10 10:55 ` Tomi Valkeinen
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2016-07-11 20:44 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, linux-fbdev, Tomi Valkeinen,
Jean-Christophe Plagniol-Villard
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/video/fbdev/bfin_adv7393fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/bfin_adv7393fb.c b/drivers/video/fbdev/bfin_adv7393fb.c
index 8fe41caac38e..9a01cd7ca73c 100644
--- a/drivers/video/fbdev/bfin_adv7393fb.c
+++ b/drivers/video/fbdev/bfin_adv7393fb.c
@@ -795,7 +795,7 @@ static struct i2c_driver bfin_adv7393_fb_driver = {
static int __init bfin_adv7393_fb_driver_init(void)
{
-#if defined(CONFIG_I2C_BLACKFIN_TWI) || defined(CONFIG_I2C_BLACKFIN_TWI_MODULE)
+#if IS_ENABLED(CONFIG_I2C_BLACKFIN_TWI)
request_module("i2c-bfin-twi");
#else
request_module("i2c-gpio");
--
2.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fb: adv7393: Use IS_ENABLED() instead of checking for built-in or module
2016-07-11 20:44 [PATCH] fb: adv7393: Use IS_ENABLED() instead of checking for built-in or module Javier Martinez Canillas
@ 2016-08-10 10:55 ` Tomi Valkeinen
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2016-08-10 10:55 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: linux-fbdev, Jean-Christophe Plagniol-Villard
[-- Attachment #1.1: Type: text/plain, Size: 1011 bytes --]
On 11/07/16 23:44, Javier Martinez Canillas wrote:
> The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
> built-in or as a module, use that macro instead of open coding the same.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> drivers/video/fbdev/bfin_adv7393fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/bfin_adv7393fb.c b/drivers/video/fbdev/bfin_adv7393fb.c
> index 8fe41caac38e..9a01cd7ca73c 100644
> --- a/drivers/video/fbdev/bfin_adv7393fb.c
> +++ b/drivers/video/fbdev/bfin_adv7393fb.c
> @@ -795,7 +795,7 @@ static struct i2c_driver bfin_adv7393_fb_driver = {
>
> static int __init bfin_adv7393_fb_driver_init(void)
> {
> -#if defined(CONFIG_I2C_BLACKFIN_TWI) || defined(CONFIG_I2C_BLACKFIN_TWI_MODULE)
> +#if IS_ENABLED(CONFIG_I2C_BLACKFIN_TWI)
> request_module("i2c-bfin-twi");
> #else
> request_module("i2c-gpio");
>
Thanks, queued for v4.9.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-10 20:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-11 20:44 [PATCH] fb: adv7393: Use IS_ENABLED() instead of checking for built-in or module Javier Martinez Canillas
2016-08-10 10:55 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).