From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Iwona Winiarska <iwona.winiarska@intel.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
openbmc@lists.ozlabs.org, Paul Fertser <fercerpav@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH] hwmon: (peci/cputemp) Fix miscalculated DTS for SKX
Date: Tue, 21 Mar 2023 10:41:55 +0100 [thread overview]
Message-ID: <f2fe16cf-3838-df89-958f-c39d1bae81a1@molgen.mpg.de> (raw)
In-Reply-To: <20230321090410.866766-1-iwona.winiarska@intel.com>
Dear Iwona,
Am 21.03.23 um 10:04 schrieb Iwona Winiarska:
> For Skylake, DTS temperature of the CPU is reported in S10.6 format
> instead of S8.8.
>
> Reported-by: Paul Fertser <fercerpav@gmail.com>
> Link: https://lore.kernel.org/lkml/ZBhHS7v+98NK56is@home.paul.comp/
> Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com>
> ---
> drivers/hwmon/peci/cputemp.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/peci/cputemp.c b/drivers/hwmon/peci/cputemp.c
> index 30850a479f61..87d56f0fc888 100644
> --- a/drivers/hwmon/peci/cputemp.c
> +++ b/drivers/hwmon/peci/cputemp.c
> @@ -537,6 +537,12 @@ static const struct cpu_info cpu_hsx = {
> .thermal_margin_to_millidegree = &dts_eight_dot_eight_to_millidegree,
> };
>
> +static const struct cpu_info cpu_skx = {
> + .reg = &resolved_cores_reg_hsx,
This is not aligned. Why not only use one space before the equal sign?
> + .min_peci_revision = 0x33,
> + .thermal_margin_to_millidegree = &dts_ten_dot_six_to_millidegree,
> +};
> +
> static const struct cpu_info cpu_icx = {
> .reg = &resolved_cores_reg_icx,
> .min_peci_revision = 0x40,
> @@ -558,7 +564,7 @@ static const struct auxiliary_device_id peci_cputemp_ids[] = {
> },
> {
> .name = "peci_cpu.cputemp.skx",
> - .driver_data = (kernel_ulong_t)&cpu_hsx,
> + .driver_data = (kernel_ulong_t)&cpu_skx,
> },
> {
> .name = "peci_cpu.cputemp.icx",
Kind regards,
Paul
next prev parent reply other threads:[~2023-03-21 9:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 9:04 [PATCH] hwmon: (peci/cputemp) Fix miscalculated DTS for SKX Iwona Winiarska
2023-03-21 9:41 ` Paul Menzel [this message]
2023-03-21 10:29 ` Winiarska, Iwona
2023-03-21 13:08 ` andriy.shevchenko
2023-03-21 14:35 ` Guenter Roeck
2023-03-21 14:42 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2fe16cf-3838-df89-958f-c39d1bae81a1@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=fercerpav@gmail.com \
--cc=iwona.winiarska@intel.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).