From: Guenter Roeck <linux@roeck-us.net>
To: "andriy.shevchenko@linux.intel.com" <andriy.shevchenko@linux.intel.com>
Cc: "Winiarska, Iwona" <iwona.winiarska@intel.com>,
"pmenzel@molgen.mpg.de" <pmenzel@molgen.mpg.de>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"fercerpav@gmail.com" <fercerpav@gmail.com>
Subject: Re: [PATCH] hwmon: (peci/cputemp) Fix miscalculated DTS for SKX
Date: Tue, 21 Mar 2023 07:35:34 -0700 [thread overview]
Message-ID: <b23c180b-667e-4689-a7da-2f8b8902c8cc@roeck-us.net> (raw)
In-Reply-To: <ZBmsXYV6jkLiFmJz@smile.fi.intel.com>
On Tue, Mar 21, 2023 at 03:08:45PM +0200, andriy.shevchenko@linux.intel.com wrote:
> On Tue, Mar 21, 2023 at 10:29:22AM +0000, Winiarska, Iwona wrote:
> > On Tue, 2023-03-21 at 10:41 +0100, Paul Menzel wrote:
> > > Am 21.03.23 um 10:04 schrieb Iwona Winiarska:
>
> ...
>
> > > This is not aligned. Why not only use one space before the equal sign?
> >
> > Yeah - same alignment problem is present in cpu_hsx and cpu_icx though, so I
> > just followed along for skx to not stand out visually.
> > So while I agree that alignment is broken here, I think it might be better to
> > separate out the potential cleanup from the fix.
>
> I agree with Iwona. If community wants a cleanup, it can be created in
> a separate patch. For the fixes it's better to reduce the unrelated churn.
>
I don't want a cleanup. The original author chose the alignment,
I accepted it because I give submitters some slack when it comes to
formatting as long as checkpatch doesn't complain, and I do not want
to get into lets-change-alignment wars.
Thanks,
Guenter
next prev parent reply other threads:[~2023-03-21 14:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 9:04 [PATCH] hwmon: (peci/cputemp) Fix miscalculated DTS for SKX Iwona Winiarska
2023-03-21 9:41 ` Paul Menzel
2023-03-21 10:29 ` Winiarska, Iwona
2023-03-21 13:08 ` andriy.shevchenko
2023-03-21 14:35 ` Guenter Roeck [this message]
2023-03-21 14:42 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b23c180b-667e-4689-a7da-2f8b8902c8cc@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=fercerpav@gmail.com \
--cc=iwona.winiarska@intel.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).