From: John Hubbard <jhubbard@nvidia.com>
To: Mark Brown <broonie@kernel.org>, David Hildenbrand <david@redhat.com>
Cc: Suren Baghdasaryan <surenb@google.com>,
akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com,
lokeshgidra@google.com, peterx@redhat.com, ryan.roberts@arm.com,
hughd@google.com, mhocko@suse.com, axelrasmussen@google.com,
rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com,
jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com,
kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kernel-team@android.com, Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v6 5/5] selftests/mm: add UFFDIO_MOVE ioctl test
Date: Mon, 11 Dec 2023 12:11:23 -0800 [thread overview]
Message-ID: <f3081d52-8bbc-4bc7-96d4-b086ca91975a@nvidia.com> (raw)
In-Reply-To: <400c0342-bb28-4dd2-b132-9927c7babec4@sirena.org.uk>
On 12/11/23 12:01, Mark Brown wrote:
> On Mon, Dec 11, 2023 at 07:00:32PM +0100, David Hildenbrand wrote:
>> On 11.12.23 18:32, Mark Brown wrote:
>>> On Mon, Dec 11, 2023 at 05:53:59PM +0100, David Hildenbrand wrote:
>
>>>> https://lkml.kernel.org/r/20231209020144.244759-1-jhubbard@nvidia.com
>
>>> I mean, I guess people who don't want to install the headers are just
>>> not going to be able to build a bunch of tests? There definitely are a
>>> bunch of tests where it's not needed so I can see why people would not
>>> like being forced to do the headers step if they're only interested in
>>> those tests.
>
>> Yes. And before that, people mostly had no clue that headers had to be
>> installed in order to compile successfully.
>
>> So maybe a warning to give at least some hint might be reasonable.
>
> That sounds sensible, especially if we could arrange to flag when the
> specific tests being built need it.
But the end result is messy: not everything builds in some cases. If
instead we went back to the little ifdef snippets, such as this (from
v5.1):
hugepage-shm.c:
#ifndef SHM_HUGETLB
#define SHM_HUGETLB 04000
#endif
...then with a bit of one-time, manual effort, we could get everything
to work at all times. And that seems better, doesn't it?
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2023-12-11 20:11 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 10:36 [PATCH v6 0/5] userfaultfd move option Suren Baghdasaryan
2023-12-06 10:36 ` [PATCH v6 1/5] mm/rmap: support move to different root anon_vma in folio_move_anon_rmap() Suren Baghdasaryan
2023-12-06 10:36 ` [PATCH v6 2/5] userfaultfd: UFFDIO_MOVE uABI Suren Baghdasaryan
2023-12-06 10:36 ` [PATCH v6 3/5] selftests/mm: call uffd_test_ctx_clear at the end of the test Suren Baghdasaryan
2023-12-06 10:36 ` [PATCH v6 4/5] selftests/mm: add uffd_test_case_ops to allow test case-specific operations Suren Baghdasaryan
2023-12-06 10:36 ` [PATCH v6 5/5] selftests/mm: add UFFDIO_MOVE ioctl test Suren Baghdasaryan
2023-12-10 14:23 ` Mark Brown
2023-12-11 1:01 ` Suren Baghdasaryan
2023-12-11 3:04 ` Suren Baghdasaryan
2023-12-11 11:15 ` Mark Brown
2023-12-11 12:03 ` David Hildenbrand
2023-12-11 12:24 ` Mark Brown
2023-12-11 16:15 ` Suren Baghdasaryan
2023-12-11 16:25 ` Mark Brown
2023-12-11 16:29 ` Suren Baghdasaryan
2023-12-11 16:34 ` Mark Brown
2023-12-11 16:43 ` Suren Baghdasaryan
2023-12-11 16:32 ` David Hildenbrand
2023-12-11 16:41 ` Mark Brown
2023-12-11 16:53 ` David Hildenbrand
2023-12-11 17:32 ` Mark Brown
2023-12-11 18:00 ` David Hildenbrand
2023-12-11 20:01 ` Mark Brown
2023-12-11 20:11 ` John Hubbard [this message]
2023-12-12 15:27 ` David Hildenbrand
2023-12-12 19:39 ` Mark Brown
2023-12-11 18:46 ` John Hubbard
2023-12-11 20:21 ` Mark Brown
2023-12-11 20:29 ` John Hubbard
2023-12-12 15:12 ` Mark Brown
2023-12-13 2:14 ` John Hubbard
2023-12-13 3:58 ` Muhammad Usama Anjum
2023-12-13 5:52 ` John Hubbard
2023-12-13 5:55 ` John Hubbard
2023-12-13 9:59 ` David Hildenbrand
2023-12-13 22:01 ` John Hubbard
2023-12-14 9:02 ` David Hildenbrand
2023-12-13 14:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3081d52-8bbc-4bc7-96d4-b086ca91975a@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=Liam.Howlett@oracle.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=bgeffon@google.com \
--cc=brauner@kernel.org \
--cc=broonie@kernel.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jannh@google.com \
--cc=jdduke@google.com \
--cc=kaleshsingh@google.com \
--cc=kernel-team@android.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lokeshgidra@google.com \
--cc=mhocko@suse.com \
--cc=ngeoffray@google.com \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=zhangpeng362@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).