linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: David Hildenbrand <david@redhat.com>
Cc: Suren Baghdasaryan <surenb@google.com>,
	akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
	brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com,
	lokeshgidra@google.com, peterx@redhat.com, ryan.roberts@arm.com,
	hughd@google.com, mhocko@suse.com, axelrasmussen@google.com,
	rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com,
	jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com,
	kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com,
	linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	kernel-team@android.com, John Hubbard <jhubbard@nvidia.com>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v6 5/5] selftests/mm: add UFFDIO_MOVE ioctl test
Date: Mon, 11 Dec 2023 16:41:35 +0000	[thread overview]
Message-ID: <1368c558-c58c-4574-907e-36b07dee31bb@sirena.org.uk> (raw)
In-Reply-To: <3240f4b5-081b-4075-851a-7d1cd86f4333@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1720 bytes --]

On Mon, Dec 11, 2023 at 05:32:16PM +0100, David Hildenbrand wrote:
> On 11.12.23 17:15, Suren Baghdasaryan wrote:

> > Ok, I was updating my headers and that's why I could not reproduce it.
> > David, should the test be modified to handle old linux headers
> > (disable the new tests #ifndef _UFFDIO_MOVE or some other way)?

> That's an open question: do we want to be able to build selftests against
> any host headers, and not the in-tree headers that have to be manually
> installed and dirty the git tree?

Quite a lot of existing selftests rely on the headers being installed to
build...

> One obvious drawbacks is that we'll have to deal with all that using a bunch
> of #ifdef, and the tests that will be built+run will depend on the host
> headers.

> Especially the letter is relevant I think: Our upstream testing won't be
> able to build+run tests that rely on new upstream features. But that's what
> some key benefit of these selftests, and being able to run them
> automatically on a bunch of different combinations upstream.

...for exactly this reason.  It causes real pain testing new interfaces.

> Further, the tests are closely related to the given kernel version, they are
> not some completely separate tests.

Note that there's a general desire for the tests to *run* with older
kernels and use whatever feature test mechanisms exist to skip tests
that won't run.  That's often needed anyway for configurable things.

> (3) avoids dirtying the tree as a "make headers_install" would, but it also
> means that each test that makes use of new uapi has to update the relevant
> headers (what people working on QEMU are used to).

Note that you can do an out of tree build to avoid dirtying things.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2023-12-11 16:41 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-06 10:36 [PATCH v6 0/5] userfaultfd move option Suren Baghdasaryan
2023-12-06 10:36 ` [PATCH v6 1/5] mm/rmap: support move to different root anon_vma in folio_move_anon_rmap() Suren Baghdasaryan
2023-12-06 10:36 ` [PATCH v6 2/5] userfaultfd: UFFDIO_MOVE uABI Suren Baghdasaryan
2023-12-06 10:36 ` [PATCH v6 3/5] selftests/mm: call uffd_test_ctx_clear at the end of the test Suren Baghdasaryan
2023-12-06 10:36 ` [PATCH v6 4/5] selftests/mm: add uffd_test_case_ops to allow test case-specific operations Suren Baghdasaryan
2023-12-06 10:36 ` [PATCH v6 5/5] selftests/mm: add UFFDIO_MOVE ioctl test Suren Baghdasaryan
2023-12-10 14:23   ` Mark Brown
2023-12-11  1:01     ` Suren Baghdasaryan
2023-12-11  3:04       ` Suren Baghdasaryan
2023-12-11 11:15         ` Mark Brown
2023-12-11 12:03           ` David Hildenbrand
2023-12-11 12:24             ` Mark Brown
2023-12-11 16:15               ` Suren Baghdasaryan
2023-12-11 16:25                 ` Mark Brown
2023-12-11 16:29                   ` Suren Baghdasaryan
2023-12-11 16:34                     ` Mark Brown
2023-12-11 16:43                       ` Suren Baghdasaryan
2023-12-11 16:32                 ` David Hildenbrand
2023-12-11 16:41                   ` Mark Brown [this message]
2023-12-11 16:53                     ` David Hildenbrand
2023-12-11 17:32                       ` Mark Brown
2023-12-11 18:00                         ` David Hildenbrand
2023-12-11 20:01                           ` Mark Brown
2023-12-11 20:11                             ` John Hubbard
2023-12-12 15:27                               ` David Hildenbrand
2023-12-12 19:39                                 ` Mark Brown
2023-12-11 18:46                   ` John Hubbard
2023-12-11 20:21                     ` Mark Brown
2023-12-11 20:29                       ` John Hubbard
2023-12-12 15:12                         ` Mark Brown
2023-12-13  2:14                           ` John Hubbard
2023-12-13  3:58                             ` Muhammad Usama Anjum
2023-12-13  5:52                               ` John Hubbard
2023-12-13  5:55                                 ` John Hubbard
2023-12-13  9:59                                   ` David Hildenbrand
2023-12-13 22:01                                     ` John Hubbard
2023-12-14  9:02                                       ` David Hildenbrand
2023-12-13 14:00                               ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1368c558-c58c-4574-907e-36b07dee31bb@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=axelrasmussen@google.com \
    --cc=bgeffon@google.com \
    --cc=brauner@kernel.org \
    --cc=david@redhat.com \
    --cc=hughd@google.com \
    --cc=jannh@google.com \
    --cc=jdduke@google.com \
    --cc=jhubbard@nvidia.com \
    --cc=kaleshsingh@google.com \
    --cc=kernel-team@android.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lokeshgidra@google.com \
    --cc=mhocko@suse.com \
    --cc=ngeoffray@google.com \
    --cc=peterx@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rppt@kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    --cc=zhangpeng362@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).