From: Raju P L S S S N <rplsssn@codeaurora.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: andy.gross@linaro.org, david.brown@linaro.org, rjw@rjwysocki.net,
ulf.hansson@linaro.org, khilman@kernel.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
rnayak@codeaurora.org, bjorn.andersson@linaro.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, sboyd@kernel.org,
evgreen@chromium.org, dianders@chromium.org, mka@chromium.org,
ilina@codeaurora.org
Subject: Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain
Date: Fri, 12 Oct 2018 23:40:05 +0530 [thread overview]
Message-ID: <f3452af3-a180-8700-43c7-b20dbaa2549e@codeaurora.org> (raw)
In-Reply-To: <20181012142503.GF3401@e107155-lin>
On 10/12/2018 7:55 PM, Sudeep Holla wrote:
> On Thu, Oct 11, 2018 at 02:50:54AM +0530, Raju P.L.S.S.S.N wrote:
>> Use cpu hotplug callback mechanism to attach/dettach the cpu in
>> the cpu power domain. During cpu hotplug callback registration,
>> the starting callback is invoked on all online cpus. So there is
>> no need to attach from device probe.
>>
>> Signed-off-by: Raju P.L.S.S.S.N <rplsssn@codeaurora.org>
>> ---
>> drivers/soc/qcom/cpu_pd.c | 33 +++++++++++++++++++++++++--------
>> include/linux/cpuhotplug.h | 1 +
>> 2 files changed, 26 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/soc/qcom/cpu_pd.c b/drivers/soc/qcom/cpu_pd.c
>> index 242eced..bf2d95d 100644
>> --- a/drivers/soc/qcom/cpu_pd.c
>> +++ b/drivers/soc/qcom/cpu_pd.c
>> @@ -3,6 +3,7 @@
>> * Copyright (c) 2018, The Linux Foundation. All rights reserved.
>> */
>>
>> +#include <linux/cpuhotplug.h>
>> #include <linux/ktime.h>
>> #include <linux/of_platform.h>
>> #include <linux/pm_domain.h>
>> @@ -85,12 +86,26 @@ static int cpu_pd_power_off(struct generic_pm_domain *domain)
>> return 0;
>> }
>>
>> +static int cpu_pd_starting(unsigned int cpu)
>> +{
>> + if (!suspend && of_genpd_attach_cpu(cpu))
>> + pr_err("%s: genpd_attach_cpu fail\n", __func__);
>
> If it's that serious, return proper error code and drop the message which
> could be annoying if you are running some hotplug test loop.
Sure will do that.
Thanks Sudeep.
- Raju
>
> --
> Regards,
> Sudeep
>
next prev parent reply other threads:[~2018-10-12 18:10 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 21:20 [PATCH RFC v1 0/8] drivers: qcom: Add cpu power domain for SDM845 Raju P.L.S.S.S.N
2018-10-10 21:20 ` [PATCH RFC v1 1/8] PM / Domains: Add helper functions to attach/detach CPUs to/from genpd Raju P.L.S.S.S.N
2018-10-10 21:20 ` [PATCH RFC v1 2/8] kernel/cpu_pm: Manage runtime PM in the idle path for CPUs Raju P.L.S.S.S.N
2018-10-11 20:52 ` Rafael J. Wysocki
2018-10-11 22:08 ` Lina Iyer
2018-10-12 7:43 ` Rafael J. Wysocki
2018-10-12 10:20 ` Ulf Hansson
2018-10-12 15:20 ` Lina Iyer
2018-10-10 21:20 ` [PATCH RFC v1 3/8] timer: Export next wakeup time of a CPU Raju P.L.S.S.S.N
2018-10-29 22:36 ` Thomas Gleixner
2018-10-30 10:29 ` Ulf Hansson
2018-10-10 21:20 ` [PATCH RFC v1 4/8] drivers: qcom: cpu_pd: add cpu power domain support using genpd Raju P.L.S.S.S.N
2018-10-11 11:13 ` Sudeep Holla
2018-10-11 15:27 ` Ulf Hansson
2018-10-11 15:59 ` Sudeep Holla
2018-10-12 9:23 ` Ulf Hansson
2018-10-12 14:33 ` Sudeep Holla
2018-10-12 18:01 ` Raju P L S S S N
2018-10-10 21:20 ` [PATCH RFC v1 5/8] dt-bindings: introduce cpu power domain bindings for Qualcomm SoCs Raju P.L.S.S.S.N
2018-10-11 11:08 ` Sudeep Holla
2018-10-12 18:08 ` Raju P L S S S N
2018-10-10 21:20 ` [PATCH RFC v1 6/8] drivers: qcom: cpu_pd: program next wakeup to PDC timer Raju P.L.S.S.S.N
2018-10-10 21:20 ` [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain Raju P.L.S.S.S.N
2018-10-11 11:20 ` Sudeep Holla
2018-10-11 16:00 ` Lina Iyer
2018-10-11 16:19 ` Sudeep Holla
2018-10-11 16:58 ` Lina Iyer
2018-10-11 17:37 ` Sudeep Holla
2018-10-11 21:06 ` Lina Iyer
2018-10-12 15:04 ` Sudeep Holla
2018-10-12 15:46 ` Ulf Hansson
2018-10-12 16:16 ` Lina Iyer
2018-10-12 16:33 ` Sudeep Holla
2018-10-12 16:04 ` Lina Iyer
2018-10-12 17:00 ` Sudeep Holla
2018-10-12 17:19 ` Lina Iyer
2018-10-12 17:25 ` Sudeep Holla
2018-10-22 19:50 ` Lina Iyer
2018-10-12 14:25 ` Sudeep Holla
2018-10-12 18:10 ` Raju P L S S S N [this message]
2018-10-10 21:20 ` [PATCH RFC v1 8/8] arm64: dtsi: sdm845: Add cpu power domain support Raju P.L.S.S.S.N
2018-10-12 17:35 ` Sudeep Holla
2018-10-12 17:52 ` Lina Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3452af3-a180-8700-43c7-b20dbaa2549e@codeaurora.org \
--to=rplsssn@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=khilman@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).