* [PATCH] virtio-mem: drop unnecessary initialization
@ 2020-06-08 5:45 Michael S. Tsirkin
2020-06-08 5:59 ` Jason Wang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2020-06-08 5:45 UTC (permalink / raw)
To: linux-kernel
Cc: kernel test robot, David Hildenbrand, Jason Wang, Pankaj Gupta,
virtualization
rc is initialized to -ENIVAL but that's never used. Drop it.
Fixes: 5f1f79bbc9e2 ("virtio-mem: Paravirtualized memory hotplug")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
drivers/virtio/virtio_mem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
index f658fe9149be..2f357142ea5e 100644
--- a/drivers/virtio/virtio_mem.c
+++ b/drivers/virtio/virtio_mem.c
@@ -1768,7 +1768,7 @@ static void virtio_mem_delete_resource(struct virtio_mem *vm)
static int virtio_mem_probe(struct virtio_device *vdev)
{
struct virtio_mem *vm;
- int rc = -EINVAL;
+ int rc;
BUILD_BUG_ON(sizeof(struct virtio_mem_req) != 24);
BUILD_BUG_ON(sizeof(struct virtio_mem_resp) != 10);
--
MST
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] virtio-mem: drop unnecessary initialization
2020-06-08 5:45 [PATCH] virtio-mem: drop unnecessary initialization Michael S. Tsirkin
@ 2020-06-08 5:59 ` Jason Wang
2020-06-08 6:44 ` David Hildenbrand
2020-06-09 4:52 ` Pankaj Gupta
2 siblings, 0 replies; 4+ messages in thread
From: Jason Wang @ 2020-06-08 5:59 UTC (permalink / raw)
To: Michael S. Tsirkin, linux-kernel
Cc: kernel test robot, David Hildenbrand, Pankaj Gupta, virtualization
On 2020/6/8 下午1:45, Michael S. Tsirkin wrote:
> rc is initialized to -ENIVAL but that's never used. Drop it.
>
> Fixes: 5f1f79bbc9e2 ("virtio-mem: Paravirtualized memory hotplug")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/virtio/virtio_mem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
> index f658fe9149be..2f357142ea5e 100644
> --- a/drivers/virtio/virtio_mem.c
> +++ b/drivers/virtio/virtio_mem.c
> @@ -1768,7 +1768,7 @@ static void virtio_mem_delete_resource(struct virtio_mem *vm)
> static int virtio_mem_probe(struct virtio_device *vdev)
> {
> struct virtio_mem *vm;
> - int rc = -EINVAL;
> + int rc;
>
> BUILD_BUG_ON(sizeof(struct virtio_mem_req) != 24);
> BUILD_BUG_ON(sizeof(struct virtio_mem_resp) != 10);
Acked-by: Jason Wang <jasowang@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] virtio-mem: drop unnecessary initialization
2020-06-08 5:45 [PATCH] virtio-mem: drop unnecessary initialization Michael S. Tsirkin
2020-06-08 5:59 ` Jason Wang
@ 2020-06-08 6:44 ` David Hildenbrand
2020-06-09 4:52 ` Pankaj Gupta
2 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2020-06-08 6:44 UTC (permalink / raw)
To: Michael S. Tsirkin, linux-kernel
Cc: kernel test robot, Jason Wang, Pankaj Gupta, virtualization
On 08.06.20 07:45, Michael S. Tsirkin wrote:
> rc is initialized to -ENIVAL but that's never used. Drop it.
>
> Fixes: 5f1f79bbc9e2 ("virtio-mem: Paravirtualized memory hotplug")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/virtio/virtio_mem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
> index f658fe9149be..2f357142ea5e 100644
> --- a/drivers/virtio/virtio_mem.c
> +++ b/drivers/virtio/virtio_mem.c
> @@ -1768,7 +1768,7 @@ static void virtio_mem_delete_resource(struct virtio_mem *vm)
> static int virtio_mem_probe(struct virtio_device *vdev)
> {
> struct virtio_mem *vm;
> - int rc = -EINVAL;
> + int rc;
>
> BUILD_BUG_ON(sizeof(struct virtio_mem_req) != 24);
> BUILD_BUG_ON(sizeof(struct virtio_mem_resp) != 10);
>
Acked-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] virtio-mem: drop unnecessary initialization
2020-06-08 5:45 [PATCH] virtio-mem: drop unnecessary initialization Michael S. Tsirkin
2020-06-08 5:59 ` Jason Wang
2020-06-08 6:44 ` David Hildenbrand
@ 2020-06-09 4:52 ` Pankaj Gupta
2 siblings, 0 replies; 4+ messages in thread
From: Pankaj Gupta @ 2020-06-09 4:52 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: LKML, kernel test robot, David Hildenbrand, Jason Wang, virtualization
> rc is initialized to -ENIVAL but that's never used. Drop it.
>
> Fixes: 5f1f79bbc9e2 ("virtio-mem: Paravirtualized memory hotplug")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/virtio/virtio_mem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
> index f658fe9149be..2f357142ea5e 100644
> --- a/drivers/virtio/virtio_mem.c
> +++ b/drivers/virtio/virtio_mem.c
> @@ -1768,7 +1768,7 @@ static void virtio_mem_delete_resource(struct virtio_mem *vm)
> static int virtio_mem_probe(struct virtio_device *vdev)
> {
> struct virtio_mem *vm;
> - int rc = -EINVAL;
> + int rc;
>
> BUILD_BUG_ON(sizeof(struct virtio_mem_req) != 24);
> BUILD_BUG_ON(sizeof(struct virtio_mem_resp) != 10);
Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-09 4:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-08 5:45 [PATCH] virtio-mem: drop unnecessary initialization Michael S. Tsirkin
2020-06-08 5:59 ` Jason Wang
2020-06-08 6:44 ` David Hildenbrand
2020-06-09 4:52 ` Pankaj Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).