* [PATCH net] net: stmmac: selftests: Flow Control test can also run with ASYM Pause
@ 2019-09-19 10:09 Jose Abreu
2019-09-22 21:56 ` Jakub Kicinski
0 siblings, 1 reply; 5+ messages in thread
From: Jose Abreu @ 2019-09-19 10:09 UTC (permalink / raw)
To: netdev
Cc: Joao Pinto, Jose Abreu, Giuseppe Cavallaro, Alexandre Torgue,
David S. Miller, Maxime Coquelin, linux-stm32, linux-arm-kernel,
linux-kernel
The Flow Control selftest is also available with ASYM Pause. Lets add
this check to the test and fix eventual false positive failures.
Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support")
Signed-off-by: Jose Abreu <joabreu@synopsys.com>
---
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Jose Abreu <joabreu@synopsys.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: netdev@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c
index c56e89e1ae56..4b4b03245f6e 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c
@@ -670,7 +670,7 @@ static int stmmac_test_flowctrl(struct stmmac_priv *priv)
unsigned int pkt_count;
int i, ret = 0;
- if (!phydev || !phydev->pause)
+ if (!phydev || (!phydev->pause && !phydev->asym_pause))
return -EOPNOTSUPP;
tpriv = kzalloc(sizeof(*tpriv), GFP_KERNEL);
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net] net: stmmac: selftests: Flow Control test can also run with ASYM Pause
2019-09-19 10:09 [PATCH net] net: stmmac: selftests: Flow Control test can also run with ASYM Pause Jose Abreu
@ 2019-09-22 21:56 ` Jakub Kicinski
2019-09-23 7:32 ` Jose Abreu
0 siblings, 1 reply; 5+ messages in thread
From: Jakub Kicinski @ 2019-09-22 21:56 UTC (permalink / raw)
To: Jose Abreu
Cc: netdev, Joao Pinto, Giuseppe Cavallaro, Alexandre Torgue,
David S. Miller, Maxime Coquelin, linux-stm32, linux-arm-kernel,
linux-kernel
On Thu, 19 Sep 2019 12:09:49 +0200, Jose Abreu wrote:
> The Flow Control selftest is also available with ASYM Pause. Lets add
> this check to the test and fix eventual false positive failures.
>
> Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support")
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
Hi Jose!
Thanks for the patch it looks good, seems like you posted it from
a slightly different email address than was used for signoff:
From: Jose Abreu <Jose.Abreu@synopsys.com>
vs
Signed-off-by: Jose Abreu <joabreu@synopsys.com>
Could you please fix and repost? Automation may get upset otherwise.
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH net] net: stmmac: selftests: Flow Control test can also run with ASYM Pause
2019-09-22 21:56 ` Jakub Kicinski
@ 2019-09-23 7:32 ` Jose Abreu
0 siblings, 0 replies; 5+ messages in thread
From: Jose Abreu @ 2019-09-23 7:32 UTC (permalink / raw)
To: Jakub Kicinski, Jose Abreu
Cc: netdev, Joao Pinto, Giuseppe Cavallaro, Alexandre Torgue,
David S. Miller, Maxime Coquelin, linux-stm32, linux-arm-kernel,
linux-kernel
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Sep/22/2019, 22:56:42 (UTC+00:00)
> On Thu, 19 Sep 2019 12:09:49 +0200, Jose Abreu wrote:
> > The Flow Control selftest is also available with ASYM Pause. Lets add
> > this check to the test and fix eventual false positive failures.
> >
> > Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support")
> > Signed-off-by: Jose Abreu <joabreu@synopsys.com>
>
> Hi Jose!
>
> Thanks for the patch it looks good, seems like you posted it from
> a slightly different email address than was used for signoff:
>
> From: Jose Abreu <Jose.Abreu@synopsys.com>
> vs
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
>
> Could you please fix and repost? Automation may get upset otherwise.
Yeah that's my external vs. internal email messing around. Any of them
works though. I resent it using the external one. Can you please take a
look ?
---
Thanks,
Jose Miguel Abreu
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH net] net: stmmac: selftests: Flow Control test can also run with ASYM Pause
2019-09-23 7:30 Jose Abreu
@ 2019-09-23 7:47 ` Jose Abreu
0 siblings, 0 replies; 5+ messages in thread
From: Jose Abreu @ 2019-09-23 7:47 UTC (permalink / raw)
To: Jose Abreu, netdev
Cc: Joao Pinto, Giuseppe Cavallaro, Alexandre Torgue,
David S. Miller, Maxime Coquelin, linux-stm32, linux-arm-kernel,
linux-kernel
From: Jose Abreu <Jose.Abreu@synopsys.com>
Date: Sep/23/2019, 08:30:43 (UTC+00:00)
> From: Jose Abreu <joabreu@synopsys.com>
>
> The Flow Control selftest is also available with ASYM Pause. Lets add
> this check to the test and fix eventual false positive failures.
>
> Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support")
> Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com>
Oops, "From:" and "Signed-off-by:" are still different. I'll amend this
and re-submit. Please disregard this one.
---
Thanks,
Jose Miguel Abreu
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH net] net: stmmac: selftests: Flow Control test can also run with ASYM Pause
@ 2019-09-23 7:30 Jose Abreu
2019-09-23 7:47 ` Jose Abreu
0 siblings, 1 reply; 5+ messages in thread
From: Jose Abreu @ 2019-09-23 7:30 UTC (permalink / raw)
To: netdev
Cc: Joao Pinto, Jose Abreu, Jose Abreu, Giuseppe Cavallaro,
Alexandre Torgue, David S. Miller, Maxime Coquelin, linux-stm32,
linux-arm-kernel, linux-kernel
From: Jose Abreu <joabreu@synopsys.com>
The Flow Control selftest is also available with ASYM Pause. Lets add
this check to the test and fix eventual false positive failures.
Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support")
Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com>
---
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Jose Abreu <joabreu@synopsys.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: netdev@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c
index 9c8d210b2d6a..5f66f6161629 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c
@@ -670,7 +670,7 @@ static int stmmac_test_flowctrl(struct stmmac_priv *priv)
unsigned int pkt_count;
int i, ret = 0;
- if (!phydev || !phydev->pause)
+ if (!phydev || (!phydev->pause && !phydev->asym_pause))
return -EOPNOTSUPP;
tpriv = kzalloc(sizeof(*tpriv), GFP_KERNEL);
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-09-23 7:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-19 10:09 [PATCH net] net: stmmac: selftests: Flow Control test can also run with ASYM Pause Jose Abreu
2019-09-22 21:56 ` Jakub Kicinski
2019-09-23 7:32 ` Jose Abreu
2019-09-23 7:30 Jose Abreu
2019-09-23 7:47 ` Jose Abreu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).