LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Sibi Sankar <sibis@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Steev Klimaszewski <steev@kali.org>,
	viresh.kumar@linaro.org, sboyd@kernel.org,
	georgi.djakov@linaro.org, agross@kernel.org, robh+dt@kernel.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, saravanak@google.com,
	dianders@chromium.org, vincent.guittot@linaro.org,
	amit.kucheria@linaro.org, robdclark@chromium.org,
	linux-kernel-owner@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: sdm845: Add cpu OPP tables
Date: Thu, 09 Jul 2020 20:13:49 +0530
Message-ID: <f36df61af67245c5fe9ca4e7550b8861@codeaurora.org> (raw)
In-Reply-To: <20200709142918.GA3521288@ripper>

On 2020-07-09 19:59, Bjorn Andersson wrote:
> On Wed 08 Jul 19:22 PDT 2020, Steev Klimaszewski wrote:
> 
>> 
>> On 7/2/20 3:46 PM, Sibi Sankar wrote:
>> > Add OPP tables required to scale DDR/L3 per freq-domain on SDM845 SoCs.
>> >
>> > Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> > ---
>> 
>> 
>> Hi Sibi,
>> 
>> 
>> Bjorn asked me to give this patch a whirl, and I have to say, I like 
>> it
>> but I'm not sure if I'm missing a dependency somewhere...
>> 
>> 
>> In 5.8.0-rc4, I'm seeing a couple probe defers
>> 
>> [    0.131341] cpu cpu0: _allocate_opp_table: Error finding 
>> interconnect
>> paths: -517
>> 
>> [    0.132694] cpu cpu4: _allocate_opp_table: Error finding 
>> interconnect
>> paths: -517
>> 
>> And then a bit later on,
>> 
>> [    0.625837] cpu cpu0: failed to get clock: -2
>> 
>> 
>> If these aren't anything to worry about, you can throw my Tested-by on
>> 
>> Tested-by: Steev Klimaszewski <steev@kali.org>
>> 
> 
> You need to enable:
> CONFIG_INTERCONNECT=y
> CONFIG_INTERCONNECT_QCOM=y
> CONFIG_INTERCONNECT_QCOM_OSM_L3=m
> CONFIG_INTERCONNECT_QCOM_SDM845=m

Steev had ^^ enabled but he was missing
the required cpufreq driver changes
available in linux-next.

> 
> With this I can see the interconnect_summary in debugfs change with the
> CPU frequency.
> 
> Regards,
> Bjorn

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.

  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02 20:46 Sibi Sankar
2020-07-09  2:22 ` Steev Klimaszewski
2020-07-09 14:29   ` Bjorn Andersson
2020-07-09 14:43     ` Sibi Sankar [this message]
2020-07-09 14:45 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f36df61af67245c5fe9ca4e7550b8861@codeaurora.org \
    --to=sibis@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=amit.kucheria@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=georgi.djakov@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel-owner@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@chromium.org \
    --cc=robh+dt@kernel.org \
    --cc=saravanak@google.com \
    --cc=sboyd@kernel.org \
    --cc=steev@kali.org \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git