linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers/thermal/mediatek/lvts_thermal: Remove unneeded semicolon
       [not found] <20230614084536.6911-1-luojianhong@cdjrlc.com>
@ 2023-06-14  8:48 ` baomingtong001
  2023-06-14  8:54   ` Daniel Lezcano
  2023-06-14  8:59 ` baomingtong001
  1 sibling, 1 reply; 3+ messages in thread
From: baomingtong001 @ 2023-06-14  8:48 UTC (permalink / raw)
  To: rafael, daniel.lezcano, amitk, rui.zhang, matthias.bgg,
	angelogioacchino.delregno, bchihi, heiko, wenst
  Cc: linux-pm, linux-kernel

./drivers/thermal/mediatek/lvts_thermal.c:522:2-3: Unneeded semicolon

Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
---
  drivers/thermal/mediatek/lvts_thermal.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/mediatek/lvts_thermal.c 
b/drivers/thermal/mediatek/lvts_thermal.c
index d0a3f95b7884..1a5ae51b2c51 100644
--- a/drivers/thermal/mediatek/lvts_thermal.c
+++ b/drivers/thermal/mediatek/lvts_thermal.c
@@ -519,7 +519,7 @@ static int lvts_sensor_init(struct device *dev, 
struct lvts_ctrl *lvts_ctrl,
           */
          lvts_sensor[i].msr = lvts_ctrl_data->mode == 
LVTS_MSR_IMMEDIATE_MODE ?
              imm_regs[i] : msr_regs[i];
-    };
+    }

      lvts_ctrl->num_lvts_sensor = lvts_ctrl_data->num_lvts_sensor;

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drivers/thermal/mediatek/lvts_thermal: Remove unneeded semicolon
  2023-06-14  8:48 ` [PATCH] drivers/thermal/mediatek/lvts_thermal: Remove unneeded semicolon baomingtong001
@ 2023-06-14  8:54   ` Daniel Lezcano
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel Lezcano @ 2023-06-14  8:54 UTC (permalink / raw)
  To: baomingtong001, rafael, amitk, rui.zhang, matthias.bgg,
	angelogioacchino.delregno, bchihi, heiko, wenst
  Cc: linux-pm, linux-kernel

On 14/06/2023 10:48, baomingtong001@208suo.com wrote:
> ./drivers/thermal/mediatek/lvts_thermal.c:522:2-3: Unneeded semicolon

Please elaborate a bit the changelog when submitting patches.

I did not see this warning/error when compiling. So in which 
circumstances this message appears?

> Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
> ---
>   drivers/thermal/mediatek/lvts_thermal.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/mediatek/lvts_thermal.c 
> b/drivers/thermal/mediatek/lvts_thermal.c
> index d0a3f95b7884..1a5ae51b2c51 100644
> --- a/drivers/thermal/mediatek/lvts_thermal.c
> +++ b/drivers/thermal/mediatek/lvts_thermal.c
> @@ -519,7 +519,7 @@ static int lvts_sensor_init(struct device *dev, 
> struct lvts_ctrl *lvts_ctrl,
>            */
>           lvts_sensor[i].msr = lvts_ctrl_data->mode == 
> LVTS_MSR_IMMEDIATE_MODE ?
>               imm_regs[i] : msr_regs[i];
> -    };
> +    }
> 
>       lvts_ctrl->num_lvts_sensor = lvts_ctrl_data->num_lvts_sensor;

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] drivers/thermal/mediatek/lvts_thermal: Remove unneeded semicolon
       [not found] <20230614084536.6911-1-luojianhong@cdjrlc.com>
  2023-06-14  8:48 ` [PATCH] drivers/thermal/mediatek/lvts_thermal: Remove unneeded semicolon baomingtong001
@ 2023-06-14  8:59 ` baomingtong001
  1 sibling, 0 replies; 3+ messages in thread
From: baomingtong001 @ 2023-06-14  8:59 UTC (permalink / raw)
  To: rafael, daniel.lezcano, amitk, rui.zhang, matthias.bgg,
	angelogioacchino.delregno, bchihi, heiko, wenst
  Cc: linux-pm, linux-kernel

fix the following coccicheck warning:

./drivers/thermal/mediatek/lvts_thermal.c:522:2-3: Unneeded semicolon

Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
---
  drivers/thermal/mediatek/lvts_thermal.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/mediatek/lvts_thermal.c 
b/drivers/thermal/mediatek/lvts_thermal.c
index d0a3f95b7884..1a5ae51b2c51 100644
--- a/drivers/thermal/mediatek/lvts_thermal.c
+++ b/drivers/thermal/mediatek/lvts_thermal.c
@@ -519,7 +519,7 @@ static int lvts_sensor_init(struct device *dev, 
struct lvts_ctrl *lvts_ctrl,
           */
          lvts_sensor[i].msr = lvts_ctrl_data->mode == 
LVTS_MSR_IMMEDIATE_MODE ?
              imm_regs[i] : msr_regs[i];
-    };
+    }

      lvts_ctrl->num_lvts_sensor = lvts_ctrl_data->num_lvts_sensor;

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-06-14  8:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20230614084536.6911-1-luojianhong@cdjrlc.com>
2023-06-14  8:48 ` [PATCH] drivers/thermal/mediatek/lvts_thermal: Remove unneeded semicolon baomingtong001
2023-06-14  8:54   ` Daniel Lezcano
2023-06-14  8:59 ` baomingtong001

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).