[PATCH v3 0/2] uacce: fix some coding styles

[PATCH v3 0/2] uacce: fix some coding styles

[Kai Ye]

1. delete some redundant code.
2. modify the module author information. "Hisilicon"
spelling is error.

Changes v2 -> v3:
	Two things, splited to two patches.
Changes v1 -> v2:
	deleted extra NULL pointer check in uacce_fops.

Kai Ye (2):
  uacce: fix some coding styles
  uacce: modify the module author information.

 drivers/misc/uacce/uacce.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

-- 
2.8.1

[PATCH v3 1/2] uacce: delete some redundant code.

[Kai Ye]

Delete some redundant code.

Signed-off-by: Kai Ye <yekai13@huawei.com>
Reviewed-by: Zhou Wang <wangzhou1@hisilicon.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Acked-by: Zhangfei Gao <zhangfei.gao@linaro.org>
---
 drivers/misc/uacce/uacce.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c
index 107028e..9b83bc5 100644
--- a/drivers/misc/uacce/uacce.c
+++ b/drivers/misc/uacce/uacce.c
@@ -239,17 +239,6 @@ static int uacce_fops_mmap(struct file *filep, struct vm_area_struct *vma)
 
 	switch (type) {
 	case UACCE_QFRT_MMIO:
-		if (!uacce->ops->mmap) {
-			ret = -EINVAL;
-			goto out_with_lock;
-		}
-
-		ret = uacce->ops->mmap(q, vma, qfr);
-		if (ret)
-			goto out_with_lock;
-
-		break;
-
 	case UACCE_QFRT_DUS:
 		if (!uacce->ops->mmap) {
 			ret = -EINVAL;
-- 
2.8.1

[PATCH v3 2/2] uacce: modify the module author information.

[Kai Ye]

The spelling of "Hisilicon" is modified.

Signed-off-by: Kai Ye <yekai13@huawei.com>
Reviewed-by: Zhou Wang <wangzhou1@hisilicon.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Acked-by: Zhangfei Gao <zhangfei.gao@linaro.org>
---
 drivers/misc/uacce/uacce.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c
index 9b83bc5..1d09707 100644
--- a/drivers/misc/uacce/uacce.c
+++ b/drivers/misc/uacce/uacce.c
@@ -530,5 +530,5 @@ subsys_initcall(uacce_init);
 module_exit(uacce_exit);
 
 MODULE_LICENSE("GPL");
-MODULE_AUTHOR("Hisilicon Tech. Co., Ltd.");
+MODULE_AUTHOR("HiSilicon Tech. Co., Ltd.");
 MODULE_DESCRIPTION("Accelerator interface for Userland applications");
-- 
2.8.1

Re: [PATCH v3 0/2] uacce: fix some coding styles

[yekai(A)]

Hi Hartman

Could you help to take this patch?
Thanks.


On 2020/9/23 18:09, Kai Ye wrote:
> 1. delete some redundant code.
> 2. modify the module author information. "Hisilicon"
> spelling is error.
>
> Changes v2 -> v3:
> 	Two things, splited to two patches.
> Changes v1 -> v2:
> 	deleted extra NULL pointer check in uacce_fops.
>
> Kai Ye (2):
>    uacce: fix some coding styles
>    uacce: modify the module author information.
>
>   drivers/misc/uacce/uacce.c | 13 +------------
>   1 file changed, 1 insertion(+), 12 deletions(-)
>

Re: [PATCH v3 0/2] uacce: fix some coding styles

[Zhou Wang]

On 2020/9/23 18:09, Kai Ye wrote:
> 1. delete some redundant code.
> 2. modify the module author information. "Hisilicon"
> spelling is error.
> 
> Changes v2 -> v3:
> 	Two things, splited to two patches.
> Changes v1 -> v2:
> 	deleted extra NULL pointer check in uacce_fops.
> 
> Kai Ye (2):
>   uacce: fix some coding styles
>   uacce: modify the module author information.
> 
>  drivers/misc/uacce/uacce.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 

Hi Hartman，

Could you help to take this clean up patch?

Best,
Zhou

Re: [PATCH v3 0/2] uacce: fix some coding styles

[Greg Kroah-Hartman]

On Mon, Nov 02, 2020 at 02:41:12PM +0800, Zhou Wang wrote:
> On 2020/9/23 18:09, Kai Ye wrote:
> > 1. delete some redundant code.
> > 2. modify the module author information. "Hisilicon"
> > spelling is error.
> > 
> > Changes v2 -> v3:
> > 	Two things, splited to two patches.
> > Changes v1 -> v2:
> > 	deleted extra NULL pointer check in uacce_fops.
> > 
> > Kai Ye (2):
> >   uacce: fix some coding styles
> >   uacce: modify the module author information.
> > 
> >  drivers/misc/uacce/uacce.c | 13 +------------
> >  1 file changed, 1 insertion(+), 12 deletions(-)
> > 
> 
> Hi Hartman，
> 
> Could you help to take this clean up patch?

I do not see a patch here :(

If I have missed something, please resend it.

thanks,

greg k-h

Re: [PATCH v3 1/2] uacce: delete some redundant code.

[Zhou Wang]

On 2020/9/23 18:09, Kai Ye wrote:
> Delete some redundant code.
> 
> Signed-off-by: Kai Ye <yekai13@huawei.com>
> Reviewed-by: Zhou Wang <wangzhou1@hisilicon.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
> Acked-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> ---
>  drivers/misc/uacce/uacce.c | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c
> index 107028e..9b83bc5 100644
> --- a/drivers/misc/uacce/uacce.c
> +++ b/drivers/misc/uacce/uacce.c
> @@ -239,17 +239,6 @@ static int uacce_fops_mmap(struct file *filep, struct vm_area_struct *vma)
>  
>  	switch (type) {
>  	case UACCE_QFRT_MMIO:
> -		if (!uacce->ops->mmap) {
> -			ret = -EINVAL;
> -			goto out_with_lock;
> -		}
> -
> -		ret = uacce->ops->mmap(q, vma, qfr);
> -		if (ret)
> -			goto out_with_lock;
> -
> -		break;
> -
>  	case UACCE_QFRT_DUS:
>  		if (!uacce->ops->mmap) {
>  			ret = -EINVAL;
> 

Hi Hartman,

Could you take this patch?

Best,
Zhou

Re: [PATCH v3 2/2] uacce: modify the module author information.

[Zhou Wang]

On 2020/9/23 18:09, Kai Ye wrote:
> The spelling of "Hisilicon" is modified.
> 
> Signed-off-by: Kai Ye <yekai13@huawei.com>
> Reviewed-by: Zhou Wang <wangzhou1@hisilicon.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
> Acked-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> ---
>  drivers/misc/uacce/uacce.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c
> index 9b83bc5..1d09707 100644
> --- a/drivers/misc/uacce/uacce.c
> +++ b/drivers/misc/uacce/uacce.c
> @@ -530,5 +530,5 @@ subsys_initcall(uacce_init);
>  module_exit(uacce_exit);
>  
>  MODULE_LICENSE("GPL");
> -MODULE_AUTHOR("Hisilicon Tech. Co., Ltd.");
> +MODULE_AUTHOR("HiSilicon Tech. Co., Ltd.");
>  MODULE_DESCRIPTION("Accelerator interface for Userland applications");
> 

Hi Hartman,

Could you take this patch?

Best,
Zhou

Re: [PATCH v3 0/2] uacce: fix some coding styles

[Zhou Wang]

On 2020/11/2 15:09, Greg Kroah-Hartman wrote:
> On Mon, Nov 02, 2020 at 02:41:12PM +0800, Zhou Wang wrote:
>> On 2020/9/23 18:09, Kai Ye wrote:
>>> 1. delete some redundant code.
>>> 2. modify the module author information. "Hisilicon"
>>> spelling is error.
>>>
>>> Changes v2 -> v3:
>>> 	Two things, splited to two patches.
>>> Changes v1 -> v2:
>>> 	deleted extra NULL pointer check in uacce_fops.
>>>
>>> Kai Ye (2):
>>>   uacce: fix some coding styles
>>>   uacce: modify the module author information.
>>>
>>>  drivers/misc/uacce/uacce.c | 13 +------------
>>>  1 file changed, 1 insertion(+), 12 deletions(-)
>>>
>>
>> Hi Hartman，
>>
>> Could you help to take this clean up patch?
> 
> I do not see a patch here :(

I know the reason, Kai Ye did not To you and I also added your
Email address in this ping :) I have replied patches directly.

Could you take them?

Best,
Zhou

> 
> If I have missed something, please resend it.
> 
> thanks,
> 
> greg k-h
> .
> 

Re: [PATCH v3 0/2] uacce: fix some coding styles

[Greg Kroah-Hartman]

On Mon, Nov 02, 2020 at 03:38:49PM +0800, Zhou Wang wrote:
> On 2020/11/2 15:09, Greg Kroah-Hartman wrote:
> > On Mon, Nov 02, 2020 at 02:41:12PM +0800, Zhou Wang wrote:
> >> On 2020/9/23 18:09, Kai Ye wrote:
> >>> 1. delete some redundant code.
> >>> 2. modify the module author information. "Hisilicon"
> >>> spelling is error.
> >>>
> >>> Changes v2 -> v3:
> >>> 	Two things, splited to two patches.
> >>> Changes v1 -> v2:
> >>> 	deleted extra NULL pointer check in uacce_fops.
> >>>
> >>> Kai Ye (2):
> >>>   uacce: fix some coding styles
> >>>   uacce: modify the module author information.
> >>>
> >>>  drivers/misc/uacce/uacce.c | 13 +------------
> >>>  1 file changed, 1 insertion(+), 12 deletions(-)
> >>>
> >>
> >> Hi Hartman，
> >>
> >> Could you help to take this clean up patch?
> > 
> > I do not see a patch here :(
> 
> I know the reason, Kai Ye did not To you and I also added your
> Email address in this ping :) I have replied patches directly.
> 
> Could you take them?

I need them in a format that I can apply them in, please resend the
whole series properly, so that I do not have to edit them by-hand.

thanks,

greg k-h

Re: [PATCH v3 0/2] uacce: fix some coding styles

[Zhou Wang]

On 2020/11/2 16:33, Greg Kroah-Hartman wrote:
> On Mon, Nov 02, 2020 at 03:38:49PM +0800, Zhou Wang wrote:
>> On 2020/11/2 15:09, Greg Kroah-Hartman wrote:
>>> On Mon, Nov 02, 2020 at 02:41:12PM +0800, Zhou Wang wrote:
>>>> On 2020/9/23 18:09, Kai Ye wrote:
>>>>> 1. delete some redundant code.
>>>>> 2. modify the module author information. "Hisilicon"
>>>>> spelling is error.
>>>>>
>>>>> Changes v2 -> v3:
>>>>> 	Two things, splited to two patches.
>>>>> Changes v1 -> v2:
>>>>> 	deleted extra NULL pointer check in uacce_fops.
>>>>>
>>>>> Kai Ye (2):
>>>>>   uacce: fix some coding styles
>>>>>   uacce: modify the module author information.
>>>>>
>>>>>  drivers/misc/uacce/uacce.c | 13 +------------
>>>>>  1 file changed, 1 insertion(+), 12 deletions(-)
>>>>>
>>>>
>>>> Hi Hartman，
>>>>
>>>> Could you help to take this clean up patch?
>>>
>>> I do not see a patch here :(
>>
>> I know the reason, Kai Ye did not To you and I also added your
>> Email address in this ping :) I have replied patches directly.
>>
>> Could you take them?
> 
> I need them in a format that I can apply them in, please resend the
> whole series properly, so that I do not have to edit them by-hand.

Got it. Thanks!

Best,
Zhou

> 
> thanks,
> 
> greg k-h
> .
>