From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Venkata Prasad Potturu <venkataprasad.potturu@amd.com>,
Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Alper Nebi Yasak <alpernebiyasak@gmail.com>,
Syed Saba Kareem <Syed.SabaKareem@amd.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Marian Postevca <posteuca@mutex.one>,
Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
V sujith kumar Reddy <Vsujithkumar.Reddy@amd.com>,
Mastan Katragadda <Mastan.Katragadda@amd.com>,
Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
sound-open-firmware@alsa-project.org, kernel@collabora.com
Subject: Re: [PATCH 11/11] ASoC: SOF: topology: Add new DAI type entry for SOF_DAI_AMD_BT
Date: Fri, 15 Dec 2023 12:57:34 +0200 [thread overview]
Message-ID: <f3d98291-0bf6-45b2-bf4f-b0268d13af63@collabora.com> (raw)
In-Reply-To: <188ee32a-a201-4210-a8bc-bf3ba04e2f2b@amd.com>
On 12/15/23 11:58, Venkata Prasad Potturu wrote:
>
> On 12/14/23 22:12, Cristian Ciocaltea wrote:
>> On 12/14/23 15:15, Venkata Prasad Potturu wrote:
>>> On 12/14/23 17:53, Cristian Ciocaltea wrote:
>>>> On 12/11/23 07:58, Venkata Prasad Potturu wrote:
>>>>> On 12/10/23 21:20, Cristian Ciocaltea wrote:
>>>>>> On 12/10/23 16:01, Mark Brown wrote:
>>>>>>> On Sun, Dec 10, 2023 at 12:12:53PM +0200, Cristian Ciocaltea wrote:
>>>>>>>> On 12/10/23 11:51, Venkata Prasad Potturu wrote:
>>>>>>>>> This should send to SOF git repo for rewiew, once SOF reviewers
>>>>>>>>> approved
>>>>>>>>> this, again need to send to broonie git.
>>>>>>>>> All the changes in sound/soc/sof/ path should go to SOF git.
>>>>>>>> Unfortunately I'm not familiar with the SOF dev workflow. So
>>>>>>>> it's not
>>>>>>>> enough to have this patch cc-ed to
>>>>>>>> sound-open-firmware@alsa-project.org?
>>>>>>> The SOF people basically do their own thing in github at
>>>>>>>
>>>>>>> https://github.com/thesofproject/linux
>>>>>>>
>>>>>>> with a github workflow and submit their patches upstream in
>>>>>>> batches a
>>>>>>> few times a release, however my understanding is that their
>>>>>>> workflow can
>>>>>>> cope with things going in directly upstream as well.
>>>>>> Thanks for clarifying, Mark! That would greatly simplify and speedup
>>>>>> the whole process, at least for trivial patches like this one.
>>>>> Hi Cristian,
>>>>>
>>>>> We have created a Pull request in SOF git hub for I2S BT support.
>>>>> please hold v2 version SOF patches till below PR get's merged.
>>>>> PR:- https://github.com/thesofproject/linux/pull/4742
>>>> Hi Venkata,
>>>>
>>>> If this is going to be handled via the github workflow, this patch
>>>> should be removed from the series. Since there is no dependency on it,
>>>> I cannot see a reason to put v2 on hold.
>>>>
>>>> Do I miss something?
>>> Non-sof driver related patches can directly send to broonie git ad v2
>>> series.
>>> SOF driver patches should send to SOF github to avoid merge conflicts
>>> as per guidelines of SOF community.
>> Honestly, I don't really see a high risk of conflicts, the patches are
>> not that complex and can be simply cherry-picked when needed. Moreover,
>> as we already had people reviewing this, splitting this up will only add
>> confusion and unnecessary burden.
>>
>> Are there any specific changes you are concerned about and cannot be
>> really handled here?
> This is not the concern about this patch series,
> Generally sof driver patches sends to SOF git hub as a PR, these are the
> guidelines by SOF maintainers.
> If you still want to send alsa devel list directly, please discuss with
> SOF maintainers.
I think this series makes sense as a whole and it's best to be handled
here, as it only provides trivial fixes to issues found on mainline.
If the SOF workflow is unable to integrate fixes submitted upstream, I
would perceive that as a significant drawback of adhering to that
process. It is hard to believe, though, that this is really the case.
Hence, I kindly ask everyone here to shed some light and help move this
forward.
Thank you,
Cristian
next prev parent reply other threads:[~2023-12-15 10:57 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 20:53 [PATCH 00/11] Improve SOF support for Steam Deck OLED Cristian Ciocaltea
2023-12-09 20:53 ` [PATCH 01/11] ASoC: amd: acp: Drop redundant initialization of machine driver data Cristian Ciocaltea
2023-12-09 20:53 ` [PATCH 02/11] ASoC: amd: acp: Make use of existing *_CODEC_DAI macros Cristian Ciocaltea
2023-12-09 20:53 ` [PATCH 03/11] ASoC: amd: acp: Add missing error handling in sof-mach Cristian Ciocaltea
2023-12-11 13:31 ` Emil Velikov
2023-12-11 16:56 ` Cristian Ciocaltea
2023-12-09 20:53 ` [PATCH 04/11] ASoC: amd: acp: Update MODULE_DESCRIPTION for sof-mach Cristian Ciocaltea
2023-12-09 20:53 ` [PATCH 05/11] ASoC: SOF: amd: Fix memory leak in amd_sof_acp_probe() Cristian Ciocaltea
2023-12-09 20:53 ` [PATCH 06/11] ASoC: SOF: amd: Optimize quirk for Valve Galileo Cristian Ciocaltea
2023-12-10 3:33 ` Venkata Prasad Potturu
2023-12-10 8:42 ` Cristian Ciocaltea
2023-12-09 20:53 ` [PATCH 07/11] ASoC: SOF: core: Skip firmware test for undefined fw_name Cristian Ciocaltea
2023-12-14 10:48 ` Péter Ujfalusi
2023-12-14 10:58 ` Venkata Prasad Potturu
2023-12-14 11:57 ` Péter Ujfalusi
2023-12-14 13:28 ` Venkata Prasad Potturu
2023-12-14 11:29 ` Cristian Ciocaltea
2023-12-14 11:35 ` Péter Ujfalusi
2023-12-14 11:40 ` Cristian Ciocaltea
2023-12-14 11:52 ` Péter Ujfalusi
2023-12-14 11:51 ` Péter Ujfalusi
2023-12-14 11:58 ` Cristian Ciocaltea
2023-12-09 20:53 ` [PATCH 08/11] ASoC: SOF: amd: Override default fw name for Valve Galileo Cristian Ciocaltea
2023-12-09 20:53 ` [PATCH 09/11] ASoC: SOF: amd: Compute file paths on firmware load Cristian Ciocaltea
2023-12-10 3:50 ` Venkata Prasad Potturu
2023-12-10 8:56 ` Cristian Ciocaltea
2023-12-09 20:53 ` [PATCH 10/11] ASoC: amd: acp: Use correct DAI link ID for BT codec Cristian Ciocaltea
2023-12-10 3:24 ` Venkata Prasad Potturu
2023-12-10 9:06 ` Cristian Ciocaltea
2023-12-10 10:05 ` Venkata Prasad Potturu
2023-12-10 10:32 ` Cristian Ciocaltea
2023-12-11 5:48 ` Venkata Prasad Potturu
2023-12-09 20:53 ` [PATCH 11/11] ASoC: SOF: topology: Add new DAI type entry for SOF_DAI_AMD_BT Cristian Ciocaltea
2023-12-10 3:30 ` Venkata Prasad Potturu
2023-12-10 9:08 ` Cristian Ciocaltea
2023-12-10 9:51 ` Venkata Prasad Potturu
2023-12-10 10:12 ` Cristian Ciocaltea
2023-12-10 14:01 ` Mark Brown
2023-12-10 15:50 ` Cristian Ciocaltea
2023-12-11 5:58 ` Venkata Prasad Potturu
2023-12-14 12:23 ` Cristian Ciocaltea
2023-12-14 12:36 ` Venkata Prasad Potturu
2023-12-14 13:15 ` Venkata Prasad Potturu
2023-12-14 16:42 ` Cristian Ciocaltea
2023-12-15 9:58 ` Venkata Prasad Potturu
2023-12-15 10:57 ` Cristian Ciocaltea [this message]
2023-12-15 12:53 ` Mark Brown
2023-12-12 6:41 ` Mukunda,Vijendar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3d98291-0bf6-45b2-bf4f-b0268d13af63@collabora.com \
--to=cristian.ciocaltea@collabora.com \
--cc=AjitKumar.Pandey@amd.com \
--cc=Mastan.Katragadda@amd.com \
--cc=Syed.SabaKareem@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=Vsujithkumar.Reddy@amd.com \
--cc=alpernebiyasak@gmail.com \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kernel@collabora.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=posteuca@mutex.one \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=venkataprasad.potturu@amd.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).