linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Thor Thayer <thor.thayer@linux.intel.com>,
	linux-kernel@vger.kernel.org
Cc: kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] reset: a10sr: add missing of_match_table reference
Date: Mon, 10 May 2021 09:50:34 +0200	[thread overview]
Message-ID: <f42e5936139f75968520cf76c359e079b49b1dcb.camel@pengutronix.de> (raw)
In-Reply-To: <20210507112803.20012-1-krzysztof.kozlowski@canonical.com>

On Fri, 2021-05-07 at 07:28 -0400, Krzysztof Kozlowski wrote:
> The driver defined of_device_id table but did not use it with
> of_match_table.  This prevents usual matching via devicetree and causes
> a W=1 warning:
> 
>   drivers/reset/reset-a10sr.c:111:34: warning:
>     ‘a10sr_reset_of_match’ defined but not used [-Wunused-const-variable=]
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 627006820268 ("reset: Add Altera Arria10 SR Reset Controller")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  drivers/reset/reset-a10sr.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/reset/reset-a10sr.c b/drivers/reset/reset-a10sr.c
> index 7eacc89382f8..99b3bc8382f3 100644
> --- a/drivers/reset/reset-a10sr.c
> +++ b/drivers/reset/reset-a10sr.c
> @@ -118,6 +118,7 @@ static struct platform_driver a10sr_reset_driver = {
>  	.probe	= a10sr_reset_probe,
>  	.driver = {
>  		.name		= "altr_a10sr_reset",
> +		.of_match_table	= a10sr_reset_of_match,
>  	},
>  };
>  module_platform_driver(a10sr_reset_driver);

Thank you, applied to reset/next.

regards
Philipp

      reply	other threads:[~2021-05-10  7:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-07 11:28 [PATCH] reset: a10sr: add missing of_match_table reference Krzysztof Kozlowski
2021-05-10  7:50 ` Philipp Zabel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f42e5936139f75968520cf76c359e079b49b1dcb.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=thor.thayer@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).