* [PATCH] reset: a10sr: add missing of_match_table reference
@ 2021-05-07 11:28 Krzysztof Kozlowski
2021-05-10 7:50 ` Philipp Zabel
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-07 11:28 UTC (permalink / raw)
To: Thor Thayer, Philipp Zabel, linux-kernel
Cc: Krzysztof Kozlowski, kernel test robot
The driver defined of_device_id table but did not use it with
of_match_table. This prevents usual matching via devicetree and causes
a W=1 warning:
drivers/reset/reset-a10sr.c:111:34: warning:
‘a10sr_reset_of_match’ defined but not used [-Wunused-const-variable=]
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 627006820268 ("reset: Add Altera Arria10 SR Reset Controller")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
drivers/reset/reset-a10sr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/reset/reset-a10sr.c b/drivers/reset/reset-a10sr.c
index 7eacc89382f8..99b3bc8382f3 100644
--- a/drivers/reset/reset-a10sr.c
+++ b/drivers/reset/reset-a10sr.c
@@ -118,6 +118,7 @@ static struct platform_driver a10sr_reset_driver = {
.probe = a10sr_reset_probe,
.driver = {
.name = "altr_a10sr_reset",
+ .of_match_table = a10sr_reset_of_match,
},
};
module_platform_driver(a10sr_reset_driver);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] reset: a10sr: add missing of_match_table reference
2021-05-07 11:28 [PATCH] reset: a10sr: add missing of_match_table reference Krzysztof Kozlowski
@ 2021-05-10 7:50 ` Philipp Zabel
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Zabel @ 2021-05-10 7:50 UTC (permalink / raw)
To: Krzysztof Kozlowski, Thor Thayer, linux-kernel; +Cc: kernel test robot
On Fri, 2021-05-07 at 07:28 -0400, Krzysztof Kozlowski wrote:
> The driver defined of_device_id table but did not use it with
> of_match_table. This prevents usual matching via devicetree and causes
> a W=1 warning:
>
> drivers/reset/reset-a10sr.c:111:34: warning:
> ‘a10sr_reset_of_match’ defined but not used [-Wunused-const-variable=]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 627006820268 ("reset: Add Altera Arria10 SR Reset Controller")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> drivers/reset/reset-a10sr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/reset/reset-a10sr.c b/drivers/reset/reset-a10sr.c
> index 7eacc89382f8..99b3bc8382f3 100644
> --- a/drivers/reset/reset-a10sr.c
> +++ b/drivers/reset/reset-a10sr.c
> @@ -118,6 +118,7 @@ static struct platform_driver a10sr_reset_driver = {
> .probe = a10sr_reset_probe,
> .driver = {
> .name = "altr_a10sr_reset",
> + .of_match_table = a10sr_reset_of_match,
> },
> };
> module_platform_driver(a10sr_reset_driver);
Thank you, applied to reset/next.
regards
Philipp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-10 7:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-07 11:28 [PATCH] reset: a10sr: add missing of_match_table reference Krzysztof Kozlowski
2021-05-10 7:50 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).