From: Tomasz Nowicki <tn@semihalf.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: marc.zyngier@arm.com, jason@lakedaemon.net, rjw@rjwysocki.net,
helgaas@kernel.org, rafael@kernel.org, Lorenzo.Pieralisi@arm.com,
will.deacon@arm.com, catalin.marinas@arm.com,
hanjun.guo@linaro.org, shijie.huang@arm.com,
robert.richter@caviumnetworks.com, mw@semihalf.com,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linaro-acpi@lists.linaro.org, andrea.gallo@linaro.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
al.stone@linaro.org, graeme.gregory@linaro.org,
ddaney.cavm@gmail.com, okaya@codeaurora.org
Subject: Re: [PATCH V10 2/8] ACPI: Add new IORT functions to support MSI domain handling
Date: Tue, 6 Sep 2016 12:27:11 +0200 [thread overview]
Message-ID: <f469f024-b1c9-8616-c841-663e3e3d0731@semihalf.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1609061219230.5647@nanos>
On 06.09.2016 12:20, Thomas Gleixner wrote:
> On Tue, 6 Sep 2016, Tomasz Nowicki wrote:
>> +/**
>> + * iort_get_device_domain() - Find MSI domain related to a device
>> + * @dev: The device.
>> + * @req_id: Requester ID for the device.
>> + *
>> + * Returns: the MSI domain for this device, NULL otherwise
>> + */
>> +struct irq_domain *iort_get_device_domain(struct device *dev, u32 req_id)
>> +{
>> + static struct fwnode_handle *handle;
>
> static ??????
>
>> + int its_id;
>> +
>> + if (iort_dev_find_its_id(dev, req_id, 0, &its_id))
>> + return NULL;
>> +
>> + handle = iort_find_domain_token(its_id);
>
> You reevaluate that on every call.
>
Obviously it is the bug. Thanks for spotting this.
Tomasz
next prev parent reply other threads:[~2016-09-06 10:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 9:08 [PATCH V10 0/8] Introduce ACPI world to ITS irqchip Tomasz Nowicki
2016-09-06 9:08 ` [PATCH V10 1/8] ACPI: I/O Remapping Table (IORT) initial support Tomasz Nowicki
2016-09-07 11:56 ` [UPDATE PATCH " Tomasz Nowicki
2016-09-08 13:59 ` Lorenzo Pieralisi
2016-09-09 9:20 ` Lorenzo Pieralisi
2016-09-12 12:37 ` Tomasz Nowicki
2016-09-12 13:04 ` Marc Zyngier
2016-09-12 13:43 ` Rafael J. Wysocki
2016-09-09 3:09 ` [PATCH " Dennis Chen
2016-09-09 8:45 ` Lorenzo Pieralisi
2016-09-06 9:08 ` [PATCH V10 2/8] ACPI: Add new IORT functions to support MSI domain handling Tomasz Nowicki
2016-09-06 10:20 ` Thomas Gleixner
2016-09-06 10:27 ` Tomasz Nowicki [this message]
2016-09-07 10:35 ` Tomasz Nowicki
2016-09-07 11:32 ` Rafael J. Wysocki
2016-09-07 11:58 ` [UPDATE PATCH " Tomasz Nowicki
2016-09-07 13:01 ` Tomasz Nowicki
2016-09-06 9:08 ` [PATCH V10 3/8] PCI/MSI: Setup MSI domain on a per-device basis using IORT ACPI table Tomasz Nowicki
2016-09-06 9:08 ` [PATCH V10 4/8] irqchip/gicv3-its: Cleanup for ITS domain initialization Tomasz Nowicki
2016-09-06 9:08 ` [PATCH V10 5/8] irqchip/gicv3-its: Refactor ITS DT init code to prepare for ACPI Tomasz Nowicki
2016-09-06 9:08 ` [PATCH V10 6/8] irqchip/gicv3-its: Probe ITS in the ACPI way Tomasz Nowicki
2016-09-06 9:08 ` [PATCH V10 7/8] irqchip/gicv3-its: Factor out PCI-MSI part that might be reused for ACPI Tomasz Nowicki
2016-09-06 9:50 ` Thomas Gleixner
2016-09-06 10:22 ` Tomasz Nowicki
2016-09-06 11:29 ` Rafael J. Wysocki
2016-09-07 7:49 ` Tomasz Nowicki
2016-09-06 9:08 ` [PATCH V10 8/8] irqchip/gicv3-its: Use MADT ITS subtable to do PCI/MSI domain initialization Tomasz Nowicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f469f024-b1c9-8616-c841-663e3e3d0731@semihalf.com \
--to=tn@semihalf.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=al.stone@linaro.org \
--cc=andrea.gallo@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=ddaney.cavm@gmail.com \
--cc=graeme.gregory@linaro.org \
--cc=hanjun.guo@linaro.org \
--cc=helgaas@kernel.org \
--cc=jason@lakedaemon.net \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mw@semihalf.com \
--cc=okaya@codeaurora.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robert.richter@caviumnetworks.com \
--cc=shijie.huang@arm.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).