From: Thomas Gleixner <tglx@linutronix.de>
To: Tomasz Nowicki <tn@semihalf.com>
Cc: marc.zyngier@arm.com, jason@lakedaemon.net, rjw@rjwysocki.net,
helgaas@kernel.org, rafael@kernel.org, Lorenzo.Pieralisi@arm.com,
will.deacon@arm.com, catalin.marinas@arm.com,
hanjun.guo@linaro.org, shijie.huang@arm.com,
robert.richter@caviumnetworks.com, mw@semihalf.com,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linaro-acpi@lists.linaro.org, andrea.gallo@linaro.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
al.stone@linaro.org, graeme.gregory@linaro.org,
ddaney.cavm@gmail.com, okaya@codeaurora.org
Subject: Re: [PATCH V10 7/8] irqchip/gicv3-its: Factor out PCI-MSI part that might be reused for ACPI
Date: Tue, 6 Sep 2016 11:50:17 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1609061149090.5647@nanos> (raw)
In-Reply-To: <1473152938-17388-8-git-send-email-tn@semihalf.com>
On Tue, 6 Sep 2016, Tomasz Nowicki wrote:
> -static int __init its_pci_msi_init(void)
> +static int __init its_pci_msi_init_one(struct fwnode_handle *handle,
> + const char *name)
> {
> - struct device_node *np;
> struct irq_domain *parent;
>
> + parent = irq_find_matching_fwnode(handle, DOMAIN_BUS_NEXUS);
> + if (!parent || !msi_get_domain_info(parent)) {
> + pr_err("%s: Unable to locate ITS domain\n", name);
> + return -ENXIO;
> + }
> +
> + if (!pci_msi_create_irq_domain(handle, &its_pci_msi_domain_info,
> + parent)) {
> + pr_err("%s: Unable to create PCI domain\n", name);
> + return -ENOMEM;
So you have error codes here.
> + }
> +
> + return 0;
> +}
> +
> +static int __init its_pci_of_msi_init(void)
> +{
> + struct device_node *np;
> +
> for (np = of_find_matching_node(NULL, its_device_id); np;
> np = of_find_matching_node(np, its_device_id)) {
> if (!of_property_read_bool(np, "msi-controller"))
> continue;
>
> - parent = irq_find_matching_host(np, DOMAIN_BUS_NEXUS);
> - if (!parent || !msi_get_domain_info(parent)) {
> - pr_err("%s: unable to locate ITS domain\n",
> - np->full_name);
> + if (its_pci_msi_init_one(of_node_to_fwnode(np), np->full_name))
> continue;
> - }
> -
> - if (!pci_msi_create_irq_domain(of_node_to_fwnode(np),
> - &its_pci_msi_domain_info,
> - parent)) {
> - pr_err("%s: unable to create PCI domain\n",
> - np->full_name);
> - continue;
> - }
>
> pr_info("PCI/MSI: %s domain created\n", np->full_name);
> }
>
> return 0;
And no matter what you return success
> }
> +
> +static int __init its_pci_msi_init(void)
> +{
> + its_pci_of_msi_init();
Which you subsequently ignore here. What's the point?
Thanks,
tglx
next prev parent reply other threads:[~2016-09-06 9:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 9:08 [PATCH V10 0/8] Introduce ACPI world to ITS irqchip Tomasz Nowicki
2016-09-06 9:08 ` [PATCH V10 1/8] ACPI: I/O Remapping Table (IORT) initial support Tomasz Nowicki
2016-09-07 11:56 ` [UPDATE PATCH " Tomasz Nowicki
2016-09-08 13:59 ` Lorenzo Pieralisi
2016-09-09 9:20 ` Lorenzo Pieralisi
2016-09-12 12:37 ` Tomasz Nowicki
2016-09-12 13:04 ` Marc Zyngier
2016-09-12 13:43 ` Rafael J. Wysocki
2016-09-09 3:09 ` [PATCH " Dennis Chen
2016-09-09 8:45 ` Lorenzo Pieralisi
2016-09-06 9:08 ` [PATCH V10 2/8] ACPI: Add new IORT functions to support MSI domain handling Tomasz Nowicki
2016-09-06 10:20 ` Thomas Gleixner
2016-09-06 10:27 ` Tomasz Nowicki
2016-09-07 10:35 ` Tomasz Nowicki
2016-09-07 11:32 ` Rafael J. Wysocki
2016-09-07 11:58 ` [UPDATE PATCH " Tomasz Nowicki
2016-09-07 13:01 ` Tomasz Nowicki
2016-09-06 9:08 ` [PATCH V10 3/8] PCI/MSI: Setup MSI domain on a per-device basis using IORT ACPI table Tomasz Nowicki
2016-09-06 9:08 ` [PATCH V10 4/8] irqchip/gicv3-its: Cleanup for ITS domain initialization Tomasz Nowicki
2016-09-06 9:08 ` [PATCH V10 5/8] irqchip/gicv3-its: Refactor ITS DT init code to prepare for ACPI Tomasz Nowicki
2016-09-06 9:08 ` [PATCH V10 6/8] irqchip/gicv3-its: Probe ITS in the ACPI way Tomasz Nowicki
2016-09-06 9:08 ` [PATCH V10 7/8] irqchip/gicv3-its: Factor out PCI-MSI part that might be reused for ACPI Tomasz Nowicki
2016-09-06 9:50 ` Thomas Gleixner [this message]
2016-09-06 10:22 ` Tomasz Nowicki
2016-09-06 11:29 ` Rafael J. Wysocki
2016-09-07 7:49 ` Tomasz Nowicki
2016-09-06 9:08 ` [PATCH V10 8/8] irqchip/gicv3-its: Use MADT ITS subtable to do PCI/MSI domain initialization Tomasz Nowicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1609061149090.5647@nanos \
--to=tglx@linutronix.de \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=al.stone@linaro.org \
--cc=andrea.gallo@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=ddaney.cavm@gmail.com \
--cc=graeme.gregory@linaro.org \
--cc=hanjun.guo@linaro.org \
--cc=helgaas@kernel.org \
--cc=jason@lakedaemon.net \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mw@semihalf.com \
--cc=okaya@codeaurora.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robert.richter@caviumnetworks.com \
--cc=shijie.huang@arm.com \
--cc=tn@semihalf.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).