* [PATCH] docs/uio: fix a grammar nitpick
@ 2018-10-15 8:10 Will Korteland
2018-10-15 15:52 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Will Korteland @ 2018-10-15 8:10 UTC (permalink / raw)
To: corbet, linux-doc; +Cc: gregkh, linux-kernel
This patch fixes a minor, incorrect piece of grammar in the UIO howto.
Signed-off-by: Will Korteland <will@korte.land>
---
This is my first attempt at a kernel patch, so please let me know if
I've done something silly. I sent a copy of this a few days ago, but
I can't find it on the public archives - apologies if I've now posted
this twice.
Documentation/driver-api/uio-howto.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/driver-api/uio-howto.rst
b/Documentation/driver-api/uio-howto.rst
index fb2eb73be4a3..25f50eace28b 100644
--- a/Documentation/driver-api/uio-howto.rst
+++ b/Documentation/driver-api/uio-howto.rst
@@ -463,8 +463,8 @@ Getting information about your UIO device
Information about all UIO devices is available in sysfs. The first
thing
you should do in your driver is check ``name`` and ``version`` to make
-sure your talking to the right device and that its kernel driver has
the
-version you expect.
+sure you're talking to the right device and that its kernel driver has
+the version you expect.
You should also make sure that the memory mapping you need exists and
has the size you expect.
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] docs/uio: fix a grammar nitpick
2018-10-15 8:10 [PATCH] docs/uio: fix a grammar nitpick Will Korteland
@ 2018-10-15 15:52 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2018-10-15 15:52 UTC (permalink / raw)
To: Will Korteland, corbet, linux-doc; +Cc: gregkh, linux-kernel
On 10/15/18 1:10 AM, Will Korteland wrote:
> This patch fixes a minor, incorrect piece of grammar in the UIO howto.
>
> Signed-off-by: Will Korteland <will@korte.land>
Looks good to me. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> This is my first attempt at a kernel patch, so please let me know if
> I've done something silly. I sent a copy of this a few days ago, but
> I can't find it on the public archives - apologies if I've now posted
> this twice.
>
> Documentation/driver-api/uio-howto.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/driver-api/uio-howto.rst b/Documentation/driver-api/uio-howto.rst
> index fb2eb73be4a3..25f50eace28b 100644
> --- a/Documentation/driver-api/uio-howto.rst
> +++ b/Documentation/driver-api/uio-howto.rst
> @@ -463,8 +463,8 @@ Getting information about your UIO device
>
> Information about all UIO devices is available in sysfs. The first thing
> you should do in your driver is check ``name`` and ``version`` to make
> -sure your talking to the right device and that its kernel driver has the
> -version you expect.
> +sure you're talking to the right device and that its kernel driver has
> +the version you expect.
>
> You should also make sure that the memory mapping you need exists and
> has the size you expect.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] docs/uio: fix a grammar nitpick
[not found] <3c4f4e78-3557-ce1b-a5f0-cdcefae1fbd3@korte.land>
@ 2018-10-15 18:26 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2018-10-15 18:26 UTC (permalink / raw)
To: Will Korteland; +Cc: corbet, linux-doc, linux-kernel
On Sat, Oct 13, 2018 at 09:47:46PM +0000, Will Korteland wrote:
> This patch fixes a minor, incorrect piece of grammar in the UIO howto.
>
> Signed-off-by: Will Korteland <will@korte.land>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> This is my first attempt at a kernel patch, so please let me know if
> I've done something silly.
You sent this in html format :(
Also, the non-html format did not apply to the tree, can you redo this
against linux-next and resend it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-15 18:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-15 8:10 [PATCH] docs/uio: fix a grammar nitpick Will Korteland
2018-10-15 15:52 ` Randy Dunlap
[not found] <3c4f4e78-3557-ce1b-a5f0-cdcefae1fbd3@korte.land>
2018-10-15 18:26 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).