* [PATCH] s390/qeth: use true and false for boolean values
@ 2018-08-05 0:59 Gustavo A. R. Silva
2018-08-06 5:39 ` Julian Wiedmann
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2018-08-05 0:59 UTC (permalink / raw)
To: Julian Wiedmann, Ursula Braun, Martin Schwidefsky, Heiko Carstens
Cc: linux-s390, linux-kernel, Gustavo A. R. Silva
Return statements in functions returning bool should use true or false
instead of an integer value.
This issue was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/s390/net/qeth_l3_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c
index 1833e75..7175086 100644
--- a/drivers/s390/net/qeth_l3_main.c
+++ b/drivers/s390/net/qeth_l3_main.c
@@ -117,9 +117,9 @@ static bool qeth_l3_is_addr_covered_by_ipato(struct qeth_card *card,
int rc = 0;
if (!card->ipato.enabled)
- return 0;
+ return false;
if (addr->type != QETH_IP_TYPE_NORMAL)
- return 0;
+ return false;
qeth_l3_convert_addr_to_bits((u8 *) &addr->u, addr_bits,
(addr->proto == QETH_PROT_IPV4)? 4:16);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] s390/qeth: use true and false for boolean values
2018-08-05 0:59 [PATCH] s390/qeth: use true and false for boolean values Gustavo A. R. Silva
@ 2018-08-06 5:39 ` Julian Wiedmann
0 siblings, 0 replies; 2+ messages in thread
From: Julian Wiedmann @ 2018-08-06 5:39 UTC (permalink / raw)
To: Gustavo A. R. Silva, Ursula Braun, Martin Schwidefsky, Heiko Carstens
Cc: linux-s390, linux-kernel
On 08/05/2018 02:59 AM, Gustavo A. R. Silva wrote:
> Return statements in functions returning bool should use true or false
> instead of an integer value.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Queued up for net-next, thanks.
> ---
> drivers/s390/net/qeth_l3_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c
> index 1833e75..7175086 100644
> --- a/drivers/s390/net/qeth_l3_main.c
> +++ b/drivers/s390/net/qeth_l3_main.c
> @@ -117,9 +117,9 @@ static bool qeth_l3_is_addr_covered_by_ipato(struct qeth_card *card,
> int rc = 0;
>
> if (!card->ipato.enabled)
> - return 0;
> + return false;
> if (addr->type != QETH_IP_TYPE_NORMAL)
> - return 0;
> + return false;
>
> qeth_l3_convert_addr_to_bits((u8 *) &addr->u, addr_bits,
> (addr->proto == QETH_PROT_IPV4)? 4:16);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-06 5:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-05 0:59 [PATCH] s390/qeth: use true and false for boolean values Gustavo A. R. Silva
2018-08-06 5:39 ` Julian Wiedmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).