* [PATCH v3] x86: treat pkey-0 special
@ 2018-03-14 21:00 Ram Pai
2018-03-15 9:46 ` Thomas Gleixner
0 siblings, 1 reply; 7+ messages in thread
From: Ram Pai @ 2018-03-14 21:00 UTC (permalink / raw)
To: mingo
Cc: mpe, linuxppc-dev, linux-mm, x86, linux-arch, linux-kernel, akpm,
dave.hansen, benh, paulus, khandual, aneesh.kumar, bsingharora,
hbabu, mhocko, bauerman, ebiederm, linuxram, corbet, arnd,
fweimer, msuchanek, Ulrich.Weigand
Applications need the ability to associate an address-range with some
key and latter revert to its initial default key. Pkey-0 comes close to
providing this function but falls short, because the current
implementation disallows applications to explicitly associate pkey-0 to
the address range.
This patch clarifies the semantics of pkey-0 and provides the
corresponding implementation on powerpc.
Pkey-0 is special with the following semantics.
(a) it is implicitly allocated and can never be freed. It always exists.
(b) it is the default key assigned to any address-range.
(c) it can be explicitly associated with any address-range.
Tested on x86_64.
History:
v3 : added clarification of the semantics of pkey0.
-- suggested by Dave Hansen
v2 : split the patch into two, one for x86 and one for powerpc
-- suggested by Michael Ellermen
cc: Dave Hansen <dave.hansen@intel.com>
cc: Michael Ellermen <mpe@ellerman.id.au>
cc: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Ram Pai <linuxram@us.ibm.com>
---
arch/x86/include/asm/pkeys.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/pkeys.h b/arch/x86/include/asm/pkeys.h
index a0ba1ff..6ea7486 100644
--- a/arch/x86/include/asm/pkeys.h
+++ b/arch/x86/include/asm/pkeys.h
@@ -52,7 +52,7 @@ bool mm_pkey_is_allocated(struct mm_struct *mm, int pkey)
* from pkey_alloc(). pkey 0 is special, and never
* returned from pkey_alloc().
*/
- if (pkey <= 0)
+ if (pkey < 0)
return false;
if (pkey >= arch_max_pkey())
return false;
@@ -92,7 +92,8 @@ int mm_pkey_alloc(struct mm_struct *mm)
static inline
int mm_pkey_free(struct mm_struct *mm, int pkey)
{
- if (!mm_pkey_is_allocated(mm, pkey))
+ /* pkey 0 is special and can never be freed */
+ if (!pkey || !mm_pkey_is_allocated(mm, pkey))
return -EINVAL;
mm_set_pkey_free(mm, pkey);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v3] x86: treat pkey-0 special
2018-03-14 21:00 [PATCH v3] x86: treat pkey-0 special Ram Pai
@ 2018-03-15 9:46 ` Thomas Gleixner
2018-03-15 15:55 ` Dave Hansen
0 siblings, 1 reply; 7+ messages in thread
From: Thomas Gleixner @ 2018-03-15 9:46 UTC (permalink / raw)
To: Ram Pai
Cc: mingo, mpe, linuxppc-dev, linux-mm, x86, linux-arch,
linux-kernel, akpm, dave.hansen, benh, paulus, khandual,
aneesh.kumar, bsingharora, hbabu, mhocko, bauerman, ebiederm,
corbet, arnd, fweimer, msuchanek, Ulrich.Weigand
On Wed, 14 Mar 2018, Ram Pai wrote:
> Applications need the ability to associate an address-range with some
> key and latter revert to its initial default key. Pkey-0 comes close to
> providing this function but falls short, because the current
> implementation disallows applications to explicitly associate pkey-0 to
> the address range.
>
> This patch clarifies the semantics of pkey-0 and provides the
grep 'This patch' Documentation/process
> corresponding implementation on powerpc.
>
> Pkey-0 is special with the following semantics.
> (a) it is implicitly allocated and can never be freed. It always exists.
> (b) it is the default key assigned to any address-range.
> (c) it can be explicitly associated with any address-range.
>
> Tested on x86_64.
I'm curious how the corresponding implementation on powerpc can be tested
on x86_64. Copy and paste is not enough ...
>
> History:
> v3 : added clarification of the semantics of pkey0.
> -- suggested by Dave Hansen
> v2 : split the patch into two, one for x86 and one for powerpc
> -- suggested by Michael Ellermen
Please put the history below the --- seperator. It's not part of the
changelog. That way the tools can discard it when picking up the patch.
>
> cc: Dave Hansen <dave.hansen@intel.com>
> cc: Michael Ellermen <mpe@ellerman.id.au>
> cc: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Ram Pai <linuxram@us.ibm.com>
> ---
> arch/x86/include/asm/pkeys.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/include/asm/pkeys.h b/arch/x86/include/asm/pkeys.h
> index a0ba1ff..6ea7486 100644
> --- a/arch/x86/include/asm/pkeys.h
> +++ b/arch/x86/include/asm/pkeys.h
> @@ -52,7 +52,7 @@ bool mm_pkey_is_allocated(struct mm_struct *mm, int pkey)
> * from pkey_alloc(). pkey 0 is special, and never
> * returned from pkey_alloc().
> */
> - if (pkey <= 0)
> + if (pkey < 0)
> return false;
> if (pkey >= arch_max_pkey())
> return false;
> @@ -92,7 +92,8 @@ int mm_pkey_alloc(struct mm_struct *mm)
> static inline
> int mm_pkey_free(struct mm_struct *mm, int pkey)
> {
> - if (!mm_pkey_is_allocated(mm, pkey))
> + /* pkey 0 is special and can never be freed */
This comment is pretty useless. How should anyone figure out whats special
about pkey 0?
> + if (!pkey || !mm_pkey_is_allocated(mm, pkey))
Why this extra check? mm_pkey_is_allocated(mm, 0) should not return true
ever. If it does, then this wants to be fixed.
Thanks,
tglx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3] x86: treat pkey-0 special
2018-03-15 9:46 ` Thomas Gleixner
@ 2018-03-15 15:55 ` Dave Hansen
2018-03-15 16:13 ` Thomas Gleixner
2018-03-15 17:21 ` Ram Pai
0 siblings, 2 replies; 7+ messages in thread
From: Dave Hansen @ 2018-03-15 15:55 UTC (permalink / raw)
To: Thomas Gleixner, Ram Pai
Cc: mingo, mpe, linuxppc-dev, linux-mm, x86, linux-arch,
linux-kernel, akpm, benh, paulus, khandual, aneesh.kumar,
bsingharora, hbabu, mhocko, bauerman, ebiederm, corbet, arnd,
fweimer, msuchanek, Ulrich.Weigand
On 03/15/2018 02:46 AM, Thomas Gleixner wrote:
>> + if (!pkey || !mm_pkey_is_allocated(mm, pkey))
> Why this extra check? mm_pkey_is_allocated(mm, 0) should not return true
> ever. If it does, then this wants to be fixed.
I was thinking that we _do_ actually want it to seem allocated. It just
get "allocated" implicitly when an mm is created. I think that will
simplify the code if we avoid treating it specially in as many places as
possible.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3] x86: treat pkey-0 special
2018-03-15 15:55 ` Dave Hansen
@ 2018-03-15 16:13 ` Thomas Gleixner
2018-03-15 17:21 ` Ram Pai
1 sibling, 0 replies; 7+ messages in thread
From: Thomas Gleixner @ 2018-03-15 16:13 UTC (permalink / raw)
To: Dave Hansen
Cc: Ram Pai, mingo, mpe, linuxppc-dev, linux-mm, x86, linux-arch,
linux-kernel, akpm, benh, paulus, khandual, aneesh.kumar,
bsingharora, hbabu, mhocko, bauerman, ebiederm, corbet, arnd,
fweimer, msuchanek, Ulrich.Weigand
On Thu, 15 Mar 2018, Dave Hansen wrote:
> On 03/15/2018 02:46 AM, Thomas Gleixner wrote:
> >> + if (!pkey || !mm_pkey_is_allocated(mm, pkey))
> > Why this extra check? mm_pkey_is_allocated(mm, 0) should not return true
> > ever. If it does, then this wants to be fixed.
>
> I was thinking that we _do_ actually want it to seem allocated. It just
> get "allocated" implicitly when an mm is created. I think that will
> simplify the code if we avoid treating it specially in as many places as
> possible.
That works as well.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3] x86: treat pkey-0 special
2018-03-15 15:55 ` Dave Hansen
2018-03-15 16:13 ` Thomas Gleixner
@ 2018-03-15 17:21 ` Ram Pai
2018-03-15 17:31 ` Dave Hansen
1 sibling, 1 reply; 7+ messages in thread
From: Ram Pai @ 2018-03-15 17:21 UTC (permalink / raw)
To: Dave Hansen
Cc: Thomas Gleixner, mingo, mpe, linuxppc-dev, linux-mm, x86,
linux-arch, linux-kernel, akpm, benh, paulus, khandual,
aneesh.kumar, bsingharora, hbabu, mhocko, bauerman, ebiederm,
corbet, arnd, fweimer, msuchanek, Ulrich.Weigand
On Thu, Mar 15, 2018 at 08:55:31AM -0700, Dave Hansen wrote:
> On 03/15/2018 02:46 AM, Thomas Gleixner wrote:
> >> + if (!pkey || !mm_pkey_is_allocated(mm, pkey))
> > Why this extra check? mm_pkey_is_allocated(mm, 0) should not return true
> > ever. If it does, then this wants to be fixed.
>
> I was thinking that we _do_ actually want it to seem allocated. It just
> get "allocated" implicitly when an mm is created. I think that will
> simplify the code if we avoid treating it specially in as many places as
> possible.
I think, the logic that makes pkey-0 special must to go
in arch-neutral code. How about checking for pkey-0 in sys_pkey_free()
itself?
RP
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3] x86: treat pkey-0 special
2018-03-15 17:21 ` Ram Pai
@ 2018-03-15 17:31 ` Dave Hansen
2018-03-15 17:39 ` Ram Pai
0 siblings, 1 reply; 7+ messages in thread
From: Dave Hansen @ 2018-03-15 17:31 UTC (permalink / raw)
To: Ram Pai
Cc: Thomas Gleixner, mingo, mpe, linuxppc-dev, linux-mm, x86,
linux-arch, linux-kernel, akpm, benh, paulus, khandual,
aneesh.kumar, bsingharora, hbabu, mhocko, bauerman, ebiederm,
corbet, arnd, fweimer, msuchanek, Ulrich.Weigand
On 03/15/2018 10:21 AM, Ram Pai wrote:
> On Thu, Mar 15, 2018 at 08:55:31AM -0700, Dave Hansen wrote:
>> On 03/15/2018 02:46 AM, Thomas Gleixner wrote:
>>>> + if (!pkey || !mm_pkey_is_allocated(mm, pkey))
>>> Why this extra check? mm_pkey_is_allocated(mm, 0) should not return true
>>> ever. If it does, then this wants to be fixed.
>> I was thinking that we _do_ actually want it to seem allocated. It just
>> get "allocated" implicitly when an mm is created. I think that will
>> simplify the code if we avoid treating it specially in as many places as
>> possible.
> I think, the logic that makes pkey-0 special must to go
> in arch-neutral code. How about checking for pkey-0 in sys_pkey_free()
> itself?
This is for protection against shooting yourself in the foot? Yes, that
can go in sys_pkey_free().
Does this need manpage and/or selftests updates?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3] x86: treat pkey-0 special
2018-03-15 17:31 ` Dave Hansen
@ 2018-03-15 17:39 ` Ram Pai
0 siblings, 0 replies; 7+ messages in thread
From: Ram Pai @ 2018-03-15 17:39 UTC (permalink / raw)
To: Dave Hansen
Cc: Thomas Gleixner, mingo, mpe, linuxppc-dev, linux-mm, x86,
linux-arch, linux-kernel, akpm, benh, paulus, khandual,
aneesh.kumar, bsingharora, hbabu, mhocko, bauerman, ebiederm,
corbet, arnd, fweimer, msuchanek, Ulrich.Weigand
On Thu, Mar 15, 2018 at 10:31:51AM -0700, Dave Hansen wrote:
> On 03/15/2018 10:21 AM, Ram Pai wrote:
> > On Thu, Mar 15, 2018 at 08:55:31AM -0700, Dave Hansen wrote:
> >> On 03/15/2018 02:46 AM, Thomas Gleixner wrote:
> >>>> + if (!pkey || !mm_pkey_is_allocated(mm, pkey))
> >>> Why this extra check? mm_pkey_is_allocated(mm, 0) should not return true
> >>> ever. If it does, then this wants to be fixed.
> >> I was thinking that we _do_ actually want it to seem allocated. It just
> >> get "allocated" implicitly when an mm is created. I think that will
> >> simplify the code if we avoid treating it specially in as many places as
> >> possible.
> > I think, the logic that makes pkey-0 special must to go
> > in arch-neutral code. How about checking for pkey-0 in sys_pkey_free()
> > itself?
>
> This is for protection against shooting yourself in the foot? Yes, that
> can go in sys_pkey_free().
>
> Does this need manpage and/or selftests updates?
Yes. it needs selftest, manpage and documentation updates too.
Unfortunately I am not getting enough reviewed-by for my selftests
and documentation changes. :-( Need help!
--
Ram Pai
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-03-15 17:40 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-14 21:00 [PATCH v3] x86: treat pkey-0 special Ram Pai
2018-03-15 9:46 ` Thomas Gleixner
2018-03-15 15:55 ` Dave Hansen
2018-03-15 16:13 ` Thomas Gleixner
2018-03-15 17:21 ` Ram Pai
2018-03-15 17:31 ` Dave Hansen
2018-03-15 17:39 ` Ram Pai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).