* [PATCH] libbpf: zip: Remove unneeded semicolon from zip_archive_open()
[not found] <20230614082626.45467-1-luojianhong@cdjrlc.com>
@ 2023-06-14 8:29 ` baomingtong001
2023-06-16 16:36 ` Andrii Nakryiko
0 siblings, 1 reply; 2+ messages in thread
From: baomingtong001 @ 2023-06-14 8:29 UTC (permalink / raw)
To: ast, daniel, andrii, martin.lau, song, yhs, john.fastabend,
kpsingh, sdf, haoluo, jolsa
Cc: bpf, linux-kernel
./tools/lib/bpf/zip.c:226:2-3: Unneeded semicolon
Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
---
tools/lib/bpf/zip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/bpf/zip.c b/tools/lib/bpf/zip.c
index 3f26d629b2b4..88c376a8348d 100644
--- a/tools/lib/bpf/zip.c
+++ b/tools/lib/bpf/zip.c
@@ -223,7 +223,7 @@ struct zip_archive *zip_archive_open(const char
*path)
if (!archive) {
munmap(data, size);
return ERR_PTR(-ENOMEM);
- };
+ }
archive->data = data;
archive->size = size;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libbpf: zip: Remove unneeded semicolon from zip_archive_open()
2023-06-14 8:29 ` [PATCH] libbpf: zip: Remove unneeded semicolon from zip_archive_open() baomingtong001
@ 2023-06-16 16:36 ` Andrii Nakryiko
0 siblings, 0 replies; 2+ messages in thread
From: Andrii Nakryiko @ 2023-06-16 16:36 UTC (permalink / raw)
To: baomingtong001
Cc: ast, daniel, andrii, martin.lau, song, yhs, john.fastabend,
kpsingh, sdf, haoluo, jolsa, bpf, linux-kernel
On Wed, Jun 14, 2023 at 1:29 AM <baomingtong001@208suo.com> wrote:
>
> ./tools/lib/bpf/zip.c:226:2-3: Unneeded semicolon
This is not a very human-readable commit message. Something like
Drop unnecessary semicolon, which triggers (presumable coccicheck?) warning:
./tools/lib/bpf/zip.c:226:2-3: Unneeded semicolon
But also this doesn't apply cleanly to bpf-next tree. Please rebase
and resend. Also make sure to have [PATCH bpf-next] prefix in email
subject. Thanks.
>
> Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
> ---
> tools/lib/bpf/zip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/zip.c b/tools/lib/bpf/zip.c
> index 3f26d629b2b4..88c376a8348d 100644
> --- a/tools/lib/bpf/zip.c
> +++ b/tools/lib/bpf/zip.c
> @@ -223,7 +223,7 @@ struct zip_archive *zip_archive_open(const char
> *path)
> if (!archive) {
> munmap(data, size);
> return ERR_PTR(-ENOMEM);
> - };
> + }
>
> archive->data = data;
> archive->size = size;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-16 16:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230614082626.45467-1-luojianhong@cdjrlc.com>
2023-06-14 8:29 ` [PATCH] libbpf: zip: Remove unneeded semicolon from zip_archive_open() baomingtong001
2023-06-16 16:36 ` Andrii Nakryiko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).