[PATCH -next resend] media: staging: media: atomisp: pci: fix error return code in atomisp_pci_probe()

[PATCH -next resend] media: staging: media: atomisp: pci: fix error return code in atomisp_pci_probe()

[Yang Yingliang]

If init_atomisp_wdts() fails, atomisp_pci_probe() need return
error code.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
index 948769ca6539..d50c38e1cd1d 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
@@ -1763,7 +1763,8 @@ static int atomisp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i
 	if (err < 0)
 		goto register_entities_fail;
 	/* init atomisp wdts */
-	if (init_atomisp_wdts(isp) != 0)
+	err = init_atomisp_wdts(isp);
+	if (err)
 		goto wdt_work_queue_fail;
 
 	/* save the iunit context only once after all the values are init'ed. */
-- 
2.25.1

Re: [PATCH -next resend] media: staging: media: atomisp: pci: fix error return code in atomisp_pci_probe()

[Dan Carpenter]

Looks good.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

But next time please use v2 in the subject instead of "resend".  "resend"
means that the process broke down somehow and we ignored your first
patch.

On Thu, Jun 17, 2021 at 09:55:00PM +0800, Yang Yingliang wrote:
> If init_atomisp_wdts() fails, atomisp_pci_probe() need return
> error code.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
Put a note here under the --- cut off line to say what happened since
the last version.

v2: style change


>  drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

regards,
dan carpenter

Re: [PATCH -next resend] media: staging: media: atomisp: pci: fix error return code in atomisp_pci_probe()

[Yang Yingliang]

On 2021/6/17 21:58, Dan Carpenter wrote:
> Looks good.
>
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> But next time please use v2 in the subject instead of "resend".  "resend"
> means that the process broke down somehow and we ignored your first
> patch.
>
> On Thu, Jun 17, 2021 at 09:55:00PM +0800, Yang Yingliang wrote:
>> If init_atomisp_wdts() fails, atomisp_pci_probe() need return
>> error code.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>> ---
> Put a note here under the --- cut off line to say what happened since
> the last version.
>
> v2: style change
OK

Thanks,
Yang
>
>
>>   drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
> regards,
> dan carpenter
>
> .