linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* A potential data race in drivers/net/ethernet/smsc/smc91c92_cs.ko
@ 2016-08-12  9:54 Pavel Andrianov
  0 siblings, 0 replies; only message in thread
From: Pavel Andrianov @ 2016-08-12  9:54 UTC (permalink / raw)
  To: Felipe Balbi, Mugunthan V N
  Cc: Antonio Quartulli, Florian Westphal, David S. Miller, netdev,
	linux-kernel, Vaishali Thakkar, ldv-project

Hi!

There is a potential data race in drivers/net/ethernet/smsc/smc91c92_cs.ko.
Regard two threads:

Thread 1 			Thread 2
				...
...				->smc_open
->smc_tx_timeout		  ->mod_timer 	
   -> smc_reset			    ->media_check - timer function
     -> smc_set_xcvr		      ->smc_set_xcvr	

In this case the struct 'smc' is modified from two threads 
simultaneously. Likely, the first thread should acquire the same 
spinlock smc->lock as the second thread in media_check.

-- 
Pavel Andrianov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: andrianov@ispras.ru

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-12  9:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-12  9:54 A potential data race in drivers/net/ethernet/smsc/smc91c92_cs.ko Pavel Andrianov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).