From: Icenowy Zheng <icenowy@aosc.io>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: devicetree@vger.kernel.org,
Archit Taneja <architt@codeaurora.org>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Andrzej Hajda <a.hajda@samsung.com>,
linux-sunxi@googlegroups.com, Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/9] dt-bindings: Add ANX6345 DP/eDP transmitter binding
Date: Thu, 18 Oct 2018 20:40:11 +0800 [thread overview]
Message-ID: <f71d442412f31828c466e3483e9d42f5e96ddc1d.camel@aosc.io> (raw)
In-Reply-To: <2778638.na8ndVNUfi@avalon>
在 2018-10-18四的 14:23 +0300,Laurent Pinchart写道:
> Hi Icenowy,
>
> On Thursday, 18 October 2018 13:00:05 EEST Icenowy Zheng wrote:
> > 在 2018-10-18四的 11:53 +0300,Laurent Pinchart写道:
> > > On Thursday, 18 October 2018 10:33:22 EEST Icenowy Zheng wrote:
> > > > The ANX6345 is an ultra-low power DisplayPort/eDP transmitter
> > > > designed
> > > > for portable devices.
> > > >
> > > > Add a binding document for it.
> > > >
> > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > > > ---
> > > >
> > > > .../bindings/display/bridge/anx6345.txt | 39
> > > > +++++++++++++++++++
> > > >
> > > > 1 file changed, 39 insertions(+)
> > > > create mode 100644
> > > >
> > > > Documentation/devicetree/bindings/display/bridge/anx6345.txt
> > > >
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/display/bridge/anx6345.txt
> > > > b/Documentation/devicetree/bindings/display/bridge/anx6345.txt
> > > > new
> > > > file
> > > > mode 100644
> > > > index 000000000000..0689d4eb5f65
> > > > --- /dev/null
> > > > +++
> > > > b/Documentation/devicetree/bindings/display/bridge/anx6345.txt
> > > > @@ -0,0 +1,39 @@
> > > > +Analogix ANX6345 eDP Transmitter
> > > > +--------------------------------
> > > > +
> > > > +The ANX6345 is an ultra-low power Full-HD eDP transmitter
> > > > designed
> > > > for
> > > > +portable devices.
> > > > +
> > > > +Required properties:
> > > > +
> > > > + - compatible : "analogix,anx6345"
> > > > + - reg : I2C address of the device
> > > > + - reset-gpios : Which GPIO to use for reset
> > > > +
> > > > +Optional properties:
> > > > +
> > > > + - dvdd12-supply : Regulator for 1.2V digital core
> > > > power.
> > > > + - dvdd25-supply : Regulator for 2.5V digital core
> > > > power.
> > >
> > > Shouldn't these to supplies be mandatory ?
> >
> > Yes they should.
> >
> > > > + - panel-supply : Regulator for the power of
> > > > the panel.
> > >
> > > Shouldn't the panel supply for specified in the DT node of the
> > > panel
> > > ?
> >
> > However, eDP panel can be probed, may vary on the same device, and
> > we
> > don't have a generic binding for it...
>
> Shouldn't we fix that ? :-)
Maybe we should create a connector binding instead of a panel binding?
>
> > > > + - edid : verbatim EDID data block
> > > > describing
> > > > attached
> > > > + panel, only used when the panel has
> > > > no EDID
> > > > info.
> > >
> > > This should also be specified in the panel DT node.
> > >
> > > > + - Video port for RGB input, using the DT bindings defined in
> > > > [1].
> > >
> > > I think you should also add a port for the output.
> >
> > What will it point to?
>
> The panel DT node ?
>
> > > > +[1]: Documentation/devicetree/bindings/media/video-
> > > > interfaces.txt
> > > > +
> > > > +Example:
> > > > +
> > > > +anx6345: anx6345@38 {
> > > > + compatible = "analogix,anx6345";
> > > > + reg = <0x38>;
> > > > + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */
> > > > + panel-supply = <®_dc1sw>;
> > > > + dvdd25-supply = <®_dldo2>;
> > > > + dvdd12-supply = <®_fldo1>;
> > > > +
> > > > + port {
> > > > + anx6345_in: endpoint {
> > > > + remote-endpoint = <&tcon0_out_anx6345>;
> > > > + };
> > > > + };
> > > > +};
>
>
next prev parent reply other threads:[~2018-10-18 12:40 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 7:33 [PATCH 0/9] Analogix ANX6345 RGB-(e)DP bridge support Icenowy Zheng
2018-10-18 7:33 ` [PATCH 1/9] drm/bridge: move ANA78xx driver to analogix subdirectory Icenowy Zheng
2018-10-18 8:47 ` Laurent Pinchart
2018-10-18 7:33 ` [PATCH 2/9] drm/bridge: split some definitions of ANX78xx to dedicated headers Icenowy Zheng
2018-10-18 7:33 ` [PATCH 3/9] drm/bridge: extract some Analogix I2C DP common code Icenowy Zheng
2018-10-18 7:33 ` [PATCH 4/9] dt-bindings: Add ANX6345 DP/eDP transmitter binding Icenowy Zheng
2018-10-18 8:53 ` Laurent Pinchart
2018-10-18 10:00 ` Icenowy Zheng
2018-10-18 11:23 ` Laurent Pinchart
2018-10-18 12:40 ` Icenowy Zheng [this message]
2018-10-25 18:30 ` Rob Herring
2018-10-26 0:08 ` Icenowy Zheng
2018-10-18 7:33 ` [PATCH 5/9] drm/bridge: Add Analogix anx6345 support Icenowy Zheng
2018-10-18 7:33 ` [PATCH 6/9] arm64: allwinner: a64: add pinmux for RGB666 LCD Icenowy Zheng
2018-10-18 7:33 ` [PATCH 7/9] arm64: allwinner: a64: enable ANX6345 bridge on Pinebook Icenowy Zheng
2018-10-18 15:17 ` Vasily Khoruzhick
2018-10-19 5:50 ` Icenowy Zheng
2018-10-18 7:33 ` [PATCH 8/9] arm64: allwinner: a64: enable ANX6345 bridge on TERES-I Icenowy Zheng
2018-10-18 7:33 ` [PATCH 9/9] [DO NOT MERGE] drm/sun4i: rgb: Add 5% tolerance to dot clock frequency check Icenowy Zheng
2018-10-18 8:55 ` Laurent Pinchart
2018-10-18 9:18 ` Daniel Vetter
2018-10-18 9:42 ` Maxime Ripard
2018-10-18 11:31 ` Laurent Pinchart
2018-10-18 12:18 ` Maxime Ripard
2018-10-18 12:50 ` Icenowy Zheng
2018-10-18 13:07 ` Maxime Ripard
2018-10-18 13:57 ` Laurent Pinchart
2019-02-03 1:32 ` Vasily Khoruzhick
2018-10-29 2:20 ` [PATCH 0/9] Analogix ANX6345 RGB-(e)DP bridge support Vasily Khoruzhick
2019-02-04 12:22 ` Torsten Duwe
2019-02-04 20:21 ` Vasily Khoruzhick
[not found] ` <20190203185501.8958-6-anarsoul@gmail.com>
2019-02-05 13:19 ` [PATCH RESEND v2 05/12] drm/bridge: Add Analogix anx6345 support Torsten Duwe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f71d442412f31828c466e3483e9d42f5e96ddc1d.camel@aosc.io \
--to=icenowy@aosc.io \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).