Re: [PATCH -next] drm/amdgpu: use kmemdup rather than duplicating its implementation

From: "Christian König" <deathsimple@vodafone.de>
To: "Nicolai Hähnle" <nhaehnle@gmail.com>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"'Sean Paul'" <seanpaul@google.com>,
	"Wei Yongjun" <weiyj.lk@gmail.com>
Cc: "Jiang, Sonny" <Sonny.Jiang@amd.com>,
	"Zhou, Jammy" <Jammy.Zhou@amd.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"Nath, Arindam" <Arindam.Nath@amd.com>,
	"Liu, Leo" <Leo.Liu@amd.com>,
	"Koenig, Christian" <Christian.Koenig@amd.com>,
	"Liu, Monk" <Monk.Liu@amd.com>
Subject: Re: [PATCH -next] drm/amdgpu: use kmemdup rather than duplicating its implementation
Date: Tue, 2 Aug 2016 15:37:31 +0200	[thread overview]
Message-ID: <f78e798b-259a-53bb-f49b-8bb29d88a356@vodafone.de> (raw)
In-Reply-To: <f37296c1-40db-38dc-1976-0d4a1ab8c2ca@gmail.com>

Am 01.08.2016 um 14:16 schrieb Nicolai Hähnle:
> On 29.07.2016 20:38, Deucher, Alexander wrote:
>>> -----Original Message-----
>>> From: Sean Paul [mailto:seanpaul@google.com]
>>> Sent: Friday, July 29, 2016 3:35 PM
>>> To: Wei Yongjun
>>> Cc: Deucher, Alexander; Koenig, Christian; Dave Airlie; Jiang, 
>>> Sonny; Liu, Leo;
>>> Nath, Arindam; Zhou, David(ChunMing); Zhou, Jammy; Liu, Monk; 
>>> dri-devel;
>>> Linux Kernel Mailing List
>>> Subject: Re: [PATCH -next] drm/amdgpu: use kmemdup rather than
>>> duplicating its implementation
>>>
>>> On Thu, Jul 28, 2016 at 12:18 PM, Wei Yongjun <weiyj.lk@gmail.com> 
>>> wrote:
>>>> Use kmemdup rather than duplicating its implementation.
>>>>
>>>> Generated by: scripts/coccinelle/api/memdup.cocci
>>>>
>>>> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
>>>
>>>
>>> Thanks for the patch. I'll apply this to -misc once the merge window 
>>> is closed.
>>>
>>> Acked-by: Sean Paul <seanpaul@chromium.org>
>>
>> Unless you've already applied this to the misc tree, I'd prefer to 
>> take it via the amdgpu tree.
>
> I recall Christian NAKing an almost identical patch some time ago. 
> Something about needing memcpy_fromio()?
>
> Yup, it's here: https://lkml.org/lkml/2016/5/19/235

Yes, exactly. We need memcpy_fromio() and memcpy_toio() in the 
suspend/resume functions instead of memcpy.

I just didn't had time to test that yet (and that was unfortunately a 
few month ago already).

So please drop this patch,
Christian.

>
> Cheers,
> Nicolai
>
>>
>> Alex
>>
>>>
>>>
>>>> ---
>>>>  drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 +---
>>>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>>>> index a46a64c..b779b5f 100644
>>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>>>> @@ -296,12 +296,10 @@ int amdgpu_uvd_suspend(struct amdgpu_device
>>> *adev)
>>>>         size = amdgpu_bo_size(adev->uvd.vcpu_bo);
>>>>         ptr = adev->uvd.cpu_addr;
>>>>
>>>> -       adev->uvd.saved_bo = kmalloc(size, GFP_KERNEL);
>>>> +       adev->uvd.saved_bo = kmemdup(ptr, size, GFP_KERNEL);
>>>>         if (!adev->uvd.saved_bo)
>>>>                 return -ENOMEM;
>>>>
>>>> -       memcpy(adev->uvd.saved_bo, ptr, size);
>>>> -
>>>>         return 0;
>>>>  }
>>>>
>>>>
>>>>
>>>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel