Re: [PATCH -next] drm/amdgpu: use kmemdup rather than duplicating its implementation

From: Sean Paul <seanpaul@google.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Dave Airlie" <airlied@linux.ie>,
	sonny.jiang@amd.com, leo.liu@amd.com, arindam.nath@amd.com,
	David1.Zhou@amd.com, Jammy.Zhou@amd.com, Monk.Liu@amd.com,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] drm/amdgpu: use kmemdup rather than duplicating its implementation
Date: Fri, 29 Jul 2016 15:35:05 -0400	[thread overview]
Message-ID: <CAOw6vb+Bn0vF5i-1DpTiSh3LBYzaP4VWF096oo2Mwxm_SSbHoQ@mail.gmail.com> (raw)
In-Reply-To: <1469722697-15220-1-git-send-email-weiyj.lk@gmail.com>

On Thu, Jul 28, 2016 at 12:18 PM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> Use kmemdup rather than duplicating its implementation.
>
> Generated by: scripts/coccinelle/api/memdup.cocci
>
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>

Thanks for the patch. I'll apply this to -misc once the merge window is closed.

Acked-by: Sean Paul <seanpaul@chromium.org>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> index a46a64c..b779b5f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> @@ -296,12 +296,10 @@ int amdgpu_uvd_suspend(struct amdgpu_device *adev)
>         size = amdgpu_bo_size(adev->uvd.vcpu_bo);
>         ptr = adev->uvd.cpu_addr;
>
> -       adev->uvd.saved_bo = kmalloc(size, GFP_KERNEL);
> +       adev->uvd.saved_bo = kmemdup(ptr, size, GFP_KERNEL);
>         if (!adev->uvd.saved_bo)
>                 return -ENOMEM;
>
> -       memcpy(adev->uvd.saved_bo, ptr, size);
> -
>         return 0;
>  }
>
>
>
>