From: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
namhyung@kernel.org, treeze.taeung@gmail.com,
linux-kernel@vger.kernel.org, dstence@us.ibm.com,
ravi.bangoria@linux.vnet.ibm.com
Subject: Re: [PATCH] perf annotate: Remove precision for mnemonics
Date: Wed, 15 Nov 2017 13:41:12 +0530 [thread overview]
Message-ID: <f807f61c-da67-14f2-a16c-d8ce6855703f@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171114130427.GK8836@kernel.org>
On 11/14/2017 06:34 PM, Arnaldo Carvalho de Melo wrote:
> Em Tue, Nov 14, 2017 at 08:55:40AM +0530, Ravi Bangoria escreveu:
>> There are many instructions, esp on powerpc, whose mnemonics are
>> longer than 6 characters. Using precision limit causes truncation
>> of such mnemonics.
>>
>> Fix this by removing precision limit. Note that, 'width' is still
>> 6, so alignment won't get affected for length <= 6.
>>
>> Before:
>>
>> li r11,-1
>> xscvdp vs1,vs1
>> add. r10,r10,r11
>>
>> After:
>>
>> li r11,-1
>> xscvdpsxds vs1,vs1
>> add. r10,r10,r11
> Ok, this improves the situation, as we stop truncating info, but I think
> that we should look for the longest instruction name and then use that
> to align the operands, will add that to my todo list if nobody does it
> first :-)
Hmm.. I could see longest one of 15 characters (f.e. AESKEYGENASSIST)
by a quick glance over list of instructions for x86 and powerpc. Need
to check for other archs.
> Thanks, applied.
Thanks,
Ravi
next prev parent reply other threads:[~2017-11-15 8:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 3:25 [PATCH] perf annotate: Remove precision for mnemonics Ravi Bangoria
2017-11-14 13:04 ` Arnaldo Carvalho de Melo
2017-11-15 8:11 ` Ravi Bangoria [this message]
2017-11-18 8:32 ` [tip:perf/core] perf annotate: Do not truncate instruction names at 6 chars tip-bot for Ravi Bangoria
2017-11-29 6:31 ` tip-bot for Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f807f61c-da67-14f2-a16c-d8ce6855703f@linux.vnet.ibm.com \
--to=ravi.bangoria@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=dstence@us.ibm.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=treeze.taeung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).