From: "Thomas Hellström (VMware)" <thomas_os@shipmail.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: dri-devel@lists.freedesktop.org, pv-drivers@vmware.com,
linux-graphics-maintainer@vmware.com,
linux-kernel@vger.kernel.org,
"Thomas Hellstrom" <thellstrom@vmware.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Andy Lutomirski" <luto@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"Heiko Carstens" <heiko.carstens@de.ibm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH v2 1/4] x86/mm: Export force_dma_unencrypted
Date: Tue, 3 Sep 2019 16:32:45 +0200 [thread overview]
Message-ID: <f85e7fa6-54e1-7ac5-ce6c-96349c7af322@shipmail.org> (raw)
In-Reply-To: <20190903134627.GA2951@infradead.org>
Hi, Christoph,
On 9/3/19 3:46 PM, Christoph Hellwig wrote:
> On Tue, Sep 03, 2019 at 03:15:01PM +0200, Thomas Hellström (VMware) wrote:
>> From: Thomas Hellstrom <thellstrom@vmware.com>
>>
>> The force_dma_unencrypted symbol is needed by TTM to set up the correct
>> page protection when memory encryption is active. Export it.
> NAK. This is a helper for the core DMA code and drivers have no
> business looking at it.
Is this a layer violation concern, that is, would you be ok with a
similar helper for TTM, or is it that you want to force the graphics
drivers into adhering strictly to the DMA api, even when it from an
engineering perspective makes no sense?
If it's the latter, then I would like to reiterate that it would be
better that we work to come up with a long term plan to add what's
missing to the DMA api to help graphics drivers use coherent memory?
Thanks,
Thomas
next prev parent reply other threads:[~2019-09-03 14:33 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 13:15 [PATCH v2 0/4] Have TTM support SEV encryption with coherent memory Thomas Hellström (VMware)
2019-09-03 13:15 ` [PATCH v2 1/4] x86/mm: Export force_dma_unencrypted Thomas Hellström (VMware)
2019-09-03 13:46 ` Christoph Hellwig
2019-09-03 14:32 ` Thomas Hellström (VMware) [this message]
2019-09-03 16:22 ` Christoph Hellwig
2019-09-03 20:46 ` Thomas Hellström (VMware)
2019-09-03 21:41 ` Andy Lutomirski
2019-09-04 6:58 ` Christoph Hellwig
2019-09-04 7:32 ` Thomas Hellström (VMware)
2019-09-04 12:22 ` Christoph Hellwig
2019-09-04 17:28 ` Thomas Hellström (VMware)
2019-09-03 15:14 ` Dave Hansen
2019-09-03 18:50 ` Thomas Hellström (VMware)
2019-09-03 13:15 ` [PATCH v2 2/4] s390/mm: " Thomas Hellström (VMware)
2019-09-03 13:46 ` Christoph Hellwig
2019-09-03 13:15 ` [PATCH v2 3/4] drm/ttm, drm/vmwgfx: Correctly support support AMD memory encryption Thomas Hellström (VMware)
2019-09-03 19:38 ` Dave Hansen
2019-09-03 19:51 ` Daniel Vetter
2019-09-03 19:55 ` Dave Hansen
2019-09-03 20:36 ` Thomas Hellström (VMware)
2019-09-03 20:51 ` Dave Hansen
2019-09-03 21:05 ` Thomas Hellström (VMware)
2019-09-03 21:46 ` Andy Lutomirski
2019-09-03 22:08 ` Thomas Hellström (VMware)
2019-09-03 22:15 ` Thomas Hellström (VMware)
2019-09-03 23:10 ` Dave Hansen
2019-09-04 8:34 ` Thomas Hellström (VMware)
2019-09-03 23:15 ` Andy Lutomirski
2019-09-04 6:49 ` Thomas Hellström (VMware)
2019-09-04 7:53 ` Daniel Vetter
2019-09-04 10:37 ` Thomas Hellström (VMware)
2019-09-04 11:43 ` Daniel Vetter
2019-09-04 18:16 ` Christoph Hellwig
2019-09-04 7:33 ` Koenig, Christian
2019-09-04 8:19 ` Thomas Hellström (VMware)
2019-09-04 8:42 ` Thomas Hellström (VMware)
2019-09-04 11:10 ` Koenig, Christian
2019-09-04 12:35 ` Thomas Hellström (VMware)
2019-09-04 13:05 ` Thomas Hellström (VMware)
2019-09-03 13:15 ` [PATCH v2 4/4] drm/ttm: Cache dma pool decrypted pages when AMD SEV is active Thomas Hellström (VMware)
2019-09-03 15:18 ` [PATCH v2 0/4] Have TTM support SEV encryption with coherent memory Daniel Vetter
2019-09-05 10:43 ` Thomas Hellström (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f85e7fa6-54e1-7ac5-ce6c-96349c7af322@shipmail.org \
--to=thomas_os@shipmail.org \
--cc=borntraeger@de.ibm.com \
--cc=bp@alien8.de \
--cc=christian.koenig@amd.com \
--cc=dave.hansen@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@infradead.org \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pv-drivers@vmware.com \
--cc=tglx@linutronix.de \
--cc=thellstrom@vmware.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).