[PATCH v4] integrity: check the return value of audit_log_start()

* [PATCH v4] integrity: check the return value of audit_log_start()
@ 2022-01-27  1:59 Xiaoke Wang
  2022-01-27  2:19 ` Mimi Zohar
  0 siblings, 1 reply; 2+ messages in thread
From: Xiaoke Wang @ 2022-01-27  1:59 UTC (permalink / raw)
  To: Mimi Zohar
  Cc: paul, jmorris, serge, linux-integrity, linux-security-module,
	linux-kernel

From: Xiaoke Wang <xkernel.wang@foxmail.com>

audit_log_start() returns audit_buffer pointer on success or NULL on
error, so it is better to check the return value of it.

Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
Reviewed-by: Paul Moore <paul@paul-moore.com>
---
Changelogs:
V3 -> V4: update the mail list.
V2 -> V3: add the Reviewed-by tag.
V1 -> V2: simplify the patch.
security/integrity/integrity_audit.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/security/integrity/integrity_audit.c b/security/integrity/integrity_audit.c
index 2922005..0ec5e4c 100644
--- a/security/integrity/integrity_audit.c
+++ b/security/integrity/integrity_audit.c
@@ -45,6 +45,8 @@ void integrity_audit_message(int audit_msgno, struct inode *inode,
 		return;
 
 	ab = audit_log_start(audit_context(), GFP_KERNEL, audit_msgno);
+	if (!ab)
+		return;
 	audit_log_format(ab, "pid=%d uid=%u auid=%u ses=%u",
 			 task_pid_nr(current),
 			 from_kuid(&init_user_ns, current_uid()),
--

^ permalink raw reply related	[flat|nested] 2+ messages in thread