* [PATCH] dts: arm64/sdm845: Add clocks to WCN3990 WLAN module device node
@ 2019-01-19 0:00 Douglas Anderson
2019-01-31 5:14 ` [PATCH v2] arm64: dts: qcom: sdm845: Add clocks and iommus to WCN3990 WLAN node Bjorn Andersson
0 siblings, 1 reply; 3+ messages in thread
From: Douglas Anderson @ 2019-01-19 0:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson
Cc: Govind Singh, Brian Norris, Douglas Anderson, devicetree,
linux-arm-msm, linux-kernel, Rob Herring, David Brown,
Mark Rutland
When commit be7019103469 ("dts: arm64/sdm845: Add WCN3990 WLAN module
device node") was posted upstream no clocks were specified. However,
when the pack was picked into the Chrome OS kernel tree (allegedly
directly from the mailing list post) it had clock properties.
I presume that the clock should be there, so let's add it.
Fixes: be7019103469 ("dts: arm64/sdm845: Add WCN3990 WLAN module device node")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index e4156ea320aa..f99424fc4df2 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -2211,6 +2211,8 @@
reg = <0 0x18800000 0 0x800000>;
reg-names = "membase";
memory-region = <&wlan_msa_mem>;
+ clock-names = "cxo_ref_clk_pin";
+ clocks = <&rpmhcc RPMH_RF_CLK2>;
interrupts =
<GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 415 IRQ_TYPE_LEVEL_HIGH>,
--
2.20.1.321.g9e740568ce-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2] arm64: dts: qcom: sdm845: Add clocks and iommus to WCN3990 WLAN node
2019-01-19 0:00 [PATCH] dts: arm64/sdm845: Add clocks to WCN3990 WLAN module device node Douglas Anderson
@ 2019-01-31 5:14 ` Bjorn Andersson
2019-02-01 8:57 ` Sibi Sankar
0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Andersson @ 2019-01-31 5:14 UTC (permalink / raw)
To: Andy Gross, David Brown, Douglas Anderson
Cc: Rob Herring, Mark Rutland, linux-arm-msm, devicetree, linux-kernel
From: Douglas Anderson <dianders@chromium.org>
When commit be7019103469 ("dts: arm64/sdm845: Add WCN3990 WLAN module
device node") was posted upstream no clocks were specified. However,
when the pack was picked into the Chrome OS kernel tree (allegedly
directly from the mailing list post) it had clock properties.
I presume that the clock should be there, so let's add it.
Fixes: be7019103469 ("dts: arm64/sdm845: Add WCN3990 WLAN module device node")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
[bjorn: Add also the required iommus property]
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
Hijacking Doug's fixup patch to also add the missing iommus property. Without
this the MTP reboots once the ath10k is trying to exercise the copyengine.
arch/arm64/boot/dts/qcom/sdm845.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index cba09899282e..58f034664336 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -2422,6 +2422,8 @@
reg = <0 0x18800000 0 0x800000>;
reg-names = "membase";
memory-region = <&wlan_msa_mem>;
+ clock-names = "cxo_ref_clk_pin";
+ clocks = <&rpmhcc RPMH_RF_CLK2>;
interrupts =
<GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 415 IRQ_TYPE_LEVEL_HIGH>,
@@ -2435,6 +2437,7 @@
<GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>;
+ iommus = <&apps_smmu 0x0040 0x1>;
};
};
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sdm845: Add clocks and iommus to WCN3990 WLAN node
2019-01-31 5:14 ` [PATCH v2] arm64: dts: qcom: sdm845: Add clocks and iommus to WCN3990 WLAN node Bjorn Andersson
@ 2019-02-01 8:57 ` Sibi Sankar
0 siblings, 0 replies; 3+ messages in thread
From: Sibi Sankar @ 2019-02-01 8:57 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andy Gross, David Brown, Douglas Anderson, Rob Herring,
Mark Rutland, linux-arm-msm, devicetree, linux-kernel,
linux-arm-msm-owner
On 2019-01-31 10:44, Bjorn Andersson wrote:
> From: Douglas Anderson <dianders@chromium.org>
>
> When commit be7019103469 ("dts: arm64/sdm845: Add WCN3990 WLAN module
> device node") was posted upstream no clocks were specified. However,
> when the pack was picked into the Chrome OS kernel tree (allegedly
> directly from the mailing list post) it had clock properties.
>
> I presume that the clock should be there, so let's add it.
Tested-by: Sibi Sankar <sibis@codeaurora.org>
>
> Fixes: be7019103469 ("dts: arm64/sdm845: Add WCN3990 WLAN module device
> node")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> [bjorn: Add also the required iommus property]
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>
> Hijacking Doug's fixup patch to also add the missing iommus property.
> Without
> this the MTP reboots once the ath10k is trying to exercise the
> copyengine.
>
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index cba09899282e..58f034664336 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -2422,6 +2422,8 @@
> reg = <0 0x18800000 0 0x800000>;
> reg-names = "membase";
> memory-region = <&wlan_msa_mem>;
> + clock-names = "cxo_ref_clk_pin";
> + clocks = <&rpmhcc RPMH_RF_CLK2>;
> interrupts =
> <GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 415 IRQ_TYPE_LEVEL_HIGH>,
> @@ -2435,6 +2437,7 @@
> <GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>;
> + iommus = <&apps_smmu 0x0040 0x1>;
> };
> };
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-01 8:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-19 0:00 [PATCH] dts: arm64/sdm845: Add clocks to WCN3990 WLAN module device node Douglas Anderson
2019-01-31 5:14 ` [PATCH v2] arm64: dts: qcom: sdm845: Add clocks and iommus to WCN3990 WLAN node Bjorn Andersson
2019-02-01 8:57 ` Sibi Sankar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).