* [PATCH -next] xen/pvcalls: remove set but not used variable 'intf'
@ 2019-01-04 6:03 YueHaibing
2019-01-04 16:10 ` Boris Ostrovsky
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-01-04 6:03 UTC (permalink / raw)
To: Boris Ostrovsky, Juergen Gross, Stefano Stabellini
Cc: YueHaibing, xen-devel, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/xen/pvcalls-back.c: In function 'pvcalls_sk_state_change':
drivers/xen/pvcalls-back.c:286:28: warning:
variable 'intf' set but not used [-Wunused-but-set-variable]
It not used since e6587cdbd732 ("pvcalls-back: set -ENOTCONN in
pvcalls_conn_back_read")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/xen/pvcalls-back.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index 71b6287..7aa64d1 100644
--- a/drivers/xen/pvcalls-back.c
+++ b/drivers/xen/pvcalls-back.c
@@ -283,12 +283,10 @@ static int pvcalls_back_socket(struct xenbus_device *dev,
static void pvcalls_sk_state_change(struct sock *sock)
{
struct sock_mapping *map = sock->sk_user_data;
- struct pvcalls_data_intf *intf;
if (map == NULL)
return;
- intf = map->ring;
atomic_inc(&map->read);
notify_remote_via_irq(map->irq);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] xen/pvcalls: remove set but not used variable 'intf'
2019-01-04 6:03 [PATCH -next] xen/pvcalls: remove set but not used variable 'intf' YueHaibing
@ 2019-01-04 16:10 ` Boris Ostrovsky
0 siblings, 0 replies; 2+ messages in thread
From: Boris Ostrovsky @ 2019-01-04 16:10 UTC (permalink / raw)
To: YueHaibing, Juergen Gross, Stefano Stabellini
Cc: xen-devel, linux-kernel, kernel-janitors
On 1/4/19 1:03 AM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/xen/pvcalls-back.c: In function 'pvcalls_sk_state_change':
> drivers/xen/pvcalls-back.c:286:28: warning:
> variable 'intf' set but not used [-Wunused-but-set-variable]
>
> It not used since e6587cdbd732 ("pvcalls-back: set -ENOTCONN in
> pvcalls_conn_back_read")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
and applied to for-linus-4.21.
Thanks.
-boris
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-04 16:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-04 6:03 [PATCH -next] xen/pvcalls: remove set but not used variable 'intf' YueHaibing
2019-01-04 16:10 ` Boris Ostrovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).