* [PATCH v2 08/27] i2c: busses: remove memset after dmam_alloc_coherent
@ 2019-06-28 2:47 Fuqian Huang
2019-06-28 6:22 ` Jarkko Nikula
0 siblings, 1 reply; 3+ messages in thread
From: Fuqian Huang @ 2019-06-28 2:47 UTC (permalink / raw)
Cc: Fuqian Huang, Seth Heasley, Neil Horman, Jarkko Nikula,
Wolfram Sang, linux-i2c, linux-kernel
In commit af7ddd8a627c
("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
dmam_alloc_coherent has already zeroed the memory.
So memset is not needed.
Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
---
drivers/i2c/busses/i2c-ismt.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
index 02d23edb2fb1..2f95e25a10f7 100644
--- a/drivers/i2c/busses/i2c-ismt.c
+++ b/drivers/i2c/busses/i2c-ismt.c
@@ -781,8 +781,6 @@ static int ismt_dev_init(struct ismt_priv *priv)
if (!priv->hw)
return -ENOMEM;
- memset(priv->hw, 0, (ISMT_DESC_ENTRIES * sizeof(struct ismt_desc)));
-
priv->head = 0;
init_completion(&priv->cmp);
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 08/27] i2c: busses: remove memset after dmam_alloc_coherent
2019-06-28 2:47 [PATCH v2 08/27] i2c: busses: remove memset after dmam_alloc_coherent Fuqian Huang
@ 2019-06-28 6:22 ` Jarkko Nikula
2019-06-29 11:12 ` Wolfram Sang
0 siblings, 1 reply; 3+ messages in thread
From: Jarkko Nikula @ 2019-06-28 6:22 UTC (permalink / raw)
To: Fuqian Huang
Cc: Seth Heasley, Neil Horman, Wolfram Sang, linux-i2c, linux-kernel
Hi
On 6/28/19 5:47 AM, Fuqian Huang wrote:
> In commit af7ddd8a627c
> ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
> dmam_alloc_coherent has already zeroed the memory.
> So memset is not needed.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> ---
> drivers/i2c/busses/i2c-ismt.c | 2 --
> 1 file changed, 2 deletions(-)
>
It would be better to refer actual commit or commits that implement that
zeroing rather than merge point in commit log if possible.
At quick look commit 518a2f1925c3 ("dma-mapping: zero memory returned
from dma_alloc_*") is the one but I'm not really an expert here to say
is that alone enough.
--
Jarkko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 08/27] i2c: busses: remove memset after dmam_alloc_coherent
2019-06-28 6:22 ` Jarkko Nikula
@ 2019-06-29 11:12 ` Wolfram Sang
0 siblings, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2019-06-29 11:12 UTC (permalink / raw)
To: Jarkko Nikula
Cc: Fuqian Huang, Seth Heasley, Neil Horman, linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]
On Fri, Jun 28, 2019 at 09:22:31AM +0300, Jarkko Nikula wrote:
> Hi
>
> On 6/28/19 5:47 AM, Fuqian Huang wrote:
> > In commit af7ddd8a627c
> > ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
> > dmam_alloc_coherent has already zeroed the memory.
> > So memset is not needed.
> >
> > Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> > ---
> > drivers/i2c/busses/i2c-ismt.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> It would be better to refer actual commit or commits that implement that
> zeroing rather than merge point in commit log if possible.
>
> At quick look commit 518a2f1925c3 ("dma-mapping: zero memory returned from
> dma_alloc_*") is the one but I'm not really an expert here to say is that
> alone enough.
Fuqian, can you clarify if the commit pointed by Jarkko is enough as a
reference or if it really needs the merge tag?
Also, please include the tags you collected in v1 when sending v2 (and
there was no significant code change).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-29 11:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-28 2:47 [PATCH v2 08/27] i2c: busses: remove memset after dmam_alloc_coherent Fuqian Huang
2019-06-28 6:22 ` Jarkko Nikula
2019-06-29 11:12 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).