* [PATCH] spi: bcm2835: don't print error on clk_get() DEFER
@ 2019-12-12 23:12 Jim Quinlan
2019-12-12 23:18 ` Florian Fainelli
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jim Quinlan @ 2019-12-12 23:12 UTC (permalink / raw)
To: linux-spi
Cc: Mark Brown, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Nicolas Saenz Julienne,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, Jim Quinlan
Otherwise one may get multiple error messages for normal
operation of a clock provider.
Signed-off-by: Jim Quinlan <jquinlan@broadcom.com>
---
drivers/spi/spi-bcm2835.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-bcm2835.c b/drivers/spi/spi-bcm2835.c
index fb61a620effc..6c9addc9f276 100644
--- a/drivers/spi/spi-bcm2835.c
+++ b/drivers/spi/spi-bcm2835.c
@@ -1305,7 +1305,8 @@ static int bcm2835_spi_probe(struct platform_device *pdev)
bs->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(bs->clk)) {
err = PTR_ERR(bs->clk);
- dev_err(&pdev->dev, "could not get clk: %d\n", err);
+ if (err != -EPROBE_DEFER)
+ dev_err(&pdev->dev, "could not get clk: %d\n", err);
goto out_controller_put;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] spi: bcm2835: don't print error on clk_get() DEFER
2019-12-12 23:12 [PATCH] spi: bcm2835: don't print error on clk_get() DEFER Jim Quinlan
@ 2019-12-12 23:18 ` Florian Fainelli
2019-12-13 7:54 ` Nicolas Saenz Julienne
2019-12-13 11:41 ` Mark Brown
2 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2019-12-12 23:18 UTC (permalink / raw)
To: Jim Quinlan, linux-spi
Cc: Mark Brown, Ray Jui, Scott Branden, bcm-kernel-feedback-list,
Nicolas Saenz Julienne, linux-rpi-kernel, linux-arm-kernel,
linux-kernel
On 12/12/19 3:12 PM, Jim Quinlan wrote:
> Otherwise one may get multiple error messages for normal
> operation of a clock provider.
>
> Signed-off-by: Jim Quinlan <jquinlan@broadcom.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] spi: bcm2835: don't print error on clk_get() DEFER
2019-12-12 23:12 [PATCH] spi: bcm2835: don't print error on clk_get() DEFER Jim Quinlan
2019-12-12 23:18 ` Florian Fainelli
@ 2019-12-13 7:54 ` Nicolas Saenz Julienne
2019-12-13 11:41 ` Mark Brown
2 siblings, 0 replies; 6+ messages in thread
From: Nicolas Saenz Julienne @ 2019-12-13 7:54 UTC (permalink / raw)
To: Jim Quinlan, linux-spi
Cc: linux-arm-kernel, Florian Fainelli, Scott Branden, linux-kernel,
Mark Brown, bcm-kernel-feedback-list, linux-rpi-kernel, Ray Jui
[-- Attachment #1: Type: text/plain, Size: 280 bytes --]
On Thu, 2019-12-12 at 18:12 -0500, Jim Quinlan wrote:
> Otherwise one may get multiple error messages for normal
> operation of a clock provider.
>
> Signed-off-by: Jim Quinlan <jquinlan@broadcom.com>
> ---
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] spi: bcm2835: don't print error on clk_get() DEFER
2019-12-12 23:12 [PATCH] spi: bcm2835: don't print error on clk_get() DEFER Jim Quinlan
2019-12-12 23:18 ` Florian Fainelli
2019-12-13 7:54 ` Nicolas Saenz Julienne
@ 2019-12-13 11:41 ` Mark Brown
2019-12-13 15:33 ` Jim Quinlan
2 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2019-12-13 11:41 UTC (permalink / raw)
To: Jim Quinlan
Cc: linux-spi, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Nicolas Saenz Julienne,
linux-rpi-kernel, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 551 bytes --]
On Thu, Dec 12, 2019 at 06:12:13PM -0500, Jim Quinlan wrote:
> Otherwise one may get multiple error messages for normal
> operation of a clock provider.
> if (IS_ERR(bs->clk)) {
> err = PTR_ERR(bs->clk);
> - dev_err(&pdev->dev, "could not get clk: %d\n", err);
> + if (err != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "could not get clk: %d\n", err);
On the other hand if the clock isn't there and never appears then there
won't be anything saying why the driver isn't loading which won't be
helpful when trying to figure out what's going on.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] spi: bcm2835: don't print error on clk_get() DEFER
2019-12-13 11:41 ` Mark Brown
@ 2019-12-13 15:33 ` Jim Quinlan
2019-12-16 11:20 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Jim Quinlan @ 2019-12-13 15:33 UTC (permalink / raw)
To: Mark Brown
Cc: linux-spi, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Nicolas Saenz Julienne,
linux-rpi-kernel, linux-arm-kernel, linux-kernel
On Fri, Dec 13, 2019 at 6:41 AM Mark Brown <broonie@kernel.org> wrote:
>
> On Thu, Dec 12, 2019 at 06:12:13PM -0500, Jim Quinlan wrote:
> > Otherwise one may get multiple error messages for normal
> > operation of a clock provider.
>
> > if (IS_ERR(bs->clk)) {
> > err = PTR_ERR(bs->clk);
> > - dev_err(&pdev->dev, "could not get clk: %d\n", err);
> > + if (err != -EPROBE_DEFER)
> > + dev_err(&pdev->dev, "could not get clk: %d\n", err);
>
> On the other hand if the clock isn't there and never appears then there
> won't be anything saying why the driver isn't loading which won't be
> helpful when trying to figure out what's going on.
Understood; I could do a dev_dbg() on -EPROBE_DEFER and dev_err() on
all other errors -- would that work for you?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] spi: bcm2835: don't print error on clk_get() DEFER
2019-12-13 15:33 ` Jim Quinlan
@ 2019-12-16 11:20 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2019-12-16 11:20 UTC (permalink / raw)
To: Jim Quinlan
Cc: linux-spi, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Nicolas Saenz Julienne,
linux-rpi-kernel, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 204 bytes --]
On Fri, Dec 13, 2019 at 10:33:41AM -0500, Jim Quinlan wrote:
> Understood; I could do a dev_dbg() on -EPROBE_DEFER and dev_err() on
> all other errors -- would that work for you?
Yes, that sounds good.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-16 11:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-12 23:12 [PATCH] spi: bcm2835: don't print error on clk_get() DEFER Jim Quinlan
2019-12-12 23:18 ` Florian Fainelli
2019-12-13 7:54 ` Nicolas Saenz Julienne
2019-12-13 11:41 ` Mark Brown
2019-12-13 15:33 ` Jim Quinlan
2019-12-16 11:20 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).