* [PATCH] backlight: backlight: Slighly simplify devm_of_find_backlight()
@ 2022-02-13 7:41 Christophe JAILLET
2022-03-08 10:44 ` Daniel Thompson
2022-03-08 10:48 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2022-02-13 7:41 UTC (permalink / raw)
To: Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, dri-devel,
linux-fbdev
Use devm_add_action_or_reset() instead of devm_add_action()+hand writing
what is done in the release function, should an error occur.
This is more straightforward and saves a few lines of code.
While at it, remove a useless test in devm_backlight_release(). 'data' is
known to be not NULL when this function is called.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/video/backlight/backlight.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c
index 4ae6fae94ac2..b788ff3d0f45 100644
--- a/drivers/video/backlight/backlight.c
+++ b/drivers/video/backlight/backlight.c
@@ -710,8 +710,7 @@ static void devm_backlight_release(void *data)
{
struct backlight_device *bd = data;
- if (bd)
- put_device(&bd->dev);
+ put_device(&bd->dev);
}
/**
@@ -737,11 +736,10 @@ struct backlight_device *devm_of_find_backlight(struct device *dev)
bd = of_find_backlight(dev);
if (IS_ERR_OR_NULL(bd))
return bd;
- ret = devm_add_action(dev, devm_backlight_release, bd);
- if (ret) {
- put_device(&bd->dev);
+ ret = devm_add_action_or_reset(dev, devm_backlight_release, bd);
+ if (ret)
return ERR_PTR(ret);
- }
+
return bd;
}
EXPORT_SYMBOL(devm_of_find_backlight);
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] backlight: backlight: Slighly simplify devm_of_find_backlight()
2022-02-13 7:41 [PATCH] backlight: backlight: Slighly simplify devm_of_find_backlight() Christophe JAILLET
@ 2022-03-08 10:44 ` Daniel Thompson
2022-03-08 10:48 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Thompson @ 2022-03-08 10:44 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Lee Jones, Jingoo Han, Helge Deller, linux-kernel,
kernel-janitors, dri-devel, linux-fbdev
On Sun, Feb 13, 2022 at 08:41:39AM +0100, Christophe JAILLET wrote:
> Use devm_add_action_or_reset() instead of devm_add_action()+hand writing
> what is done in the release function, should an error occur.
>
> This is more straightforward and saves a few lines of code.
>
> While at it, remove a useless test in devm_backlight_release(). 'data' is
> known to be not NULL when this function is called.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] backlight: backlight: Slighly simplify devm_of_find_backlight()
2022-02-13 7:41 [PATCH] backlight: backlight: Slighly simplify devm_of_find_backlight() Christophe JAILLET
2022-03-08 10:44 ` Daniel Thompson
@ 2022-03-08 10:48 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2022-03-08 10:48 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Daniel Thompson, Jingoo Han, Helge Deller, linux-kernel,
kernel-janitors, dri-devel, linux-fbdev
On Sun, 13 Feb 2022, Christophe JAILLET wrote:
> Use devm_add_action_or_reset() instead of devm_add_action()+hand writing
> what is done in the release function, should an error occur.
>
> This is more straightforward and saves a few lines of code.
>
> While at it, remove a useless test in devm_backlight_release(). 'data' is
> known to be not NULL when this function is called.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/video/backlight/backlight.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-08 10:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-13 7:41 [PATCH] backlight: backlight: Slighly simplify devm_of_find_backlight() Christophe JAILLET
2022-03-08 10:44 ` Daniel Thompson
2022-03-08 10:48 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).