* [PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static
@ 2017-06-13 13:14 Colin King
2017-06-14 6:08 ` Adrian Hunter
0 siblings, 1 reply; 4+ messages in thread
From: Colin King @ 2017-06-13 13:14 UTC (permalink / raw)
To: Adrian Hunter, Ulf Hansson, linux-mmc; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The guid intel_dsm_guid does not need to be in global scope, so make
it static.
Cleans up sparse warning:
"symbol 'intel_dsm_guid' was not declared. Should it be static?"
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/mmc/host/sdhci-pci-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
index 3c02c5b394d6..f1d8385d91f0 100644
--- a/drivers/mmc/host/sdhci-pci-core.c
+++ b/drivers/mmc/host/sdhci-pci-core.c
@@ -404,7 +404,7 @@ struct intel_host {
bool d3_retune;
};
-const guid_t intel_dsm_guid =
+static const guid_t intel_dsm_guid =
GUID_INIT(0xF6C13EA5, 0x65CD, 0x461F,
0xAB, 0x7A, 0x29, 0xF7, 0xE8, 0xD5, 0xBD, 0x61);
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static
2017-06-13 13:14 [PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static Colin King
@ 2017-06-14 6:08 ` Adrian Hunter
2017-06-19 10:24 ` Ulf Hansson
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Hunter @ 2017-06-14 6:08 UTC (permalink / raw)
To: Colin King, Ulf Hansson, linux-mmc, Christoph Hellwig
Cc: kernel-janitors, linux-kernel
On 13/06/17 16:14, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The guid intel_dsm_guid does not need to be in global scope, so make
> it static.
>
> Cleans up sparse warning:
> "symbol 'intel_dsm_guid' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
But this patch is dependent on the guid changes which are not in the mmc
tree. It's in a tree of Christoph's I think.
> ---
> drivers/mmc/host/sdhci-pci-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
> index 3c02c5b394d6..f1d8385d91f0 100644
> --- a/drivers/mmc/host/sdhci-pci-core.c
> +++ b/drivers/mmc/host/sdhci-pci-core.c
> @@ -404,7 +404,7 @@ struct intel_host {
> bool d3_retune;
> };
>
> -const guid_t intel_dsm_guid =
> +static const guid_t intel_dsm_guid =
> GUID_INIT(0xF6C13EA5, 0x65CD, 0x461F,
> 0xAB, 0x7A, 0x29, 0xF7, 0xE8, 0xD5, 0xBD, 0x61);
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static
2017-06-14 6:08 ` Adrian Hunter
@ 2017-06-19 10:24 ` Ulf Hansson
2017-06-19 10:25 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Ulf Hansson @ 2017-06-19 10:24 UTC (permalink / raw)
To: Adrian Hunter, Christoph Hellwig
Cc: Colin King, linux-mmc, kernel-janitors, linux-kernel
On 14 June 2017 at 08:08, Adrian Hunter <adrian.hunter@intel.com> wrote:
> On 13/06/17 16:14, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The guid intel_dsm_guid does not need to be in global scope, so make
>> it static.
>>
>> Cleans up sparse warning:
>> "symbol 'intel_dsm_guid' was not declared. Should it be static?"
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>
> But this patch is dependent on the guid changes which are not in the mmc
> tree. It's in a tree of Christoph's I think.
Right, in such case maybe Christoph can pick this up?
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
>
>> ---
>> drivers/mmc/host/sdhci-pci-core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
>> index 3c02c5b394d6..f1d8385d91f0 100644
>> --- a/drivers/mmc/host/sdhci-pci-core.c
>> +++ b/drivers/mmc/host/sdhci-pci-core.c
>> @@ -404,7 +404,7 @@ struct intel_host {
>> bool d3_retune;
>> };
>>
>> -const guid_t intel_dsm_guid =
>> +static const guid_t intel_dsm_guid =
>> GUID_INIT(0xF6C13EA5, 0x65CD, 0x461F,
>> 0xAB, 0x7A, 0x29, 0xF7, 0xE8, 0xD5, 0xBD, 0x61);
>>
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static
2017-06-19 10:24 ` Ulf Hansson
@ 2017-06-19 10:25 ` Christoph Hellwig
0 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2017-06-19 10:25 UTC (permalink / raw)
To: Ulf Hansson
Cc: Adrian Hunter, Christoph Hellwig, Colin King, linux-mmc,
kernel-janitors, linux-kernel
Please resend any patches I should pick up directly to me, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-19 10:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-13 13:14 [PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static Colin King
2017-06-14 6:08 ` Adrian Hunter
2017-06-19 10:24 ` Ulf Hansson
2017-06-19 10:25 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).