linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Baicar, Tyler" <tbaicar@codeaurora.org>
To: Sinan Kaya <okaya@codeaurora.org>,
	linux-acpi@vger.kernel.org, timur@codeaurora.org
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI / GED: use late init to allow other drivers init
Date: Mon, 24 Apr 2017 16:49:59 -0600	[thread overview]
Message-ID: <f9fd6291-8439-7add-b6b2-f7e99dcbc558@codeaurora.org> (raw)
In-Reply-To: <1492813704-32280-1-git-send-email-okaya@codeaurora.org>

On 4/21/2017 4:28 PM, Sinan Kaya wrote:
> GED driver is currently set up as a platform driver. On modern operating
> systems, most of the drivers are compiled as kernel modules. It is possible
> that a GED interrupt event is received and the driver such as GHES/GPIO/I2C
> to service it is not available yet. To accommodate this use case, delay
> GED driver load to the late init phase.
>
> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Tested-by: Tyler Baicar <tbaicar@codeaurora.org>

This resolves the GHES issue described here: 
https://lkml.org/lkml/2017/3/28/1083

Thanks,
Tyler
> ---
>   drivers/acpi/evged.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/evged.c b/drivers/acpi/evged.c
> index 46f0603..30e638b 100644
> --- a/drivers/acpi/evged.c
> +++ b/drivers/acpi/evged.c
> @@ -151,4 +151,10 @@ static int ged_probe(struct platform_device *pdev)
>   		.acpi_match_table = ACPI_PTR(ged_acpi_ids),
>   	},
>   };
> -builtin_platform_driver(ged_driver);
> +
> +static __init int ged_init(void)
> +{
> +	return platform_driver_register(&ged_driver);
> +}
> +
> +late_initcall(ged_init);

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.

      parent reply	other threads:[~2017-04-24 22:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-21 22:28 [PATCH] ACPI / GED: use late init to allow other drivers init Sinan Kaya
2017-04-21 22:43 ` Rafael J. Wysocki
2017-04-21 22:48   ` Sinan Kaya
2017-04-21 22:48     ` Sinan Kaya
2017-04-24 23:01     ` Rafael J. Wysocki
2017-04-24 23:33       ` Sinan Kaya
2017-04-25  7:01         ` Lukas Wunner
2017-04-25 16:24           ` Sinan Kaya
2017-04-28  2:32             ` Sinan Kaya
2017-05-11  0:58               ` Rafael J. Wysocki
2017-05-11  1:38                 ` Sinan Kaya
2017-05-11  0:46             ` Rafael J. Wysocki
2017-05-11 13:43               ` Sinan Kaya
2017-05-11 14:52                 ` Rafael J. Wysocki
2017-05-15  2:36                   ` Sinan Kaya
2017-05-15 10:59                     ` Rafael J. Wysocki
2017-05-21 15:51                       ` Sinan Kaya
2017-04-25  1:43       ` Sinan Kaya
2017-04-25 11:03         ` Rafael J. Wysocki
2017-04-25 16:25           ` Sinan Kaya
2017-04-24 22:49 ` Baicar, Tyler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9fd6291-8439-7add-b6b2-f7e99dcbc558@codeaurora.org \
    --to=tbaicar@codeaurora.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=okaya@codeaurora.org \
    --cc=rjw@rjwysocki.net \
    --cc=timur@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).