[PATCHv2 1/2] PM / devfreq: Remove unneeded extern keyword

[PATCHv2 1/2] PM / devfreq: Remove unneeded extern keyword

[Chanwoo Choi]

Remove unneeded extern keyword from devfreq-related header file
and adjust the indentation of function parameter to keep the
consistency in header file

Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
Changes from v1:
- Add reviewed tag of Lukasz

 drivers/devfreq/governor.h |  17 +++----
 include/linux/devfreq.h    | 100 ++++++++++++++++++-------------------
 2 files changed, 57 insertions(+), 60 deletions(-)

diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h
index dc7533ccc3db..5ba3e051b1d0 100644
--- a/drivers/devfreq/governor.h
+++ b/drivers/devfreq/governor.h
@@ -57,17 +57,16 @@ struct devfreq_governor {
 				unsigned int event, void *data);
 };
 
-extern void devfreq_monitor_start(struct devfreq *devfreq);
-extern void devfreq_monitor_stop(struct devfreq *devfreq);
-extern void devfreq_monitor_suspend(struct devfreq *devfreq);
-extern void devfreq_monitor_resume(struct devfreq *devfreq);
-extern void devfreq_interval_update(struct devfreq *devfreq,
-					unsigned int *delay);
+void devfreq_monitor_start(struct devfreq *devfreq);
+void devfreq_monitor_stop(struct devfreq *devfreq);
+void devfreq_monitor_suspend(struct devfreq *devfreq);
+void devfreq_monitor_resume(struct devfreq *devfreq);
+void devfreq_interval_update(struct devfreq *devfreq, unsigned int *delay);
 
-extern int devfreq_add_governor(struct devfreq_governor *governor);
-extern int devfreq_remove_governor(struct devfreq_governor *governor);
+int devfreq_add_governor(struct devfreq_governor *governor);
+int devfreq_remove_governor(struct devfreq_governor *governor);
 
-extern int devfreq_update_status(struct devfreq *devfreq, unsigned long freq);
+int devfreq_update_status(struct devfreq *devfreq, unsigned long freq);
 
 static inline int devfreq_update_stats(struct devfreq *df)
 {
diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h
index c6f82d4bec9f..82630fafacde 100644
--- a/include/linux/devfreq.h
+++ b/include/linux/devfreq.h
@@ -201,24 +201,23 @@ struct devfreq_freqs {
 };
 
 #if defined(CONFIG_PM_DEVFREQ)
-extern struct devfreq *devfreq_add_device(struct device *dev,
-				  struct devfreq_dev_profile *profile,
-				  const char *governor_name,
-				  void *data);
-extern int devfreq_remove_device(struct devfreq *devfreq);
-extern struct devfreq *devm_devfreq_add_device(struct device *dev,
-				  struct devfreq_dev_profile *profile,
-				  const char *governor_name,
-				  void *data);
-extern void devm_devfreq_remove_device(struct device *dev,
-				  struct devfreq *devfreq);
+struct devfreq *devfreq_add_device(struct device *dev,
+				struct devfreq_dev_profile *profile,
+				const char *governor_name,
+				void *data);
+int devfreq_remove_device(struct devfreq *devfreq);
+struct devfreq *devm_devfreq_add_device(struct device *dev,
+				struct devfreq_dev_profile *profile,
+				const char *governor_name,
+				void *data);
+void devm_devfreq_remove_device(struct device *dev, struct devfreq *devfreq);
 
 /* Supposed to be called by PM callbacks */
-extern int devfreq_suspend_device(struct devfreq *devfreq);
-extern int devfreq_resume_device(struct devfreq *devfreq);
+int devfreq_suspend_device(struct devfreq *devfreq);
+int devfreq_resume_device(struct devfreq *devfreq);
 
-extern void devfreq_suspend(void);
-extern void devfreq_resume(void);
+void devfreq_suspend(void);
+void devfreq_resume(void);
 
 /**
  * update_devfreq() - Reevaluate the device and configure frequency
@@ -226,35 +225,34 @@ extern void devfreq_resume(void);
  *
  * Note: devfreq->lock must be held
  */
-extern int update_devfreq(struct devfreq *devfreq);
+int update_devfreq(struct devfreq *devfreq);
 
 /* Helper functions for devfreq user device driver with OPP. */
-extern struct dev_pm_opp *devfreq_recommended_opp(struct device *dev,
-					   unsigned long *freq, u32 flags);
-extern int devfreq_register_opp_notifier(struct device *dev,
-					 struct devfreq *devfreq);
-extern int devfreq_unregister_opp_notifier(struct device *dev,
-					   struct devfreq *devfreq);
-extern int devm_devfreq_register_opp_notifier(struct device *dev,
-					      struct devfreq *devfreq);
-extern void devm_devfreq_unregister_opp_notifier(struct device *dev,
-						struct devfreq *devfreq);
-extern int devfreq_register_notifier(struct devfreq *devfreq,
-					struct notifier_block *nb,
-					unsigned int list);
-extern int devfreq_unregister_notifier(struct devfreq *devfreq,
-					struct notifier_block *nb,
-					unsigned int list);
-extern int devm_devfreq_register_notifier(struct device *dev,
+struct dev_pm_opp *devfreq_recommended_opp(struct device *dev,
+				unsigned long *freq, u32 flags);
+int devfreq_register_opp_notifier(struct device *dev,
+				struct devfreq *devfreq);
+int devfreq_unregister_opp_notifier(struct device *dev,
+				struct devfreq *devfreq);
+int devm_devfreq_register_opp_notifier(struct device *dev,
+				struct devfreq *devfreq);
+void devm_devfreq_unregister_opp_notifier(struct device *dev,
+				struct devfreq *devfreq);
+int devfreq_register_notifier(struct devfreq *devfreq,
+				struct notifier_block *nb,
+				unsigned int list);
+int devfreq_unregister_notifier(struct devfreq *devfreq,
+				struct notifier_block *nb,
+				unsigned int list);
+int devm_devfreq_register_notifier(struct device *dev,
 				struct devfreq *devfreq,
 				struct notifier_block *nb,
 				unsigned int list);
-extern void devm_devfreq_unregister_notifier(struct device *dev,
+void devm_devfreq_unregister_notifier(struct device *dev,
 				struct devfreq *devfreq,
 				struct notifier_block *nb,
 				unsigned int list);
-extern struct devfreq *devfreq_get_devfreq_by_phandle(struct device *dev,
-						int index);
+struct devfreq *devfreq_get_devfreq_by_phandle(struct device *dev, int index);
 
 #if IS_ENABLED(CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND)
 /**
@@ -311,9 +309,9 @@ struct devfreq_passive_data {
 
 #else /* !CONFIG_PM_DEVFREQ */
 static inline struct devfreq *devfreq_add_device(struct device *dev,
-					  struct devfreq_dev_profile *profile,
-					  const char *governor_name,
-					  void *data)
+					struct devfreq_dev_profile *profile,
+					const char *governor_name,
+					void *data)
 {
 	return ERR_PTR(-ENOSYS);
 }
@@ -350,31 +348,31 @@ static inline void devfreq_suspend(void) {}
 static inline void devfreq_resume(void) {}
 
 static inline struct dev_pm_opp *devfreq_recommended_opp(struct device *dev,
-					   unsigned long *freq, u32 flags)
+					unsigned long *freq, u32 flags)
 {
 	return ERR_PTR(-EINVAL);
 }
 
 static inline int devfreq_register_opp_notifier(struct device *dev,
-					 struct devfreq *devfreq)
+					struct devfreq *devfreq)
 {
 	return -EINVAL;
 }
 
 static inline int devfreq_unregister_opp_notifier(struct device *dev,
-					   struct devfreq *devfreq)
+					struct devfreq *devfreq)
 {
 	return -EINVAL;
 }
 
 static inline int devm_devfreq_register_opp_notifier(struct device *dev,
-						     struct devfreq *devfreq)
+					struct devfreq *devfreq)
 {
 	return -EINVAL;
 }
 
 static inline void devm_devfreq_unregister_opp_notifier(struct device *dev,
-							struct devfreq *devfreq)
+					struct devfreq *devfreq)
 {
 }
 
@@ -393,22 +391,22 @@ static inline int devfreq_unregister_notifier(struct devfreq *devfreq,
 }
 
 static inline int devm_devfreq_register_notifier(struct device *dev,
-				struct devfreq *devfreq,
-				struct notifier_block *nb,
-				unsigned int list)
+					struct devfreq *devfreq,
+					struct notifier_block *nb,
+					unsigned int list)
 {
 	return 0;
 }
 
 static inline void devm_devfreq_unregister_notifier(struct device *dev,
-				struct devfreq *devfreq,
-				struct notifier_block *nb,
-				unsigned int list)
+					struct devfreq *devfreq,
+					struct notifier_block *nb,
+					unsigned int list)
 {
 }
 
 static inline struct devfreq *devfreq_get_devfreq_by_phandle(struct device *dev,
-							int index)
+					int index)
 {
 	return ERR_PTR(-ENODEV);
 }
-- 
2.17.1

[PATCHv2 2/2] PM / devfreq: Change to DEVFREQ_GOV_UPDATE_INTERVAL event name

[Chanwoo Choi]

DEVFREQ_GOV_INTERVAL event indicates that update the interval
for polling mode of devfreq device. But, this event name doesn't
specify exactly what to do.

Change DEVFREQ_GOV_INTERVAL event name to DEVFREQ_GOV_UPDATE_INTERVAL
which specifies what to do by event name.

And modify the function name to DEVFREQ_GOV_UPDATE_INTERVAL
with 'devfreq_' prefix + verb + object as following:
- devfreq_interval_update -> devfreq_updatee_interval

Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
Changes from v1:
- Add reviewed tag of Lukasz
- Fix typo in patch description

 drivers/devfreq/devfreq.c                 | 10 +++++-----
 drivers/devfreq/governor.h                |  4 ++--
 drivers/devfreq/governor_simpleondemand.c |  4 ++--
 drivers/devfreq/tegra30-devfreq.c         |  4 ++--
 4 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index cceee8bc3c2f..8494c5f05a73 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -550,14 +550,14 @@ void devfreq_monitor_resume(struct devfreq *devfreq)
 EXPORT_SYMBOL(devfreq_monitor_resume);
 
 /**
- * devfreq_interval_update() - Update device devfreq monitoring interval
+ * devfreq_update_interval() - Update device devfreq monitoring interval
  * @devfreq:    the devfreq instance.
  * @delay:      new polling interval to be set.
  *
  * Helper function to set new load monitoring polling interval. Function
- * to be called from governor in response to DEVFREQ_GOV_INTERVAL event.
+ * to be called from governor in response to DEVFREQ_GOV_UPDATE_INTERVAL event.
  */
-void devfreq_interval_update(struct devfreq *devfreq, unsigned int *delay)
+void devfreq_update_interval(struct devfreq *devfreq, unsigned int *delay)
 {
 	unsigned int cur_delay = devfreq->profile->polling_ms;
 	unsigned int new_delay = *delay;
@@ -597,7 +597,7 @@ void devfreq_interval_update(struct devfreq *devfreq, unsigned int *delay)
 out:
 	mutex_unlock(&devfreq->lock);
 }
-EXPORT_SYMBOL(devfreq_interval_update);
+EXPORT_SYMBOL(devfreq_update_interval);
 
 /**
  * devfreq_notifier_call() - Notify that the device frequency requirements
@@ -1426,7 +1426,7 @@ static ssize_t polling_interval_store(struct device *dev,
 	if (ret != 1)
 		return -EINVAL;
 
-	df->governor->event_handler(df, DEVFREQ_GOV_INTERVAL, &value);
+	df->governor->event_handler(df, DEVFREQ_GOV_UPDATE_INTERVAL, &value);
 	ret = count;
 
 	return ret;
diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h
index 5ba3e051b1d0..c07ce77c253d 100644
--- a/drivers/devfreq/governor.h
+++ b/drivers/devfreq/governor.h
@@ -18,7 +18,7 @@
 /* Devfreq events */
 #define DEVFREQ_GOV_START			0x1
 #define DEVFREQ_GOV_STOP			0x2
-#define DEVFREQ_GOV_INTERVAL			0x3
+#define DEVFREQ_GOV_UPDATE_INTERVAL		0x3
 #define DEVFREQ_GOV_SUSPEND			0x4
 #define DEVFREQ_GOV_RESUME			0x5
 
@@ -61,7 +61,7 @@ void devfreq_monitor_start(struct devfreq *devfreq);
 void devfreq_monitor_stop(struct devfreq *devfreq);
 void devfreq_monitor_suspend(struct devfreq *devfreq);
 void devfreq_monitor_resume(struct devfreq *devfreq);
-void devfreq_interval_update(struct devfreq *devfreq, unsigned int *delay);
+void devfreq_update_interval(struct devfreq *devfreq, unsigned int *delay);
 
 int devfreq_add_governor(struct devfreq_governor *governor);
 int devfreq_remove_governor(struct devfreq_governor *governor);
diff --git a/drivers/devfreq/governor_simpleondemand.c b/drivers/devfreq/governor_simpleondemand.c
index 3d809f228619..1b314e1df028 100644
--- a/drivers/devfreq/governor_simpleondemand.c
+++ b/drivers/devfreq/governor_simpleondemand.c
@@ -96,8 +96,8 @@ static int devfreq_simple_ondemand_handler(struct devfreq *devfreq,
 		devfreq_monitor_stop(devfreq);
 		break;
 
-	case DEVFREQ_GOV_INTERVAL:
-		devfreq_interval_update(devfreq, (unsigned int *)data);
+	case DEVFREQ_GOV_UPDATE_INTERVAL:
+		devfreq_update_interval(devfreq, (unsigned int *)data);
 		break;
 
 	case DEVFREQ_GOV_SUSPEND:
diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
index 0b65f89d74d5..28b2c7ca416e 100644
--- a/drivers/devfreq/tegra30-devfreq.c
+++ b/drivers/devfreq/tegra30-devfreq.c
@@ -734,7 +734,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq,
 		devfreq_monitor_stop(devfreq);
 		break;
 
-	case DEVFREQ_GOV_INTERVAL:
+	case DEVFREQ_GOV_UPDATE_INTERVAL:
 		/*
 		 * ACTMON hardware supports up to 256 milliseconds for the
 		 * sampling period.
@@ -745,7 +745,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq,
 		}
 
 		tegra_actmon_pause(tegra);
-		devfreq_interval_update(devfreq, new_delay);
+		devfreq_update_interval(devfreq, new_delay);
 		ret = tegra_actmon_resume(tegra);
 		break;
 
-- 
2.17.1

Re: [PATCHv2 1/2] PM / devfreq: Remove unneeded extern keyword

[Chanwoo Choi]

On 2/3/20 10:17 AM, Chanwoo Choi wrote:
> Remove unneeded extern keyword from devfreq-related header file
> and adjust the indentation of function parameter to keep the
> consistency in header file
> 
> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> Changes from v1:
> - Add reviewed tag of Lukasz
> 
>  drivers/devfreq/governor.h |  17 +++----
>  include/linux/devfreq.h    | 100 ++++++++++++++++++-------------------
>  2 files changed, 57 insertions(+), 60 deletions(-)
> 
> diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h
> index dc7533ccc3db..5ba3e051b1d0 100644
> --- a/drivers/devfreq/governor.h
> +++ b/drivers/devfreq/governor.h
> @@ -57,17 +57,16 @@ struct devfreq_governor {
>  				unsigned int event, void *data);
>  };
>  
> -extern void devfreq_monitor_start(struct devfreq *devfreq);
> -extern void devfreq_monitor_stop(struct devfreq *devfreq);
> -extern void devfreq_monitor_suspend(struct devfreq *devfreq);
> -extern void devfreq_monitor_resume(struct devfreq *devfreq);
> -extern void devfreq_interval_update(struct devfreq *devfreq,
> -					unsigned int *delay);
> +void devfreq_monitor_start(struct devfreq *devfreq);
> +void devfreq_monitor_stop(struct devfreq *devfreq);
> +void devfreq_monitor_suspend(struct devfreq *devfreq);
> +void devfreq_monitor_resume(struct devfreq *devfreq);
> +void devfreq_interval_update(struct devfreq *devfreq, unsigned int *delay);
>  
> -extern int devfreq_add_governor(struct devfreq_governor *governor);
> -extern int devfreq_remove_governor(struct devfreq_governor *governor);
> +int devfreq_add_governor(struct devfreq_governor *governor);
> +int devfreq_remove_governor(struct devfreq_governor *governor);
>  
> -extern int devfreq_update_status(struct devfreq *devfreq, unsigned long freq);
> +int devfreq_update_status(struct devfreq *devfreq, unsigned long freq);
>  
>  static inline int devfreq_update_stats(struct devfreq *df)
>  {
> diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h
> index c6f82d4bec9f..82630fafacde 100644
> --- a/include/linux/devfreq.h
> +++ b/include/linux/devfreq.h
> @@ -201,24 +201,23 @@ struct devfreq_freqs {
>  };
>  
>  #if defined(CONFIG_PM_DEVFREQ)
> -extern struct devfreq *devfreq_add_device(struct device *dev,
> -				  struct devfreq_dev_profile *profile,
> -				  const char *governor_name,
> -				  void *data);
> -extern int devfreq_remove_device(struct devfreq *devfreq);
> -extern struct devfreq *devm_devfreq_add_device(struct device *dev,
> -				  struct devfreq_dev_profile *profile,
> -				  const char *governor_name,
> -				  void *data);
> -extern void devm_devfreq_remove_device(struct device *dev,
> -				  struct devfreq *devfreq);
> +struct devfreq *devfreq_add_device(struct device *dev,
> +				struct devfreq_dev_profile *profile,
> +				const char *governor_name,
> +				void *data);
> +int devfreq_remove_device(struct devfreq *devfreq);
> +struct devfreq *devm_devfreq_add_device(struct device *dev,
> +				struct devfreq_dev_profile *profile,
> +				const char *governor_name,
> +				void *data);
> +void devm_devfreq_remove_device(struct device *dev, struct devfreq *devfreq);
>  
>  /* Supposed to be called by PM callbacks */
> -extern int devfreq_suspend_device(struct devfreq *devfreq);
> -extern int devfreq_resume_device(struct devfreq *devfreq);
> +int devfreq_suspend_device(struct devfreq *devfreq);
> +int devfreq_resume_device(struct devfreq *devfreq);
>  
> -extern void devfreq_suspend(void);
> -extern void devfreq_resume(void);
> +void devfreq_suspend(void);
> +void devfreq_resume(void);
>  
>  /**
>   * update_devfreq() - Reevaluate the device and configure frequency
> @@ -226,35 +225,34 @@ extern void devfreq_resume(void);
>   *
>   * Note: devfreq->lock must be held
>   */
> -extern int update_devfreq(struct devfreq *devfreq);
> +int update_devfreq(struct devfreq *devfreq);
>  
>  /* Helper functions for devfreq user device driver with OPP. */
> -extern struct dev_pm_opp *devfreq_recommended_opp(struct device *dev,
> -					   unsigned long *freq, u32 flags);
> -extern int devfreq_register_opp_notifier(struct device *dev,
> -					 struct devfreq *devfreq);
> -extern int devfreq_unregister_opp_notifier(struct device *dev,
> -					   struct devfreq *devfreq);
> -extern int devm_devfreq_register_opp_notifier(struct device *dev,
> -					      struct devfreq *devfreq);
> -extern void devm_devfreq_unregister_opp_notifier(struct device *dev,
> -						struct devfreq *devfreq);
> -extern int devfreq_register_notifier(struct devfreq *devfreq,
> -					struct notifier_block *nb,
> -					unsigned int list);
> -extern int devfreq_unregister_notifier(struct devfreq *devfreq,
> -					struct notifier_block *nb,
> -					unsigned int list);
> -extern int devm_devfreq_register_notifier(struct device *dev,
> +struct dev_pm_opp *devfreq_recommended_opp(struct device *dev,
> +				unsigned long *freq, u32 flags);
> +int devfreq_register_opp_notifier(struct device *dev,
> +				struct devfreq *devfreq);
> +int devfreq_unregister_opp_notifier(struct device *dev,
> +				struct devfreq *devfreq);
> +int devm_devfreq_register_opp_notifier(struct device *dev,
> +				struct devfreq *devfreq);
> +void devm_devfreq_unregister_opp_notifier(struct device *dev,
> +				struct devfreq *devfreq);
> +int devfreq_register_notifier(struct devfreq *devfreq,
> +				struct notifier_block *nb,
> +				unsigned int list);
> +int devfreq_unregister_notifier(struct devfreq *devfreq,
> +				struct notifier_block *nb,
> +				unsigned int list);
> +int devm_devfreq_register_notifier(struct device *dev,
>  				struct devfreq *devfreq,
>  				struct notifier_block *nb,
>  				unsigned int list);
> -extern void devm_devfreq_unregister_notifier(struct device *dev,
> +void devm_devfreq_unregister_notifier(struct device *dev,
>  				struct devfreq *devfreq,
>  				struct notifier_block *nb,
>  				unsigned int list);
> -extern struct devfreq *devfreq_get_devfreq_by_phandle(struct device *dev,
> -						int index);
> +struct devfreq *devfreq_get_devfreq_by_phandle(struct device *dev, int index);
>  
>  #if IS_ENABLED(CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND)
>  /**
> @@ -311,9 +309,9 @@ struct devfreq_passive_data {
>  
>  #else /* !CONFIG_PM_DEVFREQ */
>  static inline struct devfreq *devfreq_add_device(struct device *dev,
> -					  struct devfreq_dev_profile *profile,
> -					  const char *governor_name,
> -					  void *data)
> +					struct devfreq_dev_profile *profile,
> +					const char *governor_name,
> +					void *data)
>  {
>  	return ERR_PTR(-ENOSYS);
>  }
> @@ -350,31 +348,31 @@ static inline void devfreq_suspend(void) {}
>  static inline void devfreq_resume(void) {}
>  
>  static inline struct dev_pm_opp *devfreq_recommended_opp(struct device *dev,
> -					   unsigned long *freq, u32 flags)
> +					unsigned long *freq, u32 flags)
>  {
>  	return ERR_PTR(-EINVAL);
>  }
>  
>  static inline int devfreq_register_opp_notifier(struct device *dev,
> -					 struct devfreq *devfreq)
> +					struct devfreq *devfreq)
>  {
>  	return -EINVAL;
>  }
>  
>  static inline int devfreq_unregister_opp_notifier(struct device *dev,
> -					   struct devfreq *devfreq)
> +					struct devfreq *devfreq)
>  {
>  	return -EINVAL;
>  }
>  
>  static inline int devm_devfreq_register_opp_notifier(struct device *dev,
> -						     struct devfreq *devfreq)
> +					struct devfreq *devfreq)
>  {
>  	return -EINVAL;
>  }
>  
>  static inline void devm_devfreq_unregister_opp_notifier(struct device *dev,
> -							struct devfreq *devfreq)
> +					struct devfreq *devfreq)
>  {
>  }
>  
> @@ -393,22 +391,22 @@ static inline int devfreq_unregister_notifier(struct devfreq *devfreq,
>  }
>  
>  static inline int devm_devfreq_register_notifier(struct device *dev,
> -				struct devfreq *devfreq,
> -				struct notifier_block *nb,
> -				unsigned int list)
> +					struct devfreq *devfreq,
> +					struct notifier_block *nb,
> +					unsigned int list)
>  {
>  	return 0;
>  }
>  
>  static inline void devm_devfreq_unregister_notifier(struct device *dev,
> -				struct devfreq *devfreq,
> -				struct notifier_block *nb,
> -				unsigned int list)
> +					struct devfreq *devfreq,
> +					struct notifier_block *nb,
> +					unsigned int list)
>  {
>  }
>  
>  static inline struct devfreq *devfreq_get_devfreq_by_phandle(struct device *dev,
> -							int index)
> +					int index)
>  {
>  	return ERR_PTR(-ENODEV);
>  }
> 

Applied it. Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

Re: [PATCHv2 2/2] PM / devfreq: Change to DEVFREQ_GOV_UPDATE_INTERVAL event name

[Chanwoo Choi]

On 2/3/20 10:17 AM, Chanwoo Choi wrote:
> DEVFREQ_GOV_INTERVAL event indicates that update the interval
> for polling mode of devfreq device. But, this event name doesn't
> specify exactly what to do.
> 
> Change DEVFREQ_GOV_INTERVAL event name to DEVFREQ_GOV_UPDATE_INTERVAL
> which specifies what to do by event name.
> 
> And modify the function name to DEVFREQ_GOV_UPDATE_INTERVAL
> with 'devfreq_' prefix + verb + object as following:
> - devfreq_interval_update -> devfreq_updatee_interval
> 
> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> Changes from v1:
> - Add reviewed tag of Lukasz
> - Fix typo in patch description
> 
>  drivers/devfreq/devfreq.c                 | 10 +++++-----
>  drivers/devfreq/governor.h                |  4 ++--
>  drivers/devfreq/governor_simpleondemand.c |  4 ++--
>  drivers/devfreq/tegra30-devfreq.c         |  4 ++--
>  4 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index cceee8bc3c2f..8494c5f05a73 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -550,14 +550,14 @@ void devfreq_monitor_resume(struct devfreq *devfreq)
>  EXPORT_SYMBOL(devfreq_monitor_resume);
>  
>  /**
> - * devfreq_interval_update() - Update device devfreq monitoring interval
> + * devfreq_update_interval() - Update device devfreq monitoring interval
>   * @devfreq:    the devfreq instance.
>   * @delay:      new polling interval to be set.
>   *
>   * Helper function to set new load monitoring polling interval. Function
> - * to be called from governor in response to DEVFREQ_GOV_INTERVAL event.
> + * to be called from governor in response to DEVFREQ_GOV_UPDATE_INTERVAL event.
>   */
> -void devfreq_interval_update(struct devfreq *devfreq, unsigned int *delay)
> +void devfreq_update_interval(struct devfreq *devfreq, unsigned int *delay)
>  {
>  	unsigned int cur_delay = devfreq->profile->polling_ms;
>  	unsigned int new_delay = *delay;
> @@ -597,7 +597,7 @@ void devfreq_interval_update(struct devfreq *devfreq, unsigned int *delay)
>  out:
>  	mutex_unlock(&devfreq->lock);
>  }
> -EXPORT_SYMBOL(devfreq_interval_update);
> +EXPORT_SYMBOL(devfreq_update_interval);
>  
>  /**
>   * devfreq_notifier_call() - Notify that the device frequency requirements
> @@ -1426,7 +1426,7 @@ static ssize_t polling_interval_store(struct device *dev,
>  	if (ret != 1)
>  		return -EINVAL;
>  
> -	df->governor->event_handler(df, DEVFREQ_GOV_INTERVAL, &value);
> +	df->governor->event_handler(df, DEVFREQ_GOV_UPDATE_INTERVAL, &value);
>  	ret = count;
>  
>  	return ret;
> diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h
> index 5ba3e051b1d0..c07ce77c253d 100644
> --- a/drivers/devfreq/governor.h
> +++ b/drivers/devfreq/governor.h
> @@ -18,7 +18,7 @@
>  /* Devfreq events */
>  #define DEVFREQ_GOV_START			0x1
>  #define DEVFREQ_GOV_STOP			0x2
> -#define DEVFREQ_GOV_INTERVAL			0x3
> +#define DEVFREQ_GOV_UPDATE_INTERVAL		0x3
>  #define DEVFREQ_GOV_SUSPEND			0x4
>  #define DEVFREQ_GOV_RESUME			0x5
>  
> @@ -61,7 +61,7 @@ void devfreq_monitor_start(struct devfreq *devfreq);
>  void devfreq_monitor_stop(struct devfreq *devfreq);
>  void devfreq_monitor_suspend(struct devfreq *devfreq);
>  void devfreq_monitor_resume(struct devfreq *devfreq);
> -void devfreq_interval_update(struct devfreq *devfreq, unsigned int *delay);
> +void devfreq_update_interval(struct devfreq *devfreq, unsigned int *delay);
>  
>  int devfreq_add_governor(struct devfreq_governor *governor);
>  int devfreq_remove_governor(struct devfreq_governor *governor);
> diff --git a/drivers/devfreq/governor_simpleondemand.c b/drivers/devfreq/governor_simpleondemand.c
> index 3d809f228619..1b314e1df028 100644
> --- a/drivers/devfreq/governor_simpleondemand.c
> +++ b/drivers/devfreq/governor_simpleondemand.c
> @@ -96,8 +96,8 @@ static int devfreq_simple_ondemand_handler(struct devfreq *devfreq,
>  		devfreq_monitor_stop(devfreq);
>  		break;
>  
> -	case DEVFREQ_GOV_INTERVAL:
> -		devfreq_interval_update(devfreq, (unsigned int *)data);
> +	case DEVFREQ_GOV_UPDATE_INTERVAL:
> +		devfreq_update_interval(devfreq, (unsigned int *)data);
>  		break;
>  
>  	case DEVFREQ_GOV_SUSPEND:
> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
> index 0b65f89d74d5..28b2c7ca416e 100644
> --- a/drivers/devfreq/tegra30-devfreq.c
> +++ b/drivers/devfreq/tegra30-devfreq.c
> @@ -734,7 +734,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq,
>  		devfreq_monitor_stop(devfreq);
>  		break;
>  
> -	case DEVFREQ_GOV_INTERVAL:
> +	case DEVFREQ_GOV_UPDATE_INTERVAL:
>  		/*
>  		 * ACTMON hardware supports up to 256 milliseconds for the
>  		 * sampling period.
> @@ -745,7 +745,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq,
>  		}
>  
>  		tegra_actmon_pause(tegra);
> -		devfreq_interval_update(devfreq, new_delay);
> +		devfreq_update_interval(devfreq, new_delay);
>  		ret = tegra_actmon_resume(tegra);
>  		break;
>  
> 

Applied it. Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics