linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: dev_is_mac_header_xmit() true for ARPHRD_RAWIP
@ 2019-01-24 11:07 Maciej Żenczykowski
  2019-01-24 11:27 ` Daniel Borkmann
  2019-01-25  6:45 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Maciej Żenczykowski @ 2019-01-24 11:07 UTC (permalink / raw)
  To: Maciej Żenczykowski, David S . Miller, Alexei Starovoitov,
	Daniel Borkmann
  Cc: linux-kernel, netdev

From: Maciej Żenczykowski <maze@google.com>

__bpf_redirect() and act_mirred checks this boolean
to determine whether to prefix an ethernet header.

Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
 include/linux/if_arp.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/if_arp.h b/include/linux/if_arp.h
index 6756fea18b69..e44746de95cd 100644
--- a/include/linux/if_arp.h
+++ b/include/linux/if_arp.h
@@ -54,6 +54,7 @@ static inline bool dev_is_mac_header_xmit(const struct net_device *dev)
 	case ARPHRD_IPGRE:
 	case ARPHRD_VOID:
 	case ARPHRD_NONE:
+	case ARPHRD_RAWIP:
 		return false;
 	default:
 		return true;
-- 
2.20.1.321.g9e740568ce-goog


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: dev_is_mac_header_xmit() true for ARPHRD_RAWIP
  2019-01-24 11:07 [PATCH] net: dev_is_mac_header_xmit() true for ARPHRD_RAWIP Maciej Żenczykowski
@ 2019-01-24 11:27 ` Daniel Borkmann
  2019-01-25  6:45 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2019-01-24 11:27 UTC (permalink / raw)
  To: Maciej Żenczykowski, Maciej Żenczykowski,
	David S . Miller, Alexei Starovoitov
  Cc: linux-kernel, netdev

On 01/24/2019 12:07 PM, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@google.com>
> 
> __bpf_redirect() and act_mirred checks this boolean
> to determine whether to prefix an ethernet header.
> 
> Signed-off-by: Maciej Żenczykowski <maze@google.com>

I presume David would pick this up for net tree, so:

Acked-by: Daniel Borkmann <daniel@iogearbox.net>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: dev_is_mac_header_xmit() true for ARPHRD_RAWIP
  2019-01-24 11:07 [PATCH] net: dev_is_mac_header_xmit() true for ARPHRD_RAWIP Maciej Żenczykowski
  2019-01-24 11:27 ` Daniel Borkmann
@ 2019-01-25  6:45 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-01-25  6:45 UTC (permalink / raw)
  To: zenczykowski; +Cc: maze, ast, daniel, linux-kernel, netdev

From: Maciej Żenczykowski <zenczykowski@gmail.com>
Date: Thu, 24 Jan 2019 03:07:02 -0800

> From: Maciej Żenczykowski <maze@google.com>
> 
> __bpf_redirect() and act_mirred checks this boolean
> to determine whether to prefix an ethernet header.
> 
> Signed-off-by: Maciej Żenczykowski <maze@google.com>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-01-25  6:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-24 11:07 [PATCH] net: dev_is_mac_header_xmit() true for ARPHRD_RAWIP Maciej Żenczykowski
2019-01-24 11:27 ` Daniel Borkmann
2019-01-25  6:45 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).