From: Andrzej Hajda <a.hajda@samsung.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>,
dri-devel@lists.freedesktop.org
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Andrey Gusakov <andrey.gusakov@cogentembedded.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Cory Tusar <cory.tusar@zii.aero>, Chris Healy <cphealy@gmail.com>,
Lucas Stach <l.stach@pengutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 13/15] drm/bridge: tc358767: Simplify tc_aux_wait_busy()
Date: Fri, 7 Jun 2019 08:21:11 +0200 [thread overview]
Message-ID: <fab61a07-6842-f986-25e9-a4cc2e5c8978@samsung.com> (raw)
In-Reply-To: <20190607044550.13361-14-andrew.smirnov@gmail.com>
On 07.06.2019 06:45, Andrey Smirnov wrote:
> We never pass anything but 100 as timeout_ms to tc_aux_wait_busy(), so
> we may as well hardcode that value and simplify function's signature.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
--
Regards
Andrzej
> Cc: Andrzej Hajda <a.hajda@samsung.com>
> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Cory Tusar <cory.tusar@zii.aero>
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/gpu/drm/bridge/tc358767.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
> index c994c72eb330..e747f10021e3 100644
> --- a/drivers/gpu/drm/bridge/tc358767.c
> +++ b/drivers/gpu/drm/bridge/tc358767.c
> @@ -294,10 +294,9 @@ static inline int tc_poll_timeout(struct tc_data *tc, unsigned int addr,
> sleep_us, timeout_us);
> }
>
> -static int tc_aux_wait_busy(struct tc_data *tc, unsigned int timeout_ms)
> +static int tc_aux_wait_busy(struct tc_data *tc)
> {
> - return tc_poll_timeout(tc, DP0_AUXSTATUS, AUX_BUSY, 0,
> - 1000, 1000 * timeout_ms);
> + return tc_poll_timeout(tc, DP0_AUXSTATUS, AUX_BUSY, 0, 1000, 100000);
> }
>
> static int tc_aux_write_data(struct tc_data *tc, const void *data,
> @@ -350,7 +349,7 @@ static ssize_t tc_aux_transfer(struct drm_dp_aux *aux,
> u32 auxstatus;
> int ret;
>
> - ret = tc_aux_wait_busy(tc, 100);
> + ret = tc_aux_wait_busy(tc);
> if (ret)
> return ret;
>
> @@ -377,7 +376,7 @@ static ssize_t tc_aux_transfer(struct drm_dp_aux *aux,
> if (ret)
> return ret;
>
> - ret = tc_aux_wait_busy(tc, 100);
> + ret = tc_aux_wait_busy(tc);
> if (ret)
> return ret;
>
next prev parent reply other threads:[~2019-06-07 6:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 4:45 [PATCH v4 00/15] tc358767 driver improvements Andrey Smirnov
2019-06-07 4:45 ` [PATCH v4 01/15] drm/bridge: tc358767: Simplify tc_poll_timeout() Andrey Smirnov
2019-06-07 4:45 ` [PATCH v4 02/15] drm/bridge: tc358767: Simplify polling in tc_main_link_setup() Andrey Smirnov
2019-06-07 4:45 ` [PATCH v4 03/15] drm/bridge: tc358767: Simplify polling in tc_link_training() Andrey Smirnov
2019-06-07 4:45 ` [PATCH v4 04/15] drm/bridge: tc358767: Simplify tc_set_video_mode() Andrey Smirnov
2019-06-07 4:45 ` [PATCH v4 05/15] drm/bridge: tc358767: Drop custom tc_write()/tc_read() accessors Andrey Smirnov
2019-06-07 4:45 ` [PATCH v4 06/15] drm/bridge: tc358767: Simplify AUX data read Andrey Smirnov
2019-06-07 4:45 ` [PATCH v4 07/15] drm/bridge: tc358767: Simplify AUX data write Andrey Smirnov
2019-06-07 4:45 ` [PATCH v4 08/15] drm/bridge: tc358767: Increase AUX transfer length limit Andrey Smirnov
2019-06-07 4:45 ` [PATCH v4 09/15] drm/bridge: tc358767: Use reported AUX transfer size Andrey Smirnov
2019-06-07 6:10 ` Andrzej Hajda
2019-06-07 4:45 ` [PATCH v4 10/15] drm/bridge: tc358767: Add support for address-only I2C transfers Andrey Smirnov
2019-06-07 6:13 ` Andrzej Hajda
2019-06-07 4:45 ` [PATCH v4 11/15] drm/bridge: tc358767: Introduce tc_set_syspllparam() Andrey Smirnov
2019-06-07 6:15 ` Andrzej Hajda
2019-06-07 4:45 ` [PATCH v4 12/15] drm/bridge: tc358767: Introduce tc_pllupdate_pllen() Andrey Smirnov
2019-06-07 6:20 ` Andrzej Hajda
2019-06-07 4:45 ` [PATCH v4 13/15] drm/bridge: tc358767: Simplify tc_aux_wait_busy() Andrey Smirnov
2019-06-07 6:21 ` Andrzej Hajda [this message]
2019-06-07 4:45 ` [PATCH v4 14/15] drm/bridge: tc358767: Drop unnecessary 8 byte buffer Andrey Smirnov
2019-06-07 6:41 ` Andrzej Hajda
2019-06-07 4:45 ` [PATCH v4 15/15] drm/bridge: tc358767: Replace magic number in tc_main_link_enable() Andrey Smirnov
2019-06-07 6:42 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fab61a07-6842-f986-25e9-a4cc2e5c8978@samsung.com \
--to=a.hajda@samsung.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=andrew.smirnov@gmail.com \
--cc=andrey.gusakov@cogentembedded.com \
--cc=cory.tusar@zii.aero \
--cc=cphealy@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).