From: Mukesh Ojha <quic_mojha@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: <konrad.dybcio@linaro.org>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linus.walleij@linaro.org>,
<linux-gpio@vger.kernel.org>,
Poovendhan Selvaraj <quic_poovendh@quicinc.com>,
Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Elliot Berman <quic_eberman@quicinc.com>
Subject: Re: [PATCH v12 3/9] firmware: qcom: scm: Modify only the download bits in TCSR register
Date: Tue, 5 Mar 2024 16:13:12 +0530 [thread overview]
Message-ID: <fb419b4b-62b2-8316-201e-e11430e32d8f@quicinc.com> (raw)
In-Reply-To: <ncyanjtxtqyx236d5tfm46nepvy6ncxikonc6g6hlddhx2joee@jqjhfxtu3sr6>
On 3/3/2024 12:43 AM, Bjorn Andersson wrote:
> On Tue, Feb 27, 2024 at 09:23:02PM +0530, Mukesh Ojha wrote:
>> Crashdump collection is done based on DLOAD bits of TCSR register.
>> To retain other bits, scm driver need to read the register and
>> modify only the DLOAD bits, as other bits in TCSR may have their
>> own significance.
>>
>> Co-developed-by: Poovendhan Selvaraj <quic_poovendh@quicinc.com>
>> Signed-off-by: Poovendhan Selvaraj <quic_poovendh@quicinc.com>
>> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
>> Tested-by: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com> # IPQ9574 and IPQ5332
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> Reviewed-by: Elliot Berman <quic_eberman@quicinc.com>
>> ---
>> drivers/firmware/qcom/qcom_scm.c | 14 ++++++++++++--
>> 1 file changed, 12 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
>> index 8f766fce5f7c..bd6bfdf2d828 100644
>> --- a/drivers/firmware/qcom/qcom_scm.c
>> +++ b/drivers/firmware/qcom/qcom_scm.c
>> @@ -4,6 +4,8 @@
>> */
>>
>> #include <linux/arm-smccc.h>
>> +#include <linux/bitfield.h>
>> +#include <linux/bits.h>
>> #include <linux/clk.h>
>> #include <linux/completion.h>
>> #include <linux/cpumask.h>
>> @@ -114,6 +116,12 @@ static const u8 qcom_scm_cpu_warm_bits[QCOM_SCM_BOOT_MAX_CPUS] = {
>> #define QCOM_SMC_WAITQ_FLAG_WAKE_ONE BIT(0)
>> #define QCOM_SMC_WAITQ_FLAG_WAKE_ALL BIT(1)
>>
>> +#define QCOM_DLOAD_MASK GENMASK(5, 4)
>> +enum qcom_dload_mode {
>> + QCOM_DLOAD_NODUMP = 0,
>> + QCOM_DLOAD_FULLDUMP = 1,
>
> These values are not enumerations, they represent fixed/defined values
> in the interface. As such it's appropriate to use #define.
>
Thanks for giving reasoning on why it should be #define and not enum.
-Mukesh
next prev parent reply other threads:[~2024-03-05 10:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 15:52 [PATCH v12 0/9] Misc SCM driver changes Mukesh Ojha
2024-02-27 15:53 ` [PATCH v12 1/9] firmware: qcom: scm: Rename scm_query_lock to scm_lock Mukesh Ojha
2024-03-02 19:10 ` Bjorn Andersson
2024-02-27 15:53 ` [PATCH v12 2/9] firmware: qcom: scm: provide a read-modify-write function Mukesh Ojha
2024-03-02 19:09 ` Bjorn Andersson
2024-03-05 10:39 ` Mukesh Ojha
2024-02-27 15:53 ` [PATCH v12 3/9] firmware: qcom: scm: Modify only the download bits in TCSR register Mukesh Ojha
2024-03-02 19:13 ` Bjorn Andersson
2024-03-05 10:43 ` Mukesh Ojha [this message]
2024-02-27 15:53 ` [PATCH v12 4/9] firmware: qcom: scm: Rework dload mode availability check Mukesh Ojha
2024-03-02 19:16 ` Bjorn Andersson
2024-03-05 10:54 ` Mukesh Ojha
2024-02-27 15:53 ` [PATCH v12 5/9] pinctrl: qcom: Use qcom_scm_io_rmw() function Mukesh Ojha
2024-02-29 13:56 ` Linus Walleij
2024-02-27 15:53 ` [PATCH v12 6/9] firmware: qcom: scm: Remove log reporting memory allocation failure Mukesh Ojha
2024-03-02 19:18 ` Bjorn Andersson
2024-02-27 15:53 ` [PATCH v12 7/9] firmware: qcom: scm: Fix __scm->dev assignement Mukesh Ojha
2024-03-02 19:25 ` Bjorn Andersson
2024-03-18 13:08 ` Mukesh Ojha
2024-03-19 1:17 ` Pavan Kondeti
2024-03-19 10:08 ` Mukesh Ojha
2024-03-19 10:22 ` Pavan Kondeti
2024-03-19 14:39 ` Mukesh Ojha
2024-02-27 15:53 ` [PATCH v12 8/9] firmware: qcom: scm: Add check to prevent Null pointer dereference Mukesh Ojha
2024-02-27 16:56 ` Elliot Berman
2024-02-28 15:08 ` Mukesh Ojha
2024-03-01 23:42 ` Konrad Dybcio
2024-03-02 18:57 ` Bjorn Andersson
2024-02-27 15:53 ` [PATCH v12 9/9] firmware: scm: Remove redundant scm argument from qcom_scm_waitq_wakeup() Mukesh Ojha
2024-03-02 19:23 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb419b4b-62b2-8316-201e-e11430e32d8f@quicinc.com \
--to=quic_mojha@quicinc.com \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_eberman@quicinc.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_poovendh@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).