Re: [PATCH v12 9/9] firmware: scm: Remove redundant scm argument from qcom_scm_waitq_wakeup()

From: Bjorn Andersson <andersson@kernel.org>
To: Mukesh Ojha <quic_mojha@quicinc.com>
Cc: konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org,
	 linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH v12 9/9] firmware: scm: Remove redundant scm argument from qcom_scm_waitq_wakeup()
Date: Sat, 2 Mar 2024 13:23:29 -0600	[thread overview]
Message-ID: <xeijmkykwsdk2x2g425ljowiuh4t46qicwxasmedqrt4iejfju@7mfkjubfiehl> (raw)
In-Reply-To: <20240227155308.18395-10-quic_mojha@quicinc.com>

On Tue, Feb 27, 2024 at 09:23:08PM +0530, Mukesh Ojha wrote:
> Remove unused scm argument from qcom_scm_waitq_wakeup().

Is it unused or redundant? Please pick on word (the right one ;))

Regards,
Bjorn

> 
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> ---
>  drivers/firmware/qcom/qcom_scm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
> index a1dce417e6ec..d91f5872e003 100644
> --- a/drivers/firmware/qcom/qcom_scm.c
> +++ b/drivers/firmware/qcom/qcom_scm.c
> @@ -1853,7 +1853,7 @@ int qcom_scm_wait_for_wq_completion(u32 wq_ctx)
>  	return 0;
>  }
>  
> -static int qcom_scm_waitq_wakeup(struct qcom_scm *scm, unsigned int wq_ctx)
> +static int qcom_scm_waitq_wakeup(unsigned int wq_ctx)
>  {
>  	int ret;
>  
> @@ -1885,7 +1885,7 @@ static irqreturn_t qcom_scm_irq_handler(int irq, void *data)
>  			goto out;
>  		}
>  
> -		ret = qcom_scm_waitq_wakeup(scm, wq_ctx);
> +		ret = qcom_scm_waitq_wakeup(wq_ctx);
>  		if (ret)
>  			goto out;
>  	} while (more_pending);
> -- 
> 2.43.0.254.ga26002b62827
> 