From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>, Wen Yang <wen.yang99@zte.com.cn>
Cc: Wen Yang <yellowriver2010@hotmail.com>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
Michal Marek <michal.lkml@markovi.net>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Cheng Shengyu <cheng.shengyu@zte.com.cn>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
cocci@systeme.lip6.fr
Subject: Re: [v6] coccinelle: semantic code search for missing put_device()
Date: Tue, 19 Feb 2019 09:12:11 +0100 [thread overview]
Message-ID: <fc48cfe9-3d01-8ab6-7bf0-a481b72f4a1a@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1902190804150.2570@hadrien>
>> Although we have tested these two methods in the existing kernel code,
>> considering the evolution of the kernel code, these special cases may occur, so we are willing to take them into account.
>> We plan to modify the code like this:
>>
>> id = of_find_device_by_node@p1(x)
>> -... when != e = id
>> +... when != e = (T)id
>> + when != id = (T)e
>
> This change is fine with me.
Thanks for another positive feedback on such software implementation details.
Regards,
Markus
next prev parent reply other threads:[~2019-02-19 8:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201902191014156680299@zte.com.cn>
2019-02-19 7:04 ` [v6] coccinelle: semantic code search for missing put_device() Julia Lawall
2019-02-19 8:12 ` Markus Elfring [this message]
2019-02-19 8:29 ` Markus Elfring
2019-03-06 11:18 ` Markus Elfring
[not found] <201902191709341581016@zte.com.cn>
2019-02-19 9:30 ` Markus Elfring
[not found] <201902181122502228026@zte.com.cn>
2019-02-18 6:43 ` Julia Lawall
2019-02-18 8:19 ` Markus Elfring
2019-02-18 21:40 ` Markus Elfring
[not found] <HK0PR02MB36344E2B29CEB195892F6420B2610@HK0PR02MB3634.apcprd02.prod.outlook.com>
2019-02-16 18:39 ` Markus Elfring
2019-02-17 9:50 ` [PATCH v6] " Markus Elfring
2019-02-17 11:37 ` Julia Lawall
2019-02-17 11:42 ` Markus Elfring
2019-02-17 11:48 ` Julia Lawall
2019-02-17 12:00 ` [v6] " Markus Elfring
2019-02-17 12:05 ` Julia Lawall
2019-02-17 12:20 ` Markus Elfring
2019-02-17 12:52 ` Julia Lawall
2019-02-17 13:14 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc48cfe9-3d01-8ab6-7bf0-a481b72f4a1a@web.de \
--to=markus.elfring@web.de \
--cc=Gilles.Muller@lip6.fr \
--cc=cheng.shengyu@zte.com.cn \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=wen.yang99@zte.com.cn \
--cc=yamada.masahiro@socionext.com \
--cc=yellowriver2010@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).