From: "Simmons, James A." <simmonsja@ornl.gov>
To: "'Dan Carpenter'" <dan.carpenter@oracle.com>
Cc: "'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>,
James Simmons <jsimmons@infradead.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Oleg Drokin <oleg.drokin@intel.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"lustre-devel@lists.lustre.org" <lustre-devel@lists.lustre.org>
Subject: RE: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c
Date: Tue, 3 Nov 2015 23:56:22 +0000 [thread overview]
Message-ID: <fc4cb8a899234adabb499f57b76a20b2@EXCHCS32.ornl.gov> (raw)
In-Reply-To: <20151102144837.GG18797@mwanda>
>Yeah. That is often the fastest way to fix all the checkpatch warnings.
>
>Checkpatch warnings are pretty mechanical. Just send like 100 patches
>at a time until everything is fixed. Don't overthink. Say your patch
>breaks the alignment then you have to fix that, but otherwise only fix
>one thing at a time. Sometimes people will ask you to fix something
>else on the same line, but just say "I didn't introduce that, but yes I
>am planning to fix that in a later patchset since I am following the
>one thing per patch rule."
>
>Don't feel shame about sending many small patches. We pretty much merge
>everything.
It was the sense of it taking forever with that amount of patches needed with
the one file approach. Looking at the back log of fixes its not as bad as I thought
for libcfs/LNet. Once those fixes are merged the style cleanups can happen
pretty quickly.
next prev parent reply other threads:[~2015-11-03 23:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 23:28 [PATCH 0/3] make nidstring.c kernel style compliant James Simmons
2015-10-29 23:28 ` [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c James Simmons
2015-10-30 7:50 ` Sudip Mukherjee
2015-10-30 23:01 ` Greg Kroah-Hartman
2015-11-01 23:07 ` [lustre-devel] " Simmons, James A.
2015-11-01 23:24 ` Michael Shuey
2015-11-02 14:48 ` Dan Carpenter
2015-11-03 23:56 ` Simmons, James A. [this message]
2015-10-29 23:28 ` [PATCH 2/3] staging: lustre: white space " James Simmons
2015-10-29 23:28 ` [PATCH 3/3] staging: lustre: checkpatch cleanups for nidstr.h James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc4cb8a899234adabb499f57b76a20b2@EXCHCS32.ornl.gov \
--to=simmonsja@ornl.gov \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).