From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms@verge.net.au>
Cc: jacopo mondi <jacopo@jmondi.org>,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
geert@linux-m68k.org, magnus.damm@gmail.com, robh+dt@kernel.org,
mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node
Date: Thu, 22 Feb 2018 22:08:46 +0300 [thread overview]
Message-ID: <fceb1fd4-b0bd-7061-7cb8-c33f2a05c503@cogentembedded.com> (raw)
In-Reply-To: <20180222155411.gnn42poawtlf3rze@verge.net.au>
Hello!
On 02/22/2018 06:54 PM, Simon Horman wrote:
>>> ...
>>>
>>>>>>>>>> + clocks = <&cpg CPG_MOD 812>;
>>>>>>>>>> + power-domains = <&sysc 32>;
>>>>>>>>>> + resets = <&cpg 812>;
>>>>>>>>>> + phy-mode = "rgmii-txid";
>>>>>>>>>
>>>>>>>>> Why not just "rgmii"? TX delay is a board specific detail, no?
>>>>>>>>>
>>>>>>>> I admit I took this one straight from r8a7796 dtsi.
>>>>>>>> Would you like to me resend and change this?
>>>>>>>
>>>>>>> Yes, unless Simon would fix it while merging...
>>>>>>
>>>>>> Can I confirm the desired change is s/rgmii-txid/rgmii/ ?
>>>>>
>>>>> Yes.
>>>>
>>>> Apparently that means that this prop should be overridden in the board file
>>>> (which may not be an easy task given the board is Salvator-XS again).
>>>>
>>>> [...]
>>>
>>> Can we override it in r8a77965-salvator-x.dts or r8a77965-salvator-xs.dts?
>>
>> In salvator-common.dtsi most probably -- it has the PHY data for Ether AVB.
>>
>>> I feel that I'm missing an important point here.
>>
>> Well, r8a779{5|6}.dtsi also have phy-mode = "rgmii-txid" (which was
>> unjustified in my current understanding). Thus such board override
>> wouldn't hurt them. But we lack a patch modifying salvator-common.dtsi
>> in htis series, so I'm now thinking a respin of this series is needed
>> anyway... sorry for being unclear. :-)
>
> While I've applied other patches in this series I have
> not applied this one - mainly to allow this discussion to conclude.
>
> Is an appropriate solution to do the following?
>
> 1) Atomically update
> a) r8a779{5|6}.dtsi to use "rgmii" and
> b) salvator-common.dtsi to use "rgmii-txid"
> 2) Update this patch to use "rgmii"
Yeah, I was thinking about doing exactly this...
> Sorry if I'm still missing the point.
I was referring to what the 2nd paragraph of [1] said about the internal delays
(perhaps I just misunderstood it)...
[1] https://en.wikipedia.org/wiki/Media-independent_interface#Reduced_gigabit_media-independent_interface
MBR, Sergei
next prev parent reply other threads:[~2018-02-22 19:08 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 15:12 [PATCH v2 00/19] R-Car M3-N initial support Jacopo Mondi
2018-02-20 15:12 ` [PATCH v2 01/19] clk: renesas: cpg-mssr: Add support for R-Car M3-N Jacopo Mondi
2018-02-20 18:46 ` Geert Uytterhoeven
2018-02-26 8:14 ` Geert Uytterhoeven
2018-02-20 15:12 ` [PATCH v2 02/19] soc: renesas: rcar-rst: " Jacopo Mondi
2018-02-20 15:29 ` Geert Uytterhoeven
2018-02-21 16:45 ` Simon Horman
2018-02-20 15:12 ` [PATCH v2 03/19] soc: renesas: Identify " Jacopo Mondi
2018-02-20 15:40 ` Geert Uytterhoeven
2018-02-21 16:50 ` Simon Horman
2018-02-20 15:12 ` [PATCH v2 04/19] soc: renesas: rcar-sysc: Add R-Car M3-N support Jacopo Mondi
2018-02-20 15:44 ` Geert Uytterhoeven
2018-02-21 16:54 ` Simon Horman
2018-02-20 15:12 ` [PATCH v2 05/19] pinctrl: sh-pfc: Initial " Jacopo Mondi
2018-02-20 18:35 ` Geert Uytterhoeven
2018-02-20 15:12 ` [PATCH v2 06/19] dt-bindings: arm: Document R-Car M3-N SoC DT bindings Jacopo Mondi
2018-02-21 16:58 ` Simon Horman
2018-02-20 15:12 ` [PATCH v2 07/19] ARM64: Add Renesas R-Car M3-N config symbol Jacopo Mondi
2018-02-20 15:44 ` Geert Uytterhoeven
2018-02-21 17:03 ` Simon Horman
2018-02-20 15:12 ` [PATCH v2 08/19] ARM64: dts: Add Renesas R8A77965 SoC support Jacopo Mondi
2018-02-20 15:45 ` Geert Uytterhoeven
2018-02-21 17:06 ` Simon Horman
2018-02-20 15:12 ` [PATCH v2 09/19] ARM64: dts: Add R-Car Salvator-x M3-N support Jacopo Mondi
2018-02-20 15:46 ` Geert Uytterhoeven
2018-02-21 17:15 ` Simon Horman
2018-02-22 11:39 ` Arnd Bergmann
2018-02-22 13:28 ` Geert Uytterhoeven
2018-02-22 15:38 ` Simon Horman
2018-02-22 15:46 ` Arnd Bergmann
2018-02-20 15:12 ` [PATCH v2 10/19] dt-bindings: dmaengine: rcar-dmac: document R8A77965 support Jacopo Mondi
2018-03-01 21:50 ` Rob Herring
2018-04-16 11:09 ` Geert Uytterhoeven
2018-02-20 15:12 ` [PATCH v2 11/19] ARM64: dts: r8a77965: Add dmac device nods Jacopo Mondi
2018-02-21 17:18 ` Simon Horman
2018-02-20 15:12 ` [PATCH v2 12/19] dt-bindings: serial: sh-sci: Add support for r8a77965 (H)SCIF Jacopo Mondi
2018-02-20 15:46 ` Geert Uytterhoeven
2018-02-21 17:18 ` Simon Horman
2018-03-01 21:50 ` Rob Herring
2018-02-20 15:12 ` [PATCH v2 13/19] pinctrl: sh-pfc: r8a77965: Add SCIFs groups/functions Jacopo Mondi
2018-02-20 18:36 ` Geert Uytterhoeven
2018-02-20 15:12 ` [PATCH v2 14/19] ARM64: dts: r8a77965: Add SCIF device nodes Jacopo Mondi
2018-02-21 17:20 ` Simon Horman
2018-02-20 15:12 ` [PATCH v2 15/19] dt-bindings: gpio: Add support for r8a77965 Jacopo Mondi
2018-02-21 17:20 ` Simon Horman
2018-03-01 21:51 ` Rob Herring
2018-04-16 11:12 ` Geert Uytterhoeven
2018-04-16 13:07 ` jacopo mondi
2018-02-20 15:12 ` [PATCH v2 16/19] ARM64: dts: r8a77965: Add GPIO nodes Jacopo Mondi
2018-02-21 17:26 ` Simon Horman
2018-02-20 15:12 ` [PATCH v2 17/19] dt-bindings: net: ravb: Add support for r8a77965 SoC Jacopo Mondi
2018-03-01 21:52 ` Rob Herring
2018-02-20 15:12 ` [PATCH v2 18/19] pinctrl: sh-pfc: r8a77965: Add EtherAVB groups/functions Jacopo Mondi
2018-02-20 18:36 ` Geert Uytterhoeven
2018-02-20 15:12 ` [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node Jacopo Mondi
2018-02-20 15:30 ` Sergei Shtylyov
2018-02-21 10:07 ` jacopo mondi
2018-02-21 15:48 ` Sergei Shtylyov
2018-02-21 17:31 ` Simon Horman
2018-02-21 17:38 ` Sergei Shtylyov
2018-02-21 17:53 ` Sergei Shtylyov
2018-02-21 18:23 ` Simon Horman
2018-02-21 18:53 ` Sergei Shtylyov
2018-02-22 15:54 ` Simon Horman
2018-02-22 19:08 ` Sergei Shtylyov [this message]
2018-02-23 7:06 ` Geert Uytterhoeven
2018-02-23 15:07 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fceb1fd4-b0bd-7061-7cb8-c33f2a05c503@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=jacopo+renesas@jmondi.org \
--cc=jacopo@jmondi.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).