[PATCH] net/mlx5e: Use IS_ERR() to check and simplify code

[PATCH] net/mlx5e: Use IS_ERR() to check and simplify code

[Tang Bin]

Use IS_ERR() and PTR_ERR() instead of PTR_ZRR_OR_ZERO()
to simplify code, avoid redundant judgements.

Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c
index af4ebd295..00e7add0b 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c
@@ -93,9 +93,8 @@ static int mlx5e_route_lookup_ipv4(struct mlx5e_priv *priv,
 	}
 
 	rt = ip_route_output_key(dev_net(mirred_dev), fl4);
-	ret = PTR_ERR_OR_ZERO(rt);
-	if (ret)
-		return ret;
+	if (IS_ERR(rt))
+		return PTR_ERR(rt);
 
 	if (mlx5_lag_is_multipath(mdev) && rt->rt_gw_family != AF_INET) {
 		ip_rt_put(rt);
-- 
2.20.1.windows.1

Re: [PATCH] net/mlx5e: Use IS_ERR() to check and simplify code

[Leon Romanovsky]

On Thu, May 07, 2020 at 07:50:10PM +0800, Tang Bin wrote:
> Use IS_ERR() and PTR_ERR() instead of PTR_ZRR_OR_ZERO()
> to simplify code, avoid redundant judgements.
>
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

Re: [PATCH] net/mlx5e: Use IS_ERR() to check and simplify code

[David Miller]

From: Tang Bin <tangbin@cmss.chinamobile.com>
Date: Thu,  7 May 2020 19:50:10 +0800

> Use IS_ERR() and PTR_ERR() instead of PTR_ZRR_OR_ZERO()
> to simplify code, avoid redundant judgements.
> 
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>

Saeed, please pick this up.

Thank you.

Re: [PATCH] net/mlx5e: Use IS_ERR() to check and simplify code

[Tang Bin]

Hi David:

On 2020/5/8 4:18, David Miller wrote:
> From: Tang Bin <tangbin@cmss.chinamobile.com>
> Date: Thu,  7 May 2020 19:50:10 +0800
>
>> Use IS_ERR() and PTR_ERR() instead of PTR_ZRR_OR_ZERO()
>> to simplify code, avoid redundant judgements.
>>
>> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
>> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> Saeed, please pick this up.

Does this mean the patch has been received and I just have to wait?

Thanks,

Tang Bin

Re: [PATCH] net/mlx5e: Use IS_ERR() to check and simplify code

[Saeed Mahameed]

On Wed, 2020-05-13 at 17:48 +0800, Tang Bin wrote:
> Hi David:
> 
> On 2020/5/8 4:18, David Miller wrote:
> > From: Tang Bin <tangbin@cmss.chinamobile.com>
> > Date: Thu,  7 May 2020 19:50:10 +0800
> > 
> > > Use IS_ERR() and PTR_ERR() instead of PTR_ZRR_OR_ZERO()
                                            ^^^^^^^ typo
> > > to simplify code, avoid redundant judgements.
> > > 
> > > Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> > Saeed, please pick this up.
> 
> Does this mean the patch has been received and I just have to wait?
> 

no, mlx5 patches normally go to net-next-mlx5 branch and usually
pulled into net-next once a week when i send my pull requests.

i will reply with "applied" when i apply this patch,
but for now please fix the typo.

Thanks,
Saeed

Re: [PATCH] net/mlx5e: Use IS_ERR() to check and simplify code

[Tang Bin]

Hi Saeed：

On 2020/5/16 6:28, Saeed Mahameed wrote:
> On Wed, 2020-05-13 at 17:48 +0800, Tang Bin wrote:
>> Hi David:
>>
>> On 2020/5/8 4:18, David Miller wrote:
>>> From: Tang Bin <tangbin@cmss.chinamobile.com>
>>> Date: Thu,  7 May 2020 19:50:10 +0800
>>>
>>>> Use IS_ERR() and PTR_ERR() instead of PTR_ZRR_OR_ZERO()
>                                              ^^^^^^^ typo
Sorry for this mistake, sorry.
>>>> to simplify code, avoid redundant judgements.
>>>>
>>>> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
>>>> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
>>> Saeed, please pick this up.
>> Does this mean the patch has been received and I just have to wait?
>>
> no, mlx5 patches normally go to net-next-mlx5 branch and usually
> pulled into net-next once a week when i send my pull requests.
>
> i will reply with "applied" when i apply this patch,
> but for now please fix the typo.

Got it, I will send v2 for you.

Thanks,

Tang Bin