linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: David Hildenbrand <david@redhat.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Miaohe Lin <linmiaohe@huawei.com>,
	akpm@linux-foundation.org
Cc: iamjoonsoo.kim@lge.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/page_isolation: don't putback unisolated page
Date: Wed, 8 Sep 2021 15:42:27 -0700	[thread overview]
Message-ID: <febcceaa-7d94-c3a3-c683-7a8694981b47@nvidia.com> (raw)
In-Reply-To: <80cfffdc-227e-c045-be74-1c08fb62c1e3@redhat.com>

On 9/7/21 2:56 AM, David Hildenbrand wrote:
...
>> If this can be handled gracefully, then I'd rather go with VM_WARN_ON.
>> Maybe even WARN_ON_ONCE?
>>
> 
> I think either VM_BUG_ON() or VM_WARN_ON() -- compiling the runtime checks out -- should be good 
> enough.
> 
> I'd just go with VM_BUG_ON(), because anybody messing with __isolate_free_page() should clearly spot 
> that we expect the current handling. But no strong opinion.
> 

If in doubt, WARN*() should be preferred over BUG*(). There's a pretty long
history of "don't kill the machine unless you have to" emails about this, let
me dig up one...OK, maybe not the best example, but the tip of the iceberg:

http://lkml.iu.edu/hypermail/linux/kernel/1610.0/00878.html

thanks,
-- 
John Hubbard
NVIDIA

  reply	other threads:[~2021-09-08 22:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-04  9:18 [PATCH] mm/page_isolation: don't putback unisolated page Miaohe Lin
2021-09-06  9:40 ` David Hildenbrand
2021-09-06 11:32   ` Miaohe Lin
2021-09-06 11:50     ` David Hildenbrand
2021-09-06 12:01       ` David Hildenbrand
2021-09-06 12:08         ` Miaohe Lin
2021-09-06 12:02 ` David Hildenbrand
2021-09-06 12:11   ` David Hildenbrand
2021-09-06 12:45     ` Miaohe Lin
2021-09-06 12:49       ` David Hildenbrand
2021-09-07  1:46         ` Miaohe Lin
2021-09-07  9:52           ` David Hildenbrand
2021-09-07  8:08         ` Vlastimil Babka
2021-09-07  9:56           ` David Hildenbrand
2021-09-08 22:42             ` John Hubbard [this message]
2021-09-09  8:56               ` David Hildenbrand
2021-09-09  9:07                 ` Vlastimil Babka
2021-09-09  9:37                   ` David Hildenbrand
2021-09-09 16:50                 ` John Hubbard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=febcceaa-7d94-c3a3-c683-7a8694981b47@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).