* [PATCH] ALSA: use designated initializers
@ 2016-12-17 0:59 Kees Cook
2016-12-17 10:17 ` Takashi Sakamoto
2016-12-28 15:06 ` Takashi Iwai
0 siblings, 2 replies; 3+ messages in thread
From: Kees Cook @ 2016-12-17 0:59 UTC (permalink / raw)
To: linux-kernel; +Cc: Jaroslav Kysela, Takashi Iwai, alsa-devel
Prepare to mark sensitive kernel structures for randomization by making
sure they're using designated initializers. These were identified during
allyesconfig builds of x86, arm, and arm64, with most initializer fixes
extracted from grsecurity.
Signed-off-by: Kees Cook <keescook@chromium.org>
---
sound/synth/emux/emux_seq.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/sound/synth/emux/emux_seq.c b/sound/synth/emux/emux_seq.c
index a0209204ae48..55579f6b8cb2 100644
--- a/sound/synth/emux/emux_seq.c
+++ b/sound/synth/emux/emux_seq.c
@@ -33,13 +33,13 @@ static int snd_emux_unuse(void *private_data, struct snd_seq_port_subscribe *inf
* MIDI emulation operators
*/
static struct snd_midi_op emux_ops = {
- snd_emux_note_on,
- snd_emux_note_off,
- snd_emux_key_press,
- snd_emux_terminate_note,
- snd_emux_control,
- snd_emux_nrpn,
- snd_emux_sysex,
+ .note_on = snd_emux_note_on,
+ .note_off = snd_emux_note_off,
+ .key_press = snd_emux_key_press,
+ .note_terminate = snd_emux_terminate_note,
+ .control = snd_emux_control,
+ .nrpn = snd_emux_nrpn,
+ .sysex = snd_emux_sysex,
};
--
2.7.4
--
Kees Cook
Nexus Security
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: use designated initializers
2016-12-17 0:59 [PATCH] ALSA: use designated initializers Kees Cook
@ 2016-12-17 10:17 ` Takashi Sakamoto
2016-12-28 15:06 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Sakamoto @ 2016-12-17 10:17 UTC (permalink / raw)
To: Kees Cook, linux-kernel; +Cc: alsa-devel, Takashi Iwai
On Dec 17 2016 09:59, Kees Cook wrote:
> Prepare to mark sensitive kernel structures for randomization by making
> sure they're using designated initializers. These were identified during
> allyesconfig builds of x86, arm, and arm64, with most initializer fixes
> extracted from grsecurity.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> sound/synth/emux/emux_seq.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> diff --git a/sound/synth/emux/emux_seq.c b/sound/synth/emux/emux_seq.c
> index a0209204ae48..55579f6b8cb2 100644
> --- a/sound/synth/emux/emux_seq.c
> +++ b/sound/synth/emux/emux_seq.c
> @@ -33,13 +33,13 @@ static int snd_emux_unuse(void *private_data, struct snd_seq_port_subscribe *inf
> * MIDI emulation operators
> */
> static struct snd_midi_op emux_ops = {
> - snd_emux_note_on,
> - snd_emux_note_off,
> - snd_emux_key_press,
> - snd_emux_terminate_note,
> - snd_emux_control,
> - snd_emux_nrpn,
> - snd_emux_sysex,
> + .note_on = snd_emux_note_on,
> + .note_off = snd_emux_note_off,
> + .key_press = snd_emux_key_press,
> + .note_terminate = snd_emux_terminate_note,
> + .control = snd_emux_control,
> + .nrpn = snd_emux_nrpn,
> + .sysex = snd_emux_sysex,
> };
Regards
Takashi Sakamoto
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: use designated initializers
2016-12-17 0:59 [PATCH] ALSA: use designated initializers Kees Cook
2016-12-17 10:17 ` Takashi Sakamoto
@ 2016-12-28 15:06 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2016-12-28 15:06 UTC (permalink / raw)
To: Kees Cook; +Cc: linux-kernel, alsa-devel, Jaroslav Kysela
On Sat, 17 Dec 2016 01:59:44 +0100,
Kees Cook wrote:
>
> Prepare to mark sensitive kernel structures for randomization by making
> sure they're using designated initializers. These were identified during
> allyesconfig builds of x86, arm, and arm64, with most initializer fixes
> extracted from grsecurity.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
Applied, thanks.
Takashi
> ---
> sound/synth/emux/emux_seq.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/sound/synth/emux/emux_seq.c b/sound/synth/emux/emux_seq.c
> index a0209204ae48..55579f6b8cb2 100644
> --- a/sound/synth/emux/emux_seq.c
> +++ b/sound/synth/emux/emux_seq.c
> @@ -33,13 +33,13 @@ static int snd_emux_unuse(void *private_data, struct snd_seq_port_subscribe *inf
> * MIDI emulation operators
> */
> static struct snd_midi_op emux_ops = {
> - snd_emux_note_on,
> - snd_emux_note_off,
> - snd_emux_key_press,
> - snd_emux_terminate_note,
> - snd_emux_control,
> - snd_emux_nrpn,
> - snd_emux_sysex,
> + .note_on = snd_emux_note_on,
> + .note_off = snd_emux_note_off,
> + .key_press = snd_emux_key_press,
> + .note_terminate = snd_emux_terminate_note,
> + .control = snd_emux_control,
> + .nrpn = snd_emux_nrpn,
> + .sysex = snd_emux_sysex,
> };
>
>
> --
> 2.7.4
>
>
> --
> Kees Cook
> Nexus Security
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-28 15:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-17 0:59 [PATCH] ALSA: use designated initializers Kees Cook
2016-12-17 10:17 ` Takashi Sakamoto
2016-12-28 15:06 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).