* [PATCH] pata_atiixp: Remove unnecessary parentheses
@ 2018-09-11 21:43 Nathan Chancellor
2018-09-11 21:49 ` Nick Desaulniers
2018-09-11 22:57 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Nathan Chancellor @ 2018-09-11 21:43 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, Jens Axboe
Cc: linux-ide, linux-kernel, Nick Desaulniers, Nathan Chancellor
Clang warns when more than one set of parentheses is used for a
single conditional statement:
drivers/ata/pata_atiixp.c:282:19: warning: equality comparison with
extraneous parentheses [-Wparentheses-equality]
if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/ata/pata_atiixp.c:282:19: note: remove extraneous parentheses
around the comparison to silence this warning
if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
~ ^ ~
drivers/ata/pata_atiixp.c:282:19: note: use '=' to turn this equality
comparison into an assignment
if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
^~
=
1 warning generated.
Reported-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
drivers/ata/pata_atiixp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_atiixp.c b/drivers/ata/pata_atiixp.c
index 4d49fd3c927b..843bb200a1ee 100644
--- a/drivers/ata/pata_atiixp.c
+++ b/drivers/ata/pata_atiixp.c
@@ -279,7 +279,7 @@ static int atiixp_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
const struct ata_port_info *ppi[] = { &info, &info };
/* SB600 doesn't have secondary port wired */
- if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
+ if (pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE)
ppi[1] = &ata_dummy_port_info;
return ata_pci_bmdma_init_one(pdev, ppi, &atiixp_sht, NULL,
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pata_atiixp: Remove unnecessary parentheses
2018-09-11 21:43 [PATCH] pata_atiixp: Remove unnecessary parentheses Nathan Chancellor
@ 2018-09-11 21:49 ` Nick Desaulniers
2018-09-11 22:57 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Nick Desaulniers @ 2018-09-11 21:49 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: b.zolnierkie, axboe, linux-ide, LKML
On Tue, Sep 11, 2018 at 2:43 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> Clang warns when more than one set of parentheses is used for a
> single conditional statement:
>
> drivers/ata/pata_atiixp.c:282:19: warning: equality comparison with
> extraneous parentheses [-Wparentheses-equality]
> if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
> ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/ata/pata_atiixp.c:282:19: note: remove extraneous parentheses
> around the comparison to silence this warning
> if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
> ~ ^ ~
> drivers/ata/pata_atiixp.c:282:19: note: use '=' to turn this equality
> comparison into an assignment
> if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
> ^~
> =
Yeah, I don't think assignment and conditional checking was implied here.
Thanks for the simple fix.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> 1 warning generated.
>
> Reported-by: Nick Desaulniers <ndesaulniers@google.com>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> drivers/ata/pata_atiixp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/pata_atiixp.c b/drivers/ata/pata_atiixp.c
> index 4d49fd3c927b..843bb200a1ee 100644
> --- a/drivers/ata/pata_atiixp.c
> +++ b/drivers/ata/pata_atiixp.c
> @@ -279,7 +279,7 @@ static int atiixp_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
> const struct ata_port_info *ppi[] = { &info, &info };
>
> /* SB600 doesn't have secondary port wired */
> - if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
> + if (pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE)
> ppi[1] = &ata_dummy_port_info;
>
> return ata_pci_bmdma_init_one(pdev, ppi, &atiixp_sht, NULL,
> --
> 2.18.0
>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pata_atiixp: Remove unnecessary parentheses
2018-09-11 21:43 [PATCH] pata_atiixp: Remove unnecessary parentheses Nathan Chancellor
2018-09-11 21:49 ` Nick Desaulniers
@ 2018-09-11 22:57 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2018-09-11 22:57 UTC (permalink / raw)
To: Nathan Chancellor, Bartlomiej Zolnierkiewicz
Cc: linux-ide, linux-kernel, Nick Desaulniers
On 9/11/18 3:43 PM, Nathan Chancellor wrote:
> Clang warns when more than one set of parentheses is used for a
> single conditional statement:
>
> drivers/ata/pata_atiixp.c:282:19: warning: equality comparison with
> extraneous parentheses [-Wparentheses-equality]
> if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
> ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/ata/pata_atiixp.c:282:19: note: remove extraneous parentheses
> around the comparison to silence this warning
> if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
> ~ ^ ~
> drivers/ata/pata_atiixp.c:282:19: note: use '=' to turn this equality
> comparison into an assignment
> if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
> ^~
> =
> 1 warning generated.
Applied for 4.20, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-11 22:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-11 21:43 [PATCH] pata_atiixp: Remove unnecessary parentheses Nathan Chancellor
2018-09-11 21:49 ` Nick Desaulniers
2018-09-11 22:57 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).